Page MenuHomePhabricator

Implement front-end of private registration in registration pop-up
Closed, ResolvedPublic3 Estimated Story Points

Description

NOTE: This ticket is for the general front-end implementation with the language before we do the P+E Dashboard integration. Once we do the integration, we will need to update the language, as per T318828.

As a campaign participant, I want to be able to choose between public and private registration and to clearly understand the differences between the two choices, so that I can register in a way that grants me privacy, if I so choose.

Acceptance Criteria:

  • When the user clicks on the Register for event button:
    • They are shown the event privacy dialog with public registration ON by default.
    • They can switch it off if they need to or leave it as it is.
    • The text under the switch button changes based on whether public registration is on or off.
    • They can proceed to register for the event by clicking "Register"
    • They can choose to not register by clicking the "x" icon on the top left, which will close the dialog
  • Policy language that the participant must opt into in order to register will be:
    • Public registration: Show your username on a public participant list.
    • Private registration: Only the event organizers can see your username in the participant list.

Visual examples:

Public registration onPublic registration off
Event privacy dialog - Public registration on.png (338×760 px, 35 KB)
Event privacy dialog - Public registration off.png (338×760 px, 37 KB)
Screen Recording 2022-10-06 at 11.26.40.gif (1×1 px, 865 KB)

Links
Link to prototype
Link to design specs

Event Timeline

ifried renamed this task from Implement front-end of confidential registration to Implement front-end of confidential registration in registration pop-up.Sep 22 2022, 7:14 PM
ifried updated the task description. (Show Details)
ifried updated the task description. (Show Details)
ifried updated the task description. (Show Details)
ifried renamed this task from Implement front-end of confidential registration in registration pop-up to Implement front-end of private registration in registration pop-up.Sep 23 2022, 1:26 PM

@Ragesoss @cmelo Hello! If someone registers as public and then changes to private, can we remove their username from the dashboard? And how about if someone joins as private and decides to be public?

vyuen set the point value for this task to 3.Sep 28 2022, 3:44 PM

@gonyeahialam Hello! Can you add the updated wireframe images here? Thank you!

ifried removed the point value 3 for this task.
ldelench_wmf set the point value for this task to 3.Oct 6 2022, 1:14 PM

Change 842489 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] Add privacy toggle to the registration dialog

https://gerrit.wikimedia.org/r/842489

@MHorsey-WMF Looking at the patch above, it doesn't look ready for review, right?

nope, lost a bunch of changes from the commit.

nope, lost a bunch of changes from the commit.

Np, I'm moving this back to in progress for now, and I'll review the patch when it's ready.

Change 851615 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] Add privacy toggle to the registration dialog

https://gerrit.wikimedia.org/r/851615

Change 842489 abandoned by Mhorsey:

[mediawiki/extensions/CampaignEvents@master] Add privacy toggle to the registration dialog

Reason:

Made in error

https://gerrit.wikimedia.org/r/842489

Change 851615 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Add privacy toggle to the registration dialog

https://gerrit.wikimedia.org/r/851615

When the user clicks on the Register for event button:
✅ They are shown the event privacy dialog with public registration ON by default.
✅ They can switch it off if they need to or leave it as it is.
✅ The text under the switch button changes based on whether public registration is on or off.
✅ They can proceed to register for the event by clicking "Register"
✅ They can choose to not register by clicking the "x" icon on the top left, which will close the dialog
Policy language that the participant must opt into in order to register will be:
✅ Public registration: Show your username on a public participant list.
✅ Private registration: Only the event organizers can see your username in the participant list.

en desktop chrome:

Screen Recording 2022-11-16 at 5.58.54 PM.gif (1×2 px, 1 MB)

ar android firefox

Screen Recording 2022-11-16 at 7.24.57 PM.gif (1×760 px, 1 MB)


All AC is met and is functioning correctly. One small UI note, inthe comp, the policy language is centered in the middle of the icon, and in the build it is aligned to the top of the icon. @ifried @MHorsey-WMF is this something we want to fix now or make a separate UI ticket for?

comp:

Screen Shot 2022-11-16 at 7.51.34 PM.png (140×1 px, 118 KB)

Screen Shot 2022-11-16 at 7.51.23 PM.png (152×1 px, 104 KB)

build:

Screen Shot 2022-11-16 at 7.48.04 PM.png (102×1 px, 21 KB)

Screen Shot 2022-11-16 at 7.47.45 PM.png (106×1 px, 46 KB)

@vaughnwalters @MHorsey-WMF The title in the explainer text is supposed to be lighter in color than the toggle switch label. This was done purposely to create a hierarchy and distinction between the two headings and reduce confusion.

Screenshot 2022-11-29 at 09.42.11.png (918×2 px, 576 KB)

@vaughnwalters @gonyeahialam both of these are quick fixes, I'll get them done.

Since the fixes are tracked in T323976, should this task go to produt sign-off?

@gonyeahialam are you happy with that?

Since the fixes are tracked in T323976, should this task go to produt sign-off?

Yes

The private registration pop-up is now appearing when people register for events, so I'm marking this as Done.