Make universal skin hook able to modify footer menus
Open, HighPublic
Actions

Assigned To

None

Authored By

	cjming
	Sep 22 2022, 8:51 PM

Description

Background

Coming out of T302116, if/when the new footer component is merged, the footer component only uses SkinAddFooterLinks to hook into the footer menu because of complexity (namely duplicated menu items) introduced when trying to modify footer menus with SkinTemplateNavigation::Universal as well (both would need to be supported for a period for backwards compatibility).

Since SkinAddFooterLinks is being set for deprecation in T315018, we will need to replace this hook accordingly.

Description

Refactor the hook in the footer component to use SkinTemplateNavigation::Universal to modify any of the footer menus. See https://gerrit.wikimedia.org/r/c/mediawiki/core/+/808913.

Acceptance criteria

Decide if SkinAddFooterLinks should be set for deprecation or continue to be supported. << T315018
Both hooks are supported while SkinAddFooterLinks goes through the deprecation process.
Menu items added/modified by either hook are not duplicated.
Tested on maintained skins.
Changes are documented.