Page MenuHomePhabricator

Providing additional coverage based on the code coverage research results
Open, Needs TriagePublic

Description

The areas we seem to be missing code coverage:

  • PoolCounter (https://wikitech.wikimedia.org/wiki/Thumbor#Poolcounter-based; code wikimedia_thumbor/poolcounter/__init__.py)
  • Swift (code wikimedia_thumbor/loader/swift/__init__.py, wikimedia_thumbor/result_storage/swift/swift.py)
  • Error/exception handling
  • Several files in wikimedia_thumbor/logging/
  • Several files in wikimedia_thumbor/error_handlers/
  • wikimedia_thumbor/storage/request/request.py (not sure what this does)
  • wikimedia_thumbor/core/importer.py (not sure what this does)
  • wikimedia_thumbor/core/context_importer.py (not sure what this does)

Testing PoolCounter and Swift might not be possible without getting these services running locally. This might be hard, particularly with Swift.

Event Timeline

Change 841183 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[operations/software/thumbor-plugins@master] WIP: Provide additional tests to cover errors and exceptions

https://gerrit.wikimedia.org/r/841183

Vlad.shapik renamed this task from Providing additional coverage based on the test coverage research results to Providing additional coverage based on the code coverage research results .Oct 14 2022, 11:36 AM

The code coverage has increased from 75% to 76%. It means that 11 lines of errors related code have been covered by tests.

Change 841183 merged by jenkins-bot:

[operations/software/thumbor-plugins@master] Provide additional tests to cover errors caused by wrong engine commands

https://gerrit.wikimedia.org/r/841183

Change 841183 merged by jenkins-bot:

[operations/software/thumbor-plugins@master] Provide additional tests to cover errors caused by wrong engine commands

https://gerrit.wikimedia.org/r/841183

I provided additional tests to cover errors which can be caused by wrong engine commands.