⚓ T318434 PageTools: Move toolbox from main menu to page tools menu

AC	Status	Details
1	✅	T318434#8503919
2	✅	T318434#8503919
3	✅	T318434#8503919
4	✅	T318434#8515554
5	✅	T318434#8503919
6	✅	T318434#8503919

AC	Status	Details
1	⬜	T318434#8529871
2	✅	T318434#8529871
3	✅	T318434#8529871
4	✅	T318434#8529871
5	✅	T318434#8529871
6	✅	T318434#8529871

Subject	Repo	Branch	Lines +/-
Refactor SkinVector22::getTemplateData and add test coverage	mediawiki/skins/Vector	master	+168 -68
Follow-up to c1ebfd58, retrieve first value of array_splice	mediawiki/skins/Vector	master	+3 -3
MainMenu: Print menu now displays in main menu	mediawiki/skins/Vector	master	+6 -3
Prepare data for Page Tools menu	mediawiki/skins/Vector	master	+90 -35
Create new Page Tools menu (feature flagged)	mediawiki/skins/Vector	master	+95 -12
Prepare styles for Page Tools menu	mediawiki/skins/Vector	master	+64 -39
Moving toolbox menu from the sidebar to the Page Tools menu	mediawiki/skins/Vector	master	+40 -1
Move the "tools" menu from the sidebar to the article tools menu	mediawiki/skins/Vector	master	+44 -1
[WIP] Create new article tools menu	mediawiki/skins/Vector	master	+77 -0

Status	Assigned	Task
Resolved	ovasileva	T317884 [EPIC] Vector 2022 post-deployment work
Resolved	ovasileva	T302073 [GOAL] Page Tools available on all wikis
Resolved	bwang	T319349 [M] [PageTools] Split up Menu.template into separate templates, remove SkinVector::decoratePortletsData from modern Vector
Resolved	ovasileva	T318434 PageTools: Move toolbox from main menu to page tools menu

Change 849113 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] [WIP] Create new article tools menu

https://gerrit.wikimedia.org/r/849113

Jdlrobson updated the task description. (Show Details)Oct 25 2022, 5:11 PM

Jdlrobson updated the task description. (Show Details)Oct 25 2022, 5:19 PM

ovasileva renamed this task from [ArticleTools] Move toolbox from main menu to article tools menu to [M] ArticleTools: Move toolbox from main menu to article tools menu.Oct 25 2022, 5:19 PM

ovasileva added a parent task: T319349: [M] [PageTools] Split up Menu.template into separate templates, remove SkinVector::decoratePortletsData from modern Vector.

ovasileva moved this task from Upcoming to Blocked on Others on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q2) board.Oct 25 2022, 5:33 PM

• alexhollender_WMF renamed this task from [M] ArticleTools: Move toolbox from main menu to article tools menu to [M] PageTools: Move toolbox from main menu to page tools menu.Oct 25 2022, 7:22 PM

• alexhollender_WMF updated the task description. (Show Details)

bwang updated the task description. (Show Details)Oct 25 2022, 9:22 PM

This is blocked on T319349.

Change 851703 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] [WIP] Create new Page Tools menu (feature flagged)

https://gerrit.wikimedia.org/r/851703

Jdlrobson moved this task from Blocked on Others to Doing on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q2) board.Nov 2 2022, 8:27 PM

Change 849113 abandoned by Jdrewniak:

[mediawiki/skins/Vector@master] [WIP] Create new article tools menu

Reason:

Abandones in favour of https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/851703

https://gerrit.wikimedia.org/r/849113

Change 843997 abandoned by Jdrewniak:

[mediawiki/skins/Vector@master] Move the "tools" menu from the sidebar to the article tools menu

Reason:

Abandoned in favour of https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/851703

https://gerrit.wikimedia.org/r/843997

Jdlrobson mentioned this in T320927: Create Dropdown and Menu Skin component classes.Nov 3 2022, 9:01 PM

Test wiki created on Patch demo by JDrewniak (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/308cf818b4/w

@alexhollender_WMF I created a patchdemo of the new functionality.

https://patchdemo.wmflabs.org/wikis/308cf818b4/wiki/Dishwasher%20salmon?useskin=vector-2022

The dropdown headings still need styling, but the new menu is mostly there.

I just wanted to verify a few things.

a. The label for the new Page Tools menu should be "Explore more" instead of "Tools".
b. Functionality at lower resolutions: The Views menu ( "create" "history" etc.) fold into the Page Tools menu as they did with More menu.
Visible when resizing browser with the new dropdown open.
c. The label for the Views menu items at lower resolutions is still 'more'. I assume from the prototype it should be 'views' instead (that could be a little tricky).

Observations:
The new Page Tools menu will basically always be visible, including on special pages which recently had the Page Toolbar hidden (unless pinned to side in future I guess):
https://patchdemo.wmflabs.org/wikis/308cf818b4/wiki/Special:RecentChanges?hidebots=1&limit=50&days=7&enhanced=1&urlversion=2&useskin=vector-2022
On that page, also discovered that the RSS feed link has an orange icon, from core... not sure how to handle that.

Test wiki created on Patch demo by JDrewniak (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/be27ed398a/w

Test wiki created on Patch demo by JDrewniak (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/d6c637a418/w

In T318434#8371092, @Jdrewniak wrote:

@alexhollender_WMF I created a patchdemo of the new functionality.
https://patchdemo.wmflabs.org/wikis/308cf818b4/wiki/Dishwasher%20salmon?useskin=vector-2022
a. The label for the new Page Tools menu should be "Explore more" instead of "Tools".

the label should be "Tools", apologies for the confusion

b. Functionality at lower resolutions: The Views menu ( "create" "history" etc.) fold into the Page Tools menu as they did with More menu.
Visible when resizing browser with the new dropdown open.

looks correct

c. The label for the Views menu items at lower resolutions is still 'more'. I assume from the prototype it should be 'views' instead (that could be a little tricky).

it can remain "Tools" at all resolutions

Observations:
The new Page Tools menu will basically always be visible, including on special pages which recently had the Page Toolbar hidden (unless pinned to side in future I guess):
https://patchdemo.wmflabs.org/wikis/308cf818b4/wiki/Special:RecentChanges?hidebots=1&limit=50&days=7&enhanced=1&urlversion=2&useskin=vector-2022

oh jeez, that was a massive oversight on my part 🙉. so we did a bunch of work for nothing. dang. I will somehow need to repent for this. cc @ovasileva

On that page, also discovered that the RSS feed link has an orange icon, from core... not sure how to handle that.

not too big a of a deal if it remains

• alexhollender_WMF updated the task description. (Show Details)Nov 8 2022, 4:21 PM

Change 857028 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Moving toolbox menu from the sidebar to the Page Tools menu

https://gerrit.wikimedia.org/r/857028

Change 857959 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Prepare styles for Page Tools menu

https://gerrit.wikimedia.org/r/857959

Change 858358 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Prepare data for Page Tools menu

https://gerrit.wikimedia.org/r/858358

Change 857028 abandoned by Jdrewniak:

[mediawiki/skins/Vector@master] Moving toolbox menu from the sidebar to the Page Tools menu

Reason:

Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/858358

https://gerrit.wikimedia.org/r/857028

Change 857959 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Prepare styles for Page Tools menu

https://gerrit.wikimedia.org/r/857959

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 22 2022, 7:01 PM

Change 851703 abandoned by Jdrewniak:

[mediawiki/skins/Vector@master] Create new Page Tools menu (feature flagged)

Reason:

https://gerrit.wikimedia.org/r/851703

Jdrewniak moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q2) board.Nov 29 2022, 4:06 PM

Jdrewniak removed Jdrewniak as the assignee of this task.Nov 29 2022, 6:35 PM

Jdrewniak subscribed.

Jdlrobson claimed this task.Nov 29 2022, 6:37 PM

@Mabualruz could you review this patch? https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/858358/

Change 862317 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Add ability to unpin pinnable headers at low resolution.

https://gerrit.wikimedia.org/r/862317

Jdlrobson updated the task description. (Show Details)Dec 1 2022, 6:39 PM

@Jdrewniak and @Mabualruz will prioritize getting a version of https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/858358/ merged by end of week. We'll then drop the priority of this to normal and Mo will refactor this and create the VectorComponentPageTools component in a follow up before we begin QA.

Jdlrobson updated the task description. (Show Details)Dec 5 2022, 9:40 PM

Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q2) board.

Change 858358 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Prepare data for Page Tools menu

https://gerrit.wikimedia.org/r/858358

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.13; 2022-12-05); removed MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Dec 5 2022, 10:00 PM

Dropping to medium since remaining work is code quality not functionality.

ovasileva moved this task from Needs More Work to Doing on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q2) board.Dec 7 2022, 5:38 PM

Change 866495 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] MainMenu: Print menu now displays in main menu

https://gerrit.wikimedia.org/r/866495

Change 866495 merged by jenkins-bot:

[mediawiki/skins/Vector@master] MainMenu: Print menu now displays in main menu

https://gerrit.wikimedia.org/r/866495

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.14; 2022-12-12); removed MW-1.40-notes (1.40.0-wmf.13; 2022-12-05).Dec 8 2022, 8:01 PM

Change 866614 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Follow-up to c1ebfd58, retrieve first value of array_splice

https://gerrit.wikimedia.org/r/866614

Change 866614 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Follow-up to c1ebfd58, retrieve first value of array_splice

https://gerrit.wikimedia.org/r/866614

The remaining work does not block the MVP, but ideally we should wrap this up before the end of 2022:

Existing "More options" landmark name is renamed to "Page tools"
Add PHPUnit tests for any PHP changes made as part of this work

Regarding PHPUnit strive for sufficient coverage rather than full coverage given our time constraint :)

Jdlrobson claimed this task.Jan 5 2023, 6:03 PM

Change 876006 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Refactor SkinVector22::getTemplateData and add test coverage

https://gerrit.wikimedia.org/r/876006

Above patch adds test coverage and completes the A/Cs.

• nray claimed this task.Jan 5 2023, 9:44 PM

Change 876006 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Refactor SkinVector22::getTemplateData and add test coverage

https://gerrit.wikimedia.org/r/876006

Jdlrobson reassigned this task from • nray to Edtadros.Jan 5 2023, 11:23 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q2) board.

Jdlrobson added a subscriber: • nray.

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.18; 2023-01-09); removed MW-1.40-notes (1.40.0-wmf.14; 2022-12-12).Jan 6 2023, 12:01 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Check Pixel. There should be no visual changes.

Screenshot 2023-01-05 at 6.50.58 PM.png (406×1 px, 66 KB)

✅ AC2: When the menu resizes, certain actions e.g. watch, edit should come present

Screen Recording 2023-01-05 at 6.55.55 PM.mov.gif (848×1 px, 724 KB)

Screenshot 2023-01-05 at 6.59.36 PM.png (853×669 px, 238 KB)

@Jdlrobson, I'm assuming this means watch and edit appear in the tools menu when I narrow the page. The concern is that it when the tools menu is not in the sidebar it moves all the way to the left and is above the article. Is this the correct behavior?
✅ AC3: When the feature flag is enabled, the more menu label changes to "Tools"
See Above
❓ AC4: When the feature flag is enabled, the sidebar will not show the toolbox
I'm not sure what this step is asking
✅ AC5: When the feature flag is enabled, the toolbox will appear in the more menu. The headings will be retained.
See AC2.
✅ AC6: When a gadget adds to the toolbox e.g. `mw.util.addPortletLink( 'p-tb', '#', 'purge' ) it should appear inside the new page tools menu. To make this work we must ensure the element #p-tb is present in the DOM.

Screenshot 2023-01-05 at 7.02.54 PM.png (987×1 px, 489 KB)

Screenshot 2023-01-05 at 7.02.43 PM.png (960×900 px, 320 KB)

ovasileva raised the priority of this task from Medium to High.Jan 6 2023, 3:58 PM

@Edtadros

❓ AC4: When the feature flag is enabled, the sidebar will not show the toolbox
I'm not sure what this step is asking

I think it's supposed to say when the feature flag is enabled the tools will not show in the main menu.
Disabled (tools show in main menu)

Screen Shot 2023-01-06 at 10.00.20 AM.png (1×3 px, 3 MB)

Enabled (tools do not show in main menu) {F36014456}

Jdlrobson updated the task description. (Show Details)Jan 6 2023, 5:19 PM

Jdlrobson reassigned this task from Jdlrobson to Edtadros.Jan 6 2023, 5:50 PM

Bugreporter2 awarded a token.Jan 8 2023, 3:38 AM

Bugreporter2 subscribed.

@Edtadros / @Jdlrobson: Hi, the Due Date set for this open task passed a while ago.
Could you please either update or reset the Due Date (by clicking Edit Task), or set the status of this task to resolved in case this task is done? Thanks!

LGoto edited projects, added Web-Team FY2022-23 Q3 Sprint 1; removed Web-Team-Backlog-Archived (Kanbanana-2022-23-Q2).Jan 9 2023, 6:38 PM

LGoto moved this task from Incoming to QA on the Web-Team FY2022-23 Q3 Sprint 1 board.

ovasileva edited projects, added Web-Team FY2022-23 Q3 Sprint 2; removed Web-Team FY2022-23 Q3 Sprint 1.Jan 9 2023, 7:09 PM

ovasileva edited projects, added Web-Team FY2022-23 Q3 Sprint 1; removed Web-Team FY2022-23 Q3 Sprint 2.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Revised QA step per T318434#8505122
✅ AC4: When the feature flag is
Enabled (tools do not show in main menu)

Screenshot 2023-01-10 at 8.29.52 PM.png (841×1 px, 538 KB)

Disabled (tools show in main menu)

Screenshot 2023-01-10 at 8.30.10 PM.png (970×1 px, 551 KB)

Aklapper removed Due Date which was set to Oct 24 2022, 7:00 AM.Jan 16 2023, 9:25 AM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

⬜ AC1: Check Pixel. There should be no visual changes.
not testable in production
✅ AC2: When the menu resizes, certain actions e.g. watch, edit should come present

Screenshot 2023-01-16 at 6.35.46 PM.png (783×696 px, 67 KB)

Screenshot 2023-01-16 at 6.35.18 PM.png (827×676 px, 213 KB)

✅ AC3: When the feature flag is enabled, the more menu label changes to "Tools"
See Above
✅ AC4: When the feature flag is
Enabled (tools do not show in main menu)

Screenshot 2023-01-16 at 6.37.09 PM.png (715×1 px, 304 KB)

Screenshot 2023-01-16 at 6.37.19 PM.png (736×1 px, 312 KB)

Disabled (tools show in main menu)

Screenshot 2023-01-16 at 7.15.11 PM.png (816×1 px, 341 KB)

✅ AC5: When the feature flag is enabled, the toolbox will appear in the more menu. The headings will be retained.
See AC2.
✅ AC6: When a gadget adds to the toolbox e.g. `mw.util.addPortletLink( 'p-tb', '#', 'purge' ) it should appear inside the new page tools menu. To make this work we must ensure the element #p-tb is present in the DOM.

Screenshot 2023-01-16 at 7.17.23 PM.png (949×1 px, 335 KB)

Screenshot 2023-01-16 at 7.17.12 PM.png (931×1 px, 383 KB)

Edtadros updated the task description. (Show Details)Jan 17 2023, 3:21 AM

Jdlrobson renamed this task from [M] PageTools: Move toolbox from main menu to page tools menu to PageTools: Move toolbox from main menu to page tools menu.Jan 17 2023, 5:52 PM

Jdlrobson changed the point value for this task from 1 to 3.

ovasileva closed this task as Resolved.Jan 23 2023, 3:28 PM

Test wiki on Patch demo by JDrewniak (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/308cf818b4/w/~~

Test wiki on Patch demo by JDrewniak (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/be27ed398a/w/~~

Test wiki on Patch demo by JDrewniak (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/d6c637a418/w/~~

PageTools: Move toolbox from main menu to page tools menu
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Prototype

TODO

QA steps

QA Results - Beta

QA Results - Prod

Details

Related Objects
Search...

Event Timeline

Test Result - Beta

QA Steps

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

	F36269413: Screenshot 2023-01-16 at 7.17.12 PM.png
	Jan 17 2023, 3:18 AM

	F36269412: Screenshot 2023-01-16 at 7.17.23 PM.png
	Jan 17 2023, 3:18 AM

	F36269399: Screenshot 2023-01-16 at 7.15.11 PM.png
	Jan 17 2023, 3:18 AM

	F36269392: Screenshot 2023-01-16 at 6.37.19 PM.png
	Jan 17 2023, 3:18 AM

	F36269391: Screenshot 2023-01-16 at 6.37.09 PM.png
	Jan 17 2023, 3:18 AM

	F36269308: Screenshot 2023-01-16 at 6.35.18 PM.png
	Jan 17 2023, 3:18 AM

	F36269307: Screenshot 2023-01-16 at 6.35.46 PM.png
	Jan 17 2023, 3:18 AM

	F36103503: Screenshot 2023-01-10 at 8.30.10 PM.png
	Jan 11 2023, 4:31 AM

	Jdlrobson
	Sep 23 2022, 5:18 PM

PageTools: Move toolbox from main menu to page tools menuClosed, ResolvedPublic3 Estimated Story PointsActions

Description

Prototype

TODO

QA steps

QA Results - Beta

QA Results - Prod

Details

Related ObjectsSearch...

Event Timeline

Test Result - Beta

QA Steps

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

PageTools: Move toolbox from main menu to page tools menu
Closed, ResolvedPublic3 Estimated Story Points
Actions

Related Objects
Search...