Page MenuHomePhabricator

Enable "Your unstarred mentees" at the biggest Growth wikis
Closed, ResolvedPublic

Description

In October 2021, the Growth team removed "Your unstarred mentees" from arwiki, enwiki and fawiki due to T293182. On those wikis, mentors have more than 10k mentees on average. Unfortunately, the filtering logic for Special:RecentChanges must generate up to 10k of users at maximum for performance reasons. As a stop-gap fix, the unstarred option was removed – mentors are not expected to star 10k+ users.

This option should be re-introduced for those three wikis. There is one main requirements for that: Special:RecentChanges must be real-time (if an old mentee revives, they need to be immediately shown; same for a newly-registered mentee).

The easiest solution would be to check whether the mentee is included in the Mentee overview module first, but that's not feasible, as it makes recent changes not real-time. Instead, I suggest the following:

  • Add a flag, gemm_mentee_is_active, to growthexperiments_mentor_mentee.
  • The flag will be a boolean that's TRUE by default (takes care of new mentees).
  • A maintenance script will run regularly, setting the flag to FALSE for all users that edited more than 6 months ago.
  • An onPageSaveComplete hook will re-set the flag to TRUE if the user edits and their flag is FALSE (takes care of old mentees returning).

Once the flag is populated, change the mentorship-related filters code to only include users with gemm_is_active=TRUE.

Acceptance criteria
  • Mentors at arwiki, enwiki and fawiki can use filters at Special:RecentChanges to filter RC down to their mentees (not just "starred mentes"). Currently available options are at F35531336, desired at F35531338 (same as on all the other wikis).
  • Events from a freshly registered mentees are shown in the filtered version of Special:RecentChanges (as in, if an user registers, their mentor can immediately see their edits in Special:RecentChanges filtered to mentees-only).

Details

SubjectRepoBranchLines +/-
operations/mediawiki-configmaster+0 -5
operations/puppetproduction+6 -0
operations/mediawiki-configmaster+5 -0
operations/mediawiki-configmaster+0 -5
mediawiki/extensions/GrowthExperimentsmaster+9 -1
operations/mediawiki-configmaster+0 -8
mediawiki/extensions/GrowthExperimentswmf/1.40.0-wmf.10+17 -2
mediawiki/extensions/GrowthExperimentswmf/1.40.0-wmf.8+17 -2
mediawiki/extensions/GrowthExperimentsmaster+17 -2
mediawiki/extensions/GrowthExperimentswmf/1.40.0-wmf.8+5 -8
mediawiki/extensions/GrowthExperimentswmf/1.40.0-wmf.8+24 -33
mediawiki/extensions/GrowthExperimentsmaster+5 -8
mediawiki/extensions/GrowthExperimentsmaster+24 -33
mediawiki/extensions/GrowthExperimentswmf/1.40.0-wmf.8+3 -1
mediawiki/extensions/GrowthExperimentswmf/1.40.0-wmf.8+400 -9
mediawiki/extensions/GrowthExperimentsmaster+3 -1
mediawiki/extensions/GrowthExperimentsmaster+8 -0
mediawiki/extensions/GrowthExperimentsmaster+392 -9
operations/mediawiki-configmaster+8 -0
mediawiki/extensions/GrowthExperimentsmaster+7 -4
mediawiki/extensions/GrowthExperimentsmaster+119 -4
Show related patches Customize query in gerrit

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 853487 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] updateIsActiveFlagForMentees.php: Wait for replication

https://gerrit.wikimedia.org/r/853487

Change 853487 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] updateIsActiveFlagForMentees.php: Wait for replication

https://gerrit.wikimedia.org/r/853487

Change 853481 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] MentorFilterHooks: Only consider active mentees

https://gerrit.wikimedia.org/r/853481

Change 853509 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.8] Add support for gemm_mentee_is_active

https://gerrit.wikimedia.org/r/853509

Change 853444 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.8] MentorFilterHooks: Only consider active mentees

https://gerrit.wikimedia.org/r/853444

Change 853509 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.8] Add support for gemm_mentee_is_active

https://gerrit.wikimedia.org/r/853509

Mentioned in SAL (#wikimedia-operations) [2022-11-07T06:54:58Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:853509|Add support for gemm_mentee_is_active (T318457)]], [[gerrit:853440|Calculate mentorship-related metrics (T318684)]]

Mentioned in SAL (#wikimedia-operations) [2022-11-07T06:55:22Z] <urbanecm@deploy1002> urbanecm and urbanecm: Backport for [[gerrit:853509|Add support for gemm_mentee_is_active (T318457)]], [[gerrit:853440|Calculate mentorship-related metrics (T318684)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-11-07T07:01:25Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:853509|Add support for gemm_mentee_is_active (T318457)]], [[gerrit:853440|Calculate mentorship-related metrics (T318684)]] (duration: 06m 27s)

Mentioned in SAL (#wikimedia-operations) [2022-11-07T07:02:01Z] <urbanecm> Run time mwscript extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php --wiki=cswiki in a tmux at mwmaint1002 (T318457)

Mentioned in SAL (#wikimedia-operations) [2022-11-07T07:05:03Z] <urbanecm> Run time mwscript extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php --wiki=bnwiki in a tmux at mwmaint1002 (T318457)

Mentioned in SAL (#wikimedia-operations) [2022-11-07T07:44:29Z] <urbanecm> Run time mwscript extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php --wiki=frwiki in a tmux at mwmaint1002 (T318457)

Good news is that the script is quite fast:

[urbanecm@mwmaint1002 ~]$ time mwscript extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php --wiki=cswiki # 62608 mentees

real    1m49.643s
user    0m26.292s
sys     0m4.206s
[urbanecm@mwmaint1002 ~]$ time mwscript extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php --wiki=bnwiki # 58791 mentees

real    1m4.985s
user    0m19.055s
sys     0m2.597s
[urbanecm@mwmaint1002 ~]$ time mwscript extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php --wiki=frwiki # 503071 mentees

real    12m35.959s
user    3m21.671s
sys     0m30.148s
[urbanecm@mwmaint1002 ~]$

Bad news is that there is surprisingly high number of active mentees:

wikiadmin@10.64.48.111(cswiki)> select gemm_mentee_is_active, count(*) from growthexperiments_mentor_mentee where gemm_mentor_role='primary' group by gemm_mentee_is_active;
+-----------------------+----------+
| gemm_mentee_is_active | count(*) |
+-----------------------+----------+
|                     0 |    12275 |
|                     1 |    35605 |
+-----------------------+----------+
2 rows in set (0.048 sec)

wikiadmin@10.64.48.111(bnwiki)> select gemm_mentee_is_active, count(*) from growthexperiments_mentor_mentee where gemm_mentor_role='primary' group by gemm_mentee_is_active;
+-----------------------+----------+
| gemm_mentee_is_active | count(*) |
+-----------------------+----------+
|                     0 |     5533 |
|                     1 |    31511 |
+-----------------------+----------+
2 rows in set (0.040 sec)

wikiadmin@10.64.48.111(frwiki)> select gemm_mentee_is_active, count(*) from growthexperiments_mentor_mentee where gemm_mentor_role='primary' group by gemm_mentee_is_active;
+-----------------------+----------+
| gemm_mentee_is_active | count(*) |
+-----------------------+----------+
|                     0 |    75575 |
|                     1 |   283851 |
+-----------------------+----------+
2 rows in set (0.269 sec)

wikiadmin@10.64.48.111(frwiki)>

frwiki's max_mentees went from 11823 down to 8429, which is still fairly high, and I don't think the we'd be able to get the numbers under 10k on arwiki/fawiki (both ~35k) or enwiki (~58k and growing).

This is probably caused by the fact that all users who ever used Special:Homepage technically have a mentor, even users with years of experience.

I think we can fix this by further lowering the treshold from 6 months to $wgRCMaxAge . That will lock gemm_mentee_is_active column to RC-only information, but the number of active users in that definition will go significantly down (hopefully, well-under 10k for all of our wikis).

Next step: Run queries to figure out whether using $wgRCMaxAge will get the numbers down, or whether we need to lower the numbers in some other way.

Mentioned in SAL (#wikimedia-operations) [2022-11-09T14:46:08Z] <urbanecm> Run time mwscript extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php --wiki=frwiki in a tmux at mwmaint1002 (locally applied shorter MentorStore::INACTIVITY_THRESHOLD; T318457)

The cause of the surprisingly high number of active users is that the script only processes mentees mentored by current mentors. Strictly speaking, that's not an issue – mentorship filters can only be used by current mentors anyway. However, it's not intuintive to have the column only updated for certain mentees, so I'm uploading a patch to update it for all mentees.

Change 855014 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] updateIsActiveFlagForMentees: Process all mentees

https://gerrit.wikimedia.org/r/855014

Change 853444 abandoned by Urbanecm:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.8] MentorFilterHooks: Only consider active mentees

Reason:

https://gerrit.wikimedia.org/r/853444

Change 856560 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] MentorStore: Use $wgRCMaxAge instead of INACTIVITY_THRESHOLD

https://gerrit.wikimedia.org/r/856560

Change 855014 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] updateIsActiveFlagForMentees: Process all mentees

https://gerrit.wikimedia.org/r/855014

Change 856560 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] MentorStore: Use $wgRCMaxAge instead of INACTIVITY_THRESHOLD

https://gerrit.wikimedia.org/r/856560

Change 856579 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.8] updateIsActiveFlagForMentees: Process all mentees

https://gerrit.wikimedia.org/r/856579

Change 856988 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.8] MentorStore: Use $wgRCMaxAge instead of INACTIVITY_THRESHOLD

https://gerrit.wikimedia.org/r/856988

Change 856579 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.8] updateIsActiveFlagForMentees: Process all mentees

https://gerrit.wikimedia.org/r/856579

Change 856988 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.8] MentorStore: Use $wgRCMaxAge instead of INACTIVITY_THRESHOLD

https://gerrit.wikimedia.org/r/856988

Mentioned in SAL (#wikimedia-operations) [2022-11-15T14:51:38Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:856579|updateIsActiveFlagForMentees: Process all mentees (T318457)]], [[gerrit:856988|MentorStore: Use $wgRCMaxAge instead of INACTIVITY_THRESHOLD (T318457)]]

Mentioned in SAL (#wikimedia-operations) [2022-11-15T14:52:09Z] <urbanecm@deploy1002> urbanecm and urbanecm: Backport for [[gerrit:856579|updateIsActiveFlagForMentees: Process all mentees (T318457)]], [[gerrit:856988|MentorStore: Use $wgRCMaxAge instead of INACTIVITY_THRESHOLD (T318457)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-11-15T14:57:22Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:856579|updateIsActiveFlagForMentees: Process all mentees (T318457)]], [[gerrit:856988|MentorStore: Use $wgRCMaxAge instead of INACTIVITY_THRESHOLD (T318457)]] (duration: 05m 44s)

Mentioned in SAL (#wikimedia-operations) [2022-11-15T14:59:22Z] <urbanecm> Run time mwscript extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php --wiki=frwiki at mwmaint1002 (T318457)

Mentioned in SAL (#wikimedia-operations) [2022-11-15T15:15:28Z] <urbanecm> Run time mwscript extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php --wiki=bnwiki at mwmaint1002 (T318457)

Running the script with the two fixes (threshold set to wgRCMaxAge exactly + script processes all mentees). Script for bnwiki:

wikiadmin@10.64.0.164(bnwiki)> select gemm_mentee_is_active, count(*) from growthexperiments_mentor_mentee group by gemm_mentee_is_active;
+-----------------------+----------+
| gemm_mentee_is_active | count(*) |
+-----------------------+----------+
|                     0 |     5533 |
|                     1 |    54161 |
+-----------------------+----------+
2 rows in set (0.056 sec)

[urbanecm@mwmaint1002 ~]$ time mwscript extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php --wiki=bnwiki
Skipping user ID 390409, user identity not found.
Skipping user ID 394025, user identity not found.
Skipping user ID 391068, user identity not found.
Skipping user ID 393128, user identity not found.
[...]

real    0m52.162s
user    0m12.609s
sys     0m1.650s
[urbanecm@mwmaint1002 ~]$

wikiadmin@10.64.48.111(bnwiki)> select gemm_mentee_is_active, count(*) from growthexperiments_mentor_mentee group by gemm_mentee_is_active;
+-----------------------+----------+
| gemm_mentee_is_active | count(*) |
+-----------------------+----------+
|                     0 |     9770 |
|                     1 |    49924 |
+-----------------------+----------+
2 rows in set (0.039 sec)

Slightly better, but the number of active users is still pretty high (the not found user identities are caused by faulty rows in growthexperiments_mentor_mentee, see T323128).

Mentioned in SAL (#wikimedia-operations) [2022-11-15T15:49:48Z] <urbanecm> Run time mwscript extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php --wiki=ptwiki at mwmaint1002 (T318457)

Mentioned in SAL (#wikimedia-operations) [2022-11-15T16:20:14Z] <urbanecm> Run time mwscript extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php --wiki=arwiki at mwmaint1002 (T318457)

Mentioned in SAL (#wikimedia-operations) [2022-11-15T17:02:07Z] <urbanecm> Run time mwscript extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php --wiki=fawiki at mwmaint1002 (T318457)

Mentioned in SAL (#wikimedia-operations) [2022-11-15T16:20:14Z] <urbanecm> Run time mwscript extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php --wiki=arwiki at mwmaint1002 (T318457)

arwiki went down from 34543 max_mentees to 24542. It's better, but still a lot rows to handle. Trying fawiki now (35400 max_mentees), but I wouldn't be surprised if it goes similarly.

Mentioned in SAL (#wikimedia-operations) [2022-11-15T17:16:10Z] <urbanecm> Run time mwscript extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php --wiki=enwiki at mwmaint1002 (T318457)

Mentioned in SAL (#wikimedia-operations) [2022-11-15T18:06:03Z] <urbanecm> Run time mwscript extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php --wiki=idwiki at mwmaint1002 (T318457)

An alternative approach, if this doesn't work out, would be to put gemm_mentee_is_active into a table on the default cluster, then a high number of active mentees wouldn't be problematic for filtering.

An alternative approach, if this doesn't work out, would be to put gemm_mentee_is_active into a table on the default cluster, then a high number of active mentees wouldn't be problematic for filtering.

I think we'll have to resort to moving growthexperiments_mentor_mentee to the main cluster indeed; the number of mentees by mentor for the biggest wikis is still high, unfortunately.

Mentioned in SAL (#wikimedia-operations) [2022-11-16T10:30:06Z] <urbanecm> Run mwscript extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php for all wikis in growthexperiments.dblist at mwmaint1002 (T318457)

Mentioned in SAL (#wikimedia-operations) [2022-11-16T18:10:20Z] <urbanecm> Run time mwscript extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php --wiki=frwiki at mwmaint1002 (T318457)

Change 857724 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] updateIsActiveFlagForMentees: Treat "no edits" user correctly

https://gerrit.wikimedia.org/r/857724

Change 857724 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] updateIsActiveFlagForMentees: Treat "no edits" user correctly

https://gerrit.wikimedia.org/r/857724

Change 857437 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.8] updateIsActiveFlagForMentees: Treat "no edits" user correctly

https://gerrit.wikimedia.org/r/857437

Change 857438 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.10] updateIsActiveFlagForMentees: Treat "no edits" user correctly

https://gerrit.wikimedia.org/r/857438

Change 857776 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/puppet@production] GrowthExperiments: Run updateIsActiveFlagForMentees weekly

https://gerrit.wikimedia.org/r/857776

Change 857437 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.8] updateIsActiveFlagForMentees: Treat "no edits" user correctly

https://gerrit.wikimedia.org/r/857437

Change 857438 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.10] updateIsActiveFlagForMentees: Treat "no edits" user correctly

https://gerrit.wikimedia.org/r/857438

Mentioned in SAL (#wikimedia-operations) [2022-11-16T21:22:55Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:857621|Enable Reading Lists landing page on a few smaller wikis. (T313269)]], [[gerrit:857437|updateIsActiveFlagForMentees: Treat "no edits" user correctly (T318457)]], [[gerrit:857438|updateIsActiveFlagForMentees: Treat "no edits" user correctly (T318457)]]

Mentioned in SAL (#wikimedia-operations) [2022-11-16T21:23:21Z] <urbanecm@deploy1002> urbanecm and urbanecm and dbrant: Backport for [[gerrit:857621|Enable Reading Lists landing page on a few smaller wikis. (T313269)]], [[gerrit:857437|updateIsActiveFlagForMentees: Treat "no edits" user correctly (T318457)]], [[gerrit:857438|updateIsActiveFlagForMentees: Treat "no edits" user correctly (T318457)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2

Mentioned in SAL (#wikimedia-operations) [2022-11-16T21:29:01Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:857621|Enable Reading Lists landing page on a few smaller wikis. (T313269)]], [[gerrit:857437|updateIsActiveFlagForMentees: Treat "no edits" user correctly (T318457)]], [[gerrit:857438|updateIsActiveFlagForMentees: Treat "no edits" user correctly (T318457)]] (duration: 06m 05s)

Change 853482 merged by jenkins-bot:

[operations/mediawiki-config@master] [Growth] Do not override wgGEMentorshipUseIsActiveFlag

https://gerrit.wikimedia.org/r/853482

Mentioned in SAL (#wikimedia-operations) [2022-11-16T21:30:42Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:853482|[Growth] Do not override wgGEMentorshipUseIsActiveFlag (T318457)]]

Mentioned in SAL (#wikimedia-operations) [2022-11-16T21:31:06Z] <urbanecm@deploy1002> urbanecm and urbanecm: Backport for [[gerrit:853482|[Growth] Do not override wgGEMentorshipUseIsActiveFlag (T318457)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-11-16T21:37:26Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:853482|[Growth] Do not override wgGEMentorshipUseIsActiveFlag (T318457)]] (duration: 06m 43s)

Mentioned in SAL (#wikimedia-operations) [2022-11-16T21:41:39Z] <urbanecm> Run time mwscript extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.phpfor all wikis in growthexperiments.dblist (T318457)

Change 857784 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] updateIsActiveFlagForMentees: Drop mentorship entries for invalid users

https://gerrit.wikimedia.org/r/857784

An alternative approach, if this doesn't work out, would be to put gemm_mentee_is_active into a table on the default cluster, then a high number of active mentees wouldn't be problematic for filtering.

I think we'll have to resort to moving growthexperiments_mentor_mentee to the main cluster indeed; the number of mentees by mentor for the biggest wikis is still high, unfortunately.

Good news: There indeed was a bug in the updateIsActiveFlagForMentees.php (credits go to Tgr for spotting it). This is now fixed (T318457#8400586), and data from frwiki show that it does the trick (finally! :)).

Next steps are to let the script run weekly via puppet (scheduled for 2022-11-17) and then we should be able to enable the filters for arwiki/enwiki/fawiki as well.

Change 857785 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] GrowthExperiments: Enable unstarred mentorship filters at all wikis

https://gerrit.wikimedia.org/r/857785

Change 857790 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Remove GEMentorshipUseIsActiveFlag

https://gerrit.wikimedia.org/r/857790

Change 857784 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] updateIsActiveFlagForMentees: Drop mentorship entries for invalid users

https://gerrit.wikimedia.org/r/857784

Mentioned in SAL (#wikimedia-operations) [2022-11-17T12:01:09Z] <urbanecm> [urbanecm@mwmaint1002 ~]$ time mwscript extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php --wiki=enwiki # T318457

Mentioned in SAL (#wikimedia-operations) [2022-11-17T12:02:06Z] <urbanecm> [urbanecm@mwmaint1002 ~]$ time mwscript extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php --wiki=trwiki # T318457

Change 857785 merged by jenkins-bot:

[operations/mediawiki-config@master] GrowthExperiments: Enable unstarred mentorship filters at all wikis

https://gerrit.wikimedia.org/r/857785

Change 858314 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] Revert "GrowthExperiments: Enable unstarred mentorship filters at all wikis"

https://gerrit.wikimedia.org/r/858314

Change 858314 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "GrowthExperiments: Enable unstarred mentorship filters at all wikis"

https://gerrit.wikimedia.org/r/858314

Change 857776 merged by RLazarus:

[operations/puppet@production] GrowthExperiments: Run updateIsActiveFlagForMentees weekly

https://gerrit.wikimedia.org/r/857776

Change 858414 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] GrowthExperiments: Enable unstarred mentorship filters at all wikis

https://gerrit.wikimedia.org/r/858414

Change 858414 merged by jenkins-bot:

[operations/mediawiki-config@master] GrowthExperiments: Enable unstarred mentorship filters at all wikis

https://gerrit.wikimedia.org/r/858414

Mentioned in SAL (#wikimedia-operations) [2022-11-21T08:23:46Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:858414|GrowthExperiments: Enable unstarred mentorship filters at all wikis (T318457)]]

Mentioned in SAL (#wikimedia-operations) [2022-11-21T08:24:16Z] <urbanecm@deploy1002> urbanecm and urbanecm: Backport for [[gerrit:858414|GrowthExperiments: Enable unstarred mentorship filters at all wikis (T318457)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-11-21T08:31:50Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:858414|GrowthExperiments: Enable unstarred mentorship filters at all wikis (T318457)]] (duration: 08m 04s)

Urbanecm_WMF changed the task status from In Progress to Open.Nov 21 2022, 8:35 AM
Urbanecm_WMF moved this task from In Progress to QA on the Growth-Team (Sprint 0 (Growth Team)) board.

This is now done!

Etonkovidova subscribed.

Checked on testwiki wmf.14(for different wrokflows) and on enwiki wmf.14 (for the presence of the filter).

What workflows checked

  • a user opts out from assigned mentor - a mentor stops seeing that user in mentees filters
  • mentor marks an unstarred mentee as starred - the unstarred mentee filter correctly exclude that mentee