Page MenuHomePhabricator
Create Task
Maniphest T318463

IP Info accordion should show up on the Special:DeletedContributions
Closed, ResolvedPublic5 Estimated Story PointsFeature
Actions

Assigned To
Cyndymediawiksim
Authored By
• Prtksxna
Sep 24 2022, 5:43 AM
Tags
Referenced Files
F35886503: T318463_IP Info_ Special-DeletedContributions_Timeless_full.png
Dec 21 2022, 11:30 PM
F35886505: T318463_IP Info_ Special-DeletedContributions_Vector2010_full.png
Dec 21 2022, 11:30 PM
F35886498: T318463_IP Info_ Special-DeletedContributions_Monobook_full.png
Dec 21 2022, 11:30 PM
F35886563: T318463_IP Info_ Special-DeletedContributions_Vector2022_IPInfoNotChecked.png
Dec 21 2022, 11:30 PM
F35886510: T318463_IP Info_ Special-DeletedContributions_Vector2022_basic.png
Dec 21 2022, 11:30 PM
F35886507: T318463_IP Info_ Special-DeletedContributions_Vector2022_full.png
Dec 21 2022, 11:30 PM
F35886479: T318463_IP Info accordion should show up on the Special-DeletedContributions.png
Dec 21 2022, 11:30 PM
F35824148: screenshot-localhost_8080-2022.11.29-17_40_04.png
Nov 29 2022, 2:43 PM
Subscribers
• AGueyte
Aklapper
Cyndymediawiksim
GMikesell-WMF
jwang
• Niharika
• Prtksxna
View All 10 Subscribers

Description

from T309366: Investigate: IP info not shown when all IP's edits are deleted

Feature summary

  • The IP Info feature should show up on the DeletedContributions page
  • It should only show data if there are deleted contributions that the current user has access to see

screenshot-localhost_8080-2022.11.29-17_40_04.png (797×961 px, 198 KB)

Use case(s)

Notes

It may be helpful to see how the infobox is added to Special:Contributions.

General information:

Testing notes

  • It should be possible to test this on beta
  • This should work the same as the infobox on Special:Contributions
  • It's worth testing this all the different permission levels possible for IPInfo

NB: The feedback button and some other links, all added by the WikimediaMessages extension, don't show up on Special:DeletedContributions yet. This will be fixed by: T325214: Ensure WikimediaMessages links show up on IPInfo infobox on Special:DeletedContributions

Details

SubjectRepoBranchLines +/-
Show IPInfo info box on Special:DeletedContributionsmediawiki/extensions/IPInfomaster+50 -19
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Prtksxna created this task.Sep 24 2022, 5:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2022, 5:43 AM
• Prtksxna updated the task description. (Show Details)Sep 24 2022, 5:44 AM
• Prtksxna mentioned this in T309366: Investigate: IP info not shown when all IP's edits are deleted.Sep 24 2022, 5:53 AM
• Prtksxna moved this task from Backlog to Up Next on the IP Info board.Oct 7 2022, 4:52 AM
• Prtksxna triaged this task as Medium priority.Nov 1 2022, 3:59 AM
Tchanders moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Nov 7 2022, 1:48 PM
Tchanders added subscribers: jwang, • Niharika, Tchanders.Nov 16 2022, 4:19 PM

@jwang @Niharika Should we instrument this?

Tchanders set the point value for this task to 5.Nov 16 2022, 4:19 PM
jwang added a comment.Nov 16 2022, 7:33 PM

Should we instrument this?

It make sense to have instrumentation for it. @Niharika, What do you think?

ARamirez_WMF moved this task from Triage/To be Estimated to AHaT Sprint 21: The Bruntal Hat on the Anti-Harassment board.Nov 22 2022, 6:51 PM
ARamirez_WMF edited projects, added Anti-Harassment ( AHaT Sprint 21: The Bruntal Hat); removed Anti-Harassment.
Tchanders updated the task description. (Show Details)Nov 23 2022, 5:57 PM
• TThoabala claimed this task.Nov 24 2022, 5:17 AM
• AGueyte subscribed.Nov 24 2022, 5:39 PM

Hi, @Niharika, @Prtksxna, @Tchanders cc @TThoabala
with this patch https://phabricator.wikimedia.org/T318464, deleted edits are added in the Infobox (if admins, and if exist), linking to Special:DeletedContributions

Would it still make sense to have the Infobox on Special:DeletedContributions, then ?

If we are going forward with this patch, should the infobox also link to Special:DeletedContributions? (it would create a loop).

Thanks,
Anais

Tchanders added a subscriber: Cyndymediawiksim.Nov 28 2022, 3:49 PM

@TThoabala I see you've picked up this task, and @Cyndymediawiksim had also expressed interest in this task (discussed it with me last week). Would it be possible to discuss between you who should take it?

Cyndymediawiksim claimed this task.Nov 29 2022, 6:36 AM
Cyndymediawiksim moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment ( AHaT Sprint 21: The Bruntal Hat) board.
Cyndymediawiksim added a subscriber: • TThoabala.
Cyndymediawiksim updated the task description. (Show Details)Nov 29 2022, 2:43 PM
Tchanders added a comment.Nov 29 2022, 2:56 PM
In T318463#8420478, @AGueyte wrote:

Hi, @Niharika, @Prtksxna, @Tchanders cc @TThoabala
with this patch https://phabricator.wikimedia.org/T318464, deleted edits are added in the Infobox (if admins, and if exist), linking to Special:DeletedContributions

Would it still make sense to have the Infobox on Special:DeletedContributions, then ?

Thanks for pointing this out @AGueyte! I think it will still be useful to have the infobox on Special:DeletedContributions

If we are going forward with this patch, should the infobox also link to Special:DeletedContributions? (it would create a loop).

Perhaps this could link to Special:Contributions instead?

gerritbot added a comment.Dec 5 2022, 5:39 PM

Change 864791 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/IPInfo@master] IPInfo info box should show up on the Special:DeletedContributions

https://gerrit.wikimedia.org/r/864791

gerritbot added a project: Patch-For-Review.Dec 5 2022, 5:39 PM
ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 22: Asian Conical Hat); removed Anti-Harassment ( AHaT Sprint 21: The Bruntal Hat).Dec 6 2022, 3:51 PM
ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 22: Asian Conical Hat) board.
Tchanders mentioned this in T324981: Add ArchivedRevisionHandler endpoint for use with deleted revisions.Dec 12 2022, 2:50 PM
Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 22: Asian Conical Hat) board.Dec 13 2022, 8:16 PM
Tchanders mentioned this in T325214: Ensure WikimediaMessages links show up on IPInfo infobox on Special:DeletedContributions.Dec 14 2022, 5:27 PM
gerritbot added a comment.Dec 16 2022, 11:46 AM

Change 864791 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Show IPInfo info box on Special:DeletedContributions

https://gerrit.wikimedia.org/r/864791

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 16 2022, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 16 2022, 12:30 PM
Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 22: Asian Conical Hat) board.Dec 19 2022, 12:39 PM
Tchanders updated the task description. (Show Details)Dec 19 2022, 1:51 PM
GMikesell-WMF subscribed.Dec 21 2022, 11:30 PM

@Tchanders IpInfo box worked the same in Special:DeletedContributions, just like Special:Contributions except for one skin in MinervaNeue. The IPInfo does not open in Special:DeletedContributions but it does in Special:Contributions as seen in the screenshot below. All the other skins passed with full and basic rights for IPinfo.

Environment: Local
MacOS: 13.1
Browser: Chrome
Permissions tested:

  • Full
  • Basic
  • IPInfo Agreement

Fail
MinervaNeue: IPInfo box does not open on Full and Basic rights but it does in Special:Contributions. Also, the IPInfo agreement does not show up

T318463_IP Info accordion should show up on the Special-DeletedContributions.png (1×1 px, 134 KB)

Pass
Vector 2022: Full Rights

T318463_IP Info_ Special-DeletedContributions_Vector2022_full.png (991×1 px, 174 KB)

Vector 2022: Basic Rights

T318463_IP Info_ Special-DeletedContributions_Vector2022_basic.png (700×1 px, 146 KB)

Vector 2022: IPInfo agreement

T318463_IP Info_ Special-DeletedContributions_Vector2022_IPInfoNotChecked.png (866×1 px, 173 KB)

Monobook: Full Rights screenshot. Basic rights and IPInfo agreement is the same as Vector 2022 but in their respective skin

T318463_IP Info_ Special-DeletedContributions_Monobook_full.png (865×2 px, 233 KB)

Vector2010: Full Rights screenshot. Basic rights and IPInfo agreement is the same as Vector 2022 but in their respective skin

T318463_IP Info_ Special-DeletedContributions_Vector2010_full.png (982×2 px, 221 KB)

Timeless: Full Rights screenshot. Basic rights and IPInfo agreement is the same as Vector 2022 but in their respective skin

T318463_IP Info_ Special-DeletedContributions_Timeless_full.png (1×1 px, 220 KB)

Tchanders mentioned this in T325810: IPInfo infobox is not working on Special:DeletedContibutions in MinervaNeue skin.Dec 22 2022, 12:01 PM

Thanks for finding this @GMikesell-WMF - I've filed a task about it here: T325810: IPInfo infobox is not working on Special:DeletedContibutions in MinervaNeue skin.

If that's the only problem, feel free to move this on.

GMikesell-WMF added a comment.Dec 22 2022, 7:04 PM

Thanks for creating the task @Tchanders . There were no other issues that I came across besides that one so I'll now move this to Done. Thanks again!

GMikesell-WMF moved this task from QA/Testing 🐞 to Done Q2 2022-2023 on the Anti-Harassment (AHaT Sprint 22: Asian Conical Hat) board.Dec 22 2022, 7:05 PM
• Niharika closed this task as Resolved.Mar 1 2023, 1:44 AM
STran mentioned this in T332163: Ensure that IPInfo instrumentation is enabled on Special:DeletedContributions.Mar 15 2023, 12:43 PM
Tchanders closed subtask T324981: Add ArchivedRevisionHandler endpoint for use with deleted revisions as Resolved.Mar 21 2023, 2:12 PM
Tchanders closed subtask T325214: Ensure WikimediaMessages links show up on IPInfo infobox on Special:DeletedContributions as Resolved.
JJMC89 mentioned this in T334245: IPInfo shows "IP information for this address cannot be retrieved since no edits have been made from it." error when there are deleted edits.Apr 12 2023, 8:56 PM
JJMC89 mentioned this in T334625: Should IP Info work on temporary editors with no extant edits?.Apr 13 2023, 7:29 PM
Dreamy_Jazz moved this task from Up Next to Closed on the IP Info board.Feb 3 2024, 12:52 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL