Page MenuHomePhabricator
Create Task
Maniphest T318503

ENC API should expose a JSON update interface
Closed, ResolvedPublic
Actions

Description

The current ENC API mostly uses YAML for its interface, I guess mostly because the Puppet endpoints require that. The update endpoint designed for Horizon and in the future other tools (Terraform, ...) should use the more industry standard JSON instead

Details

SubjectRepoBranchLines +/-
openstack: encapi: new id-based api for Terraformoperations/puppetproduction+183 -5
openstack: modernize puppetleaks scriptoperations/puppetproduction+159 -114
openstack: encapi: format the forbidden errors as jsonoperations/puppetproduction+15 -2
openstack: wmf_sink: set accept header for enc deletion callsoperations/puppetproduction+15 -3
openstack: encapi: support returning data in JSONoperations/puppetproduction+71 -127
openstack: wmcs-enc-cli: explicitely set accept/content-type as yamloperations/puppetproduction+20 -9
enc_api_client: explicitely specify Accept: YAML headeropenstack/horizon/wmf-puppet-dashboardmain+15 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

taavi created this task.Sep 25 2022, 6:16 PM
taavi claimed this task.Oct 21 2022, 6:59 PM
gerritbot added a comment.Oct 21 2022, 7:12 PM

Change 845679 had a related patch set uploaded (by Majavah; author: Majavah):

[openstack/horizon/wmf-puppet-dashboard@main] enc_api_client: explicitely specify Accept: YAML header

https://gerrit.wikimedia.org/r/845679

gerritbot added a project: Patch-For-Review.Oct 21 2022, 7:12 PM
gerritbot added a comment.Oct 21 2022, 7:15 PM

Change 845679 merged by jenkins-bot:

[openstack/horizon/wmf-puppet-dashboard@main] enc_api_client: explicitely specify Accept: YAML header

https://gerrit.wikimedia.org/r/845679

Maintenance_bot removed a project: Patch-For-Review.Oct 21 2022, 7:30 PM
taavi mentioned this in R2073:c58b92d59917: puppetclasses: explicitely specify Accept: YAML.Oct 22 2022, 1:07 PM
gerritbot added a comment.Oct 22 2022, 2:00 PM

Change 845868 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] openstack: wmcs-enc-cli: explicitely set accept/content-type as yaml

https://gerrit.wikimedia.org/r/845868

gerritbot added a project: Patch-For-Review.Oct 22 2022, 2:00 PM

Change 845869 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] openstack: encapi: support returning data in JSON

https://gerrit.wikimedia.org/r/845869

gerritbot added a comment.Oct 24 2022, 1:12 AM

Change 845868 merged by Andrew Bogott:

[operations/puppet@production] openstack: wmcs-enc-cli: explicitely set accept/content-type as yaml

https://gerrit.wikimedia.org/r/845868

gerritbot added a comment.Oct 24 2022, 1:12 AM

Change 845869 merged by Andrew Bogott:

[operations/puppet@production] openstack: encapi: support returning data in JSON

https://gerrit.wikimedia.org/r/845869

gerritbot added a comment.Oct 25 2022, 1:59 PM

Change 849099 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] openstack: wmf_sink: set accept header for enc deletion calls

https://gerrit.wikimedia.org/r/849099

gerritbot added a comment.Oct 25 2022, 2:03 PM

Change 849099 merged by Andrew Bogott:

[operations/puppet@production] openstack: wmf_sink: set accept header for enc deletion calls

https://gerrit.wikimedia.org/r/849099

gerritbot added a comment.Oct 26 2022, 9:26 AM

Change 849494 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] openstack: modernize puppetleaks script

https://gerrit.wikimedia.org/r/849494

gerritbot added a comment.Jan 3 2023, 12:02 PM

Change 874811 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] openstack: encapi: format the forbidden errors as json

https://gerrit.wikimedia.org/r/874811

gerritbot added a comment.Jan 3 2023, 12:02 PM

Change 874812 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] openstack: encapi: new id-based api for Terraform

https://gerrit.wikimedia.org/r/874812

gerritbot added a comment.Jan 3 2023, 4:08 PM

Change 874811 merged by Andrew Bogott:

[operations/puppet@production] openstack: encapi: format the forbidden errors as json

https://gerrit.wikimedia.org/r/874811

gerritbot added a comment.Jan 4 2023, 2:19 PM

Change 849494 merged by David Caro:

[operations/puppet@production] openstack: modernize puppetleaks script

https://gerrit.wikimedia.org/r/849494

fnegri edited projects, added cloud-services-team; removed cloud-services-team (Kanban).Jan 18 2023, 6:37 PM
fnegri moved this task from Kanban to Inbox on the cloud-services-team board.
fgiunchedi added a subscriber: fgiunchedi.Mar 1 2023, 9:41 AM
gerritbot added a comment.Apr 12 2023, 2:52 PM

Change 874812 merged by David Caro:

[operations/puppet@production] openstack: encapi: new id-based api for Terraform

https://gerrit.wikimedia.org/r/874812

Maintenance_bot removed a project: Patch-For-Review.Apr 12 2023, 3:11 PM
taavi closed this task as Resolved.Apr 17 2023, 12:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL