PR: https://github.com/wmde/fundraising-banners/pull/1076

This banner now has the new Visitors vs Donors sentence

@AbbanWMDE Sorry, I missed to update the banner copy. I just changed the task description accordingly. Some issues I found in the banners:

• The close button is too close to the border.
• The headline "Wikimedia Fundraising Campaign" should be centered.
• The headline seems to be overlapping the close button, leaving only the right and top edges of the close button to close the banners.
• Displaying the form error messages add a vertical scrollbar to the container.
• When closing the expanded banner the labels of the progress bar are still there.
• The banner should be hidden when interacting with the search or notification button.
• The threshold for banners size issues is too low. Banners should not be displayed if the available viewport height is lower than the banner height + 60px for the title bar. Currently, it even displays if the "Donate now" thingy at the bottom isn't visible.

Sorry, I noticed two more things:

• The annual plan link section of the use of funds overlay is in German.
• The submit button label is quite long and doesn't break. On small screens, the label overflows the button and looks cut off. The form has a padding of 40 pixels left and right. I'd say, we reduce it to 20 pixels (as the other content's margin) and make the label wrap for very small devices.

@AbbanWMDE Some of the mentioned issues still occur:

• The close button is too close to the right and top border (see screenshots above).
• Displaying the form error messages add a vertical scrollbar to the container.
• The threshold for banners size issues is too low.

And I found some more things:

• I changed the banner copy definition before writing that lengthy comment, but forgot to mention in the comment.
• When clicking the button Donate button in the use of funds overlay, the viewport should scroll to the top of the form.
• The banner copy should highlight the visitors vs donors sentence in the slides and in the expanded banner.

The button issue is weird as it looks fine on mine

Okay, most of those should be fixed. Left to do is the weird button placement and the banner size issue.

@kai.nissen I figured out how to account for the tab in the banner size, and I converted the close icon from a font to an svg so it should be consistent now.

@AbbanWMDE Thanks for fixing those. I need to throw this one back to you, though:

• The campaign day sentence is missing on the 2nd slide.
• The field sets still show scrollbars when a form error is displayed.
• The language parameter is not passed to the Fundraising Application.
• Banner size issues should be triggered when the header bar is not fully visible because of the banner size.

The field sets still show scrollbars when a form error is displayed.

I wasn't able to replicate this until I started an Android emulator. The scrollbars were appearing for a moment when the errors appeared. If that's the same thing that was happening to you then it should be fixed.

Banner size issues should be triggered when the header bar is not fully visible because of the banner size.

Do you mean the pink THE WIKIMEDIA FUNDRAISING CAMPAIGN text? I just added a minimum banner width of 310px in order to hide them when that gets small.

@AbbanWMDE Thanks, the scrollbars are now gone.

If less of the header bar is visible, the banner should not be displayed.

Ah, I see. I increased the size limit to include that bar. Guessing the DE mobile ones don't include it either.

Great, thank you! Can you trigger the screenshot creation for Shutterbug again?

Some change requests:

• The first slide has some redundancies: The text above the progress bar should just say "Our donation target: 9.4 million euros.
• The control banner still says "is displayed over 0 million times". (probably just not redeployed, yet.)
• The links to "Legal Details" and "Privacy Policy" should be removed.

Okay this should be done, it also has the new Use of Funds flags

The first slide has some redundancies: The text above the progress bar should just say "Our donation target: 9.4 million euros.

This is still the case. The headline should say "9.4" instead of "€9.4M". The progress bar now also contains a donation target label, which should be removed.