Page MenuHomePhabricator

Story builder instrumentation has story_already_exists hardcoded to false
Closed, ResolvedPublicBUG REPORT


Steps to replicate the issue (include links if applicable):

  • Edit a story in the Story Builder
  • Inspect the instrumentation network requests

What happens?:
story_already_exists is always false

What should have happened instead?:
story_already_exists should be false for a new story and true for an existing story

Event Timeline

SBisson triaged this task as Medium priority.
SBisson moved this task from Ready for Dev to Dev on the Inuka-Team (Kanban) board.

Change 835631 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/Wikistories@master] Instrumentation: log story_already_exist correctly

Change 835631 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Instrumentation: log story_already_exist correctly

Hi @nshahquinn-wmf , would you like to have a look at this to confirm the changes to the instrumentation?

Hey @nshahquinn-wmf, any chance you have taken a look at this?

An existing story has the story_already_exists as true and a new one has the flag as false.

image.png (648×1 px, 177 KB)
image.png (640×1 px, 156 KB)

Closing this now.

Sorry for the delay! I've just checked the data we've received for this and there are a number of events where story_already_exists. I checked a random sample and the logged values were all correct. We can safely close this.