Opening special characters toolbar blurs the document when using nullSelectionOnBlur (e.g. in DiscussionTools or VE standalone)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Sep 27 2022, 3:00 PM

Description

Open VE standalone, or the DiscussionTools reply widget
Click the special character button Ω

Observed

The document is blurred (cursor position is lost) and the toolbar is disabled as a result:

Expected

Your cursor is left in the document and the toolbar is still enabled:

This bug also appears in some VE integrations, such as DiscussionTools with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/667417 applied.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (8fd8d1451)	mediawiki/extensions/VisualEditor	master	+1 -1
	Add setTimeout to re-focus when opening SpecialCharacterDialog	VisualEditor/VisualEditor	master	+12 -5

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T282153 Expand the tools offered in DiscussionTools' toolbar
Resolved	ppelberg	T249072 Add support in toolbar for special characters within DiscussionTools
Resolved	Esanders	T318720 Opening special characters toolbar blurs the document when using nullSelectionOnBlur (e.g. in DiscussionTools or VE standalone)

Event Timeline

Esanders created this task.Sep 27 2022, 3:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2022, 3:00 PM

Bisect blames https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/735402

Esanders added a project: Regression.Sep 27 2022, 3:01 PM

Esanders updated the task description. (Show Details)Sep 27 2022, 5:08 PM

Esanders renamed this task from Opening special characters toolbar blurs the document in VE standalone to Opening special characters toolbar blurs the document when using nullSelectionOnBlur (e.g. in DiscussionTools or VE standalone).Oct 20 2022, 12:39 PM

Esanders added a project: DiscussionTools.

Esanders updated the task description. (Show Details)

Change 844971 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Add setTimeout to re-focus when opening SpecialCharacterDialog

https://gerrit.wikimedia.org/r/844971

gerritbot added a project: Patch-For-Review.Oct 20 2022, 12:40 PM

Esanders claimed this task.Oct 20 2022, 12:41 PM

Esanders added a parent task: T249072: Add support in toolbar for special characters within DiscussionTools.

Esanders added a project: Editing-team (Kanban Board).

Esanders moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/6bd624a6b7/w

Esanders added a comment.Oct 20 2022, 1:16 PM

This comment was removed by Esanders.

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Oct 20 2022, 3:19 PM

Change 844971 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Add setTimeout to re-focus when opening SpecialCharacterDialog

https://gerrit.wikimedia.org/r/844971

Maintenance_bot removed a project: Patch-For-Review.Oct 20 2022, 6:29 PM

Change 845043 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8fd8d1451)

https://gerrit.wikimedia.org/r/845043

gerritbot added a project: Patch-For-Review.Oct 20 2022, 7:16 PM

Change 845043 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8fd8d1451)

https://gerrit.wikimedia.org/r/845043

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Oct 20 2022, 7:44 PM

matmarex added a project: Editing QA.

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.7; 2022-10-24).Oct 20 2022, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 20 2022, 8:30 PM

✅ Your cursor is left in the document and the toolbar is still enabled:

Screenshot 2022-10-24 at 22.35.39.png (866×2 px, 250 KB)

Screenshot 2022-10-24 at 22.04.08.png (564×2 px, 114 KB)

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Oct 24 2022, 9:36 PM

ppelberg closed this task as Resolved.Oct 25 2022, 4:51 PM

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/6bd624a6b7/w/~~

	F35622634: Screenshot 2022-10-24 at 22.04.08.png
	Oct 24 2022, 9:36 PM

	F35622695: Screenshot 2022-10-24 at 22.35.39.png
	Oct 24 2022, 9:36 PM

Opening special characters toolbar blurs the document when using nullSelectionOnBlur (e.g. in DiscussionTools or VE standalone)Closed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Opening special characters toolbar blurs the document when using nullSelectionOnBlur (e.g. in DiscussionTools or VE standalone)
Closed, ResolvedPublic
Actions

Related Objects
Search...