Page MenuHomePhabricator
Create Task
Maniphest T318745

Changing the related article on the noJS form does not unlink the story from the initial wiki page
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
hueitan
Authored By
• EUdoh-WMF
Sep 27 2022, 7:27 PM
Tags
Referenced Files
F35713475: image.png
Nov 7 2022, 10:22 AM
F35713472: image.png
Nov 7 2022, 10:22 AM
F35662849: image.png
Oct 29 2022, 6:33 PM
F35662785: image.png
Oct 29 2022, 6:33 PM
F35662838: image.png
Oct 29 2022, 6:33 PM
F35629293: image.png
Oct 26 2022, 10:43 AM
F35629297: image.png
Oct 26 2022, 10:43 AM
F35536713: image.png
Sep 27 2022, 7:27 PM
Subscribers
Aklapper
• EUdoh-WMF
hueitan

Description

Steps to replicate the issue (include links if applicable):

  • Create a wikistory for an article
  • Go to the noJS form and change the Related Article to another Wiki page
  • Go to the Special:WhatLinksHere page of the first Wiki article

What happens?:

  • You can still see the Wikistory linked to the first wiki page

What should have happened instead?:

  • You should not see the Wikistory link since it is no longer associated with that page.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

image.png (1×2 px, 351 KB)

E.g. I moved this story from [[ https://en.m.wikipedia.beta.wmflabs.org/wiki/Rapa_Nui_National_Park | Rapa Nui National Park ]]to Batman. However, I can still see the story show up under What Links Here for Rapa Nui.

Details

SubjectRepoBranchLines +/-
Remove link registration from the article title of each image framemediawiki/extensions/Wikistoriesmaster+8 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

• EUdoh-WMF created this task.Sep 27 2022, 7:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2022, 7:27 PM
• EUdoh-WMF mentioned this in T317999: Invalidate stories cache on story deletion.Sep 27 2022, 8:12 PM
PWaigi-WMF added a parent task: T318905: Knowledge Reliability on Wikistories.Sep 29 2022, 8:42 AM
SBisson triaged this task as Medium priority.Oct 25 2022, 2:38 PM
SBisson moved this task from Backlog to Ready for Dev on the Inuka-Team (Kanban) board.
hueitan subscribed.Oct 26 2022, 10:43 AM

This is the first time I access this page, so i can see it correctly under Batman (WhatLinksHere page)

BatmanRapa Nui National Park
image.png (842×1 px, 98 KB)
image.png (677×1 px, 54 KB)
hueitan added a comment.Oct 26 2022, 10:49 AM

does it relevant to the job queue?

Also note that if a page's links change due to a change in the template, the backlinks for that page are not updated immediately, but via the job queue.

• EUdoh-WMF added a comment.Oct 29 2022, 6:33 PM

We can test the theory.

I moved the story A New Day from Batman to Cats. At the time of this comment, the story has not moved from the Batman's What Links Here page to Cat's What Links Here page yet.

image.png (1×1 px, 409 KB)
image.png (1×1 px, 518 KB)
image.png (1×1 px, 422 KB)
hueitan claimed this task.Nov 2 2022, 2:37 PM
hueitan moved this task from Ready for Dev to Dev on the Inuka-Team (Kanban) board.
hueitan added a comment.EditedNov 7 2022, 10:22 AM

Notes:

After page move:

  1. database pagelinks exist for both articles; (62 is the story)

image.png (331×384 px, 16 KB)

  1. running maintenance script refreshLinks.php rebuildall.php doesn't help

image.png (367×562 px, 29 KB)

  1. Interest found, if you move story to another article, then move back to original article, the pagelinks from 2nd article is removed.
gerritbot added a comment.Nov 10 2022, 3:34 PM

Change 855612 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/Wikistories@master] Remove link registration from the article title of each image frame

https://gerrit.wikimedia.org/r/855612

gerritbot added a project: Patch-For-Review.Nov 10 2022, 3:34 PM
SBisson moved this task from Dev to QA on the Inuka-Team (Kanban) board.Nov 10 2022, 3:53 PM
gerritbot added a comment.Nov 10 2022, 5:27 PM

Change 855612 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Remove link registration from the article title of each image frame

https://gerrit.wikimedia.org/r/855612

Maintenance_bot removed a project: Patch-For-Review.Nov 10 2022, 5:31 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 10 2022, 6:00 PM
• EUdoh-WMF moved this task from QA to Design sign off on the Inuka-Team (Kanban) board.Nov 17 2022, 9:43 PM

Tested this again: the story is unlinked immediately from the original wiki page and shows up instantly on What Links Here on the new page.

PatchDemoBot added a comment.Nov 20 2022, 10:21 PM

Test wiki created on Patch demo by HTan (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/8d10c52552/w

PatchDemoBot added a comment.Nov 20 2022, 10:25 PM

Test wiki on Patch demo by HTan (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/8d10c52552/w/

SGautam_WMF moved this task from Design sign off to Product sign off on the Inuka-Team (Kanban) board.Nov 29 2022, 12:15 PM
PWaigi-WMF closed this task as Resolved.Nov 29 2022, 2:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits