Page MenuHomePhabricator

Resolution of protocol-independent wgServer for email messages should not be dependent on the performer's url protocol
Closed, ResolvedPublic

Description

Currently, notification emails get sent using the $wgServer etc configuration of whoever's triggered the action that does the sending, leaving the poor reader to get either SSL or non-SSL links with no good way to predict it.

With the new system & protocol-independent links, I think we have a similar situation.

Should use a setting of the receiver, as we do for language.


Version: unspecified
Severity: minor

Details

Reference
bz29878

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:28 PM
bzimport set Reference to bz29878.
bzimport added a subscriber: Unknown Object (MLST).
  • Bug 19429 has been marked as a duplicate of this bug. ***
  • Bug 31106 has been marked as a duplicate of this bug. ***
  • Bug 31537 has been marked as a duplicate of this bug. ***

*** Bug 32769 has been marked as a duplicate of this bug. ***

Bug 32769 is about setting all links in the emails to https. I like this solution instead of adding yet another preference. WONTFIX this one?

Rephrasing bug summary to reflect the bug instead of a possible solution.

The bug is that users get a mixture of http and https urls based on the performer who triggered the e-mail notification.

One way to fix that is to make it dependent on the receivers preference but that's a feature request that depends on actually having such preference (see bug 29898).

The way to actually fix this bug on its own, for now, is to use the "canonical protocol" instead of the (performer user's) "current protocol".

  • Bug 26294 has been marked as a duplicate of this bug. ***

(In reply to comment #6)

The way to actually fix this bug on its own, for now, is to use the "canonical
protocol" instead of the (performer user's) "current protocol".

This was done about a year ago. Closing this bug because the bug as filed is fixed (e-mail notif URLs no longer depend on sender's protocol), see bug 29898 for making e-mails using the recipient's protocol.

Restricted Application added a subscriber: TerraCodes. · View Herald Transcript