Page MenuHomePhabricator

login.toolforge.org (tools-sgebastion-10) has broken emacs-gtk installed
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • SSH into the non-dev Toolforge bastion, login.toolforge.org
  • open Emacs, e.g. emacs or emacs whatever

What happens?:
Emacs displays an error:

Symbol’s value as variable is void: ispell-menu-map-needed

And shows the scratch buffer. (You can manually visit the file you wanted to open with C-x C-f.)

What should have happened instead?:
Emacs should open the file for editing.

Software version (skip for WMF-hosted wikis like Wikipedia):

lucaswerkmeister@tools-sgebastion-10:~$ emacs --version
GNU Emacs 27.1
Copyright (C) 2020 Free Software Foundation, Inc.
GNU Emacs comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of GNU Emacs
under the terms of the GNU General Public License.
For more information about these matters, see the file named COPYING.
lucaswerkmeister@tools-sgebastion-10:~$ namei $(which emacs)
f: /usr/bin/emacs
 d /
 d usr
 d bin
 l emacs -> /etc/alternatives/emacs
   d /
   d etc
   d alternatives
   l emacs -> /usr/bin/emacs-gtk
     d /
     d usr
     d bin
     - emacs-gtk

Other information (browser name/version, screenshots, etc.):
Strangely enough, dev.toolforge.org, i.e. tools-sgebastion-11, has a different, working Emacs.

lucaswerkmeister@tools-sgebastion-11:~$ emacs --version
GNU Emacs 26.1
Copyright (C) 2018 Free Software Foundation, Inc.
GNU Emacs comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of GNU Emacs
under the terms of the GNU General Public License.
For more information about these matters, see the file named COPYING.
lucaswerkmeister@tools-sgebastion-11:~$ namei $(which emacs)
f: /usr/bin/emacs
 d /
 d usr
 d bin
 l emacs -> /etc/alternatives/emacs
   d /
   d etc
   d alternatives
   l emacs -> /usr/bin/emacs-nox
     d /
     d usr
     d bin
     - emacs-nox

Event Timeline

I think this is due to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=982756

But that doesn't explain why -10 and -11 have different setups.

Both are only supposed to have -nox (the non-graphical one) installed instead of -gtk. The Puppet code pulls in the emacs meta package, and I suspect something changed between -10 and -11 were provisioned which changed which one apt will install by default. I'll send a patch to update that.

Change 836279 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] P:toolforge::shell_environ: explicitely install emacs-nox

https://gerrit.wikimedia.org/r/836279

Change 836279 merged by Andrew Bogott:

[operations/puppet@production] P:toolforge::shell_environ: explicitely install emacs-nox

https://gerrit.wikimedia.org/r/836279

Mentioned in SAL (#wikimedia-cloud) [2022-09-28T21:22:50Z] <lucaswerkmeister> on tools-sgebastion-10: apt remove emacs-common emacs-bin-common # fix package conflict, T318858

Mentioned in SAL (#wikimedia-cloud) [2022-09-28T21:23:32Z] <lucaswerkmeister> on tools-sgebastion-10: run-puppet-agent # T318858

LucasWerkmeister assigned this task to taavi.

This needed a bit of manual action (the Puppet absent uninstalled emacs-gtk but not emacs-common, and apt refused to downgrade that from 1:27.1 to 1:26.1 to install emacs-nox), but seems to be fixed now. Thanks everyone!