Page MenuHomePhabricator
Create Task
Maniphest T318872

Subscribe buttons/links are displayed out of place when next to floating elements on Timeless
Closed, ResolvedPublic
Actions

Description

Subscribe buttons/links are displayed out of place when next to floating elements on Timeless.

Example page: https://es.wikipedia.org/wiki/Usuario_discusión:Ignacio_Rodríguez?useskin=timeless

With topic containersWithout topic containers
image.png (2×3 px, 641 KB)
image.png (2×3 px, 664 KB)

Details

SubjectRepoBranchLines +/-
Simplify implementation of heading underlinesmediawiki/skins/Timelessmaster+17 -26
Improve Timeless compatibility for topic subscriptionsmediawiki/extensions/DiscussionToolsmaster+16 -0
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Sep 28 2022, 9:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 28 2022, 9:13 PM
matmarex added a project: Timeless.Sep 28 2022, 9:13 PM
gerritbot added a comment.Sep 28 2022, 9:40 PM

Change 836299 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Improve Timeless compatibility for topic subscriptions

https://gerrit.wikimedia.org/r/836299

gerritbot added a project: Patch-For-Review.Sep 28 2022, 9:40 PM
matmarex moved this task from Backlog to Triaged on the DiscussionTools board.Nov 3 2022, 3:21 PM
matmarex added a project: Editing-team (Kanban Board).
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Nov 21 2022, 8:08 PM

Change 859133 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/Timeless@master] Simplify implementation of heading underlines

https://gerrit.wikimedia.org/r/859133

gerritbot added a comment.Nov 21 2022, 8:08 PM

Change 836299 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/DiscussionTools@master] Improve Timeless compatibility for topic subscriptions

Reason:

I proposed a patch in Timeless instead.

https://gerrit.wikimedia.org/r/836299

matmarex removed a project: Editing-team (Kanban Board).Nov 21 2022, 9:00 PM
gerritbot added a comment.Nov 21 2022, 9:24 PM

Change 859133 merged by jenkins-bot:

[mediawiki/skins/Timeless@master] Simplify implementation of heading underlines

https://gerrit.wikimedia.org/r/859133

Maintenance_bot removed a project: Patch-For-Review.Nov 21 2022, 9:30 PM
matmarex closed this task as Resolved.Nov 21 2022, 9:53 PM
matmarex claimed this task.
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 21 2022, 10:01 PM
matmarex mentioned this in T314714: Metadata and buttons should be inserted after a heading, not inside of it.Jan 20 2023, 4:27 AM
matmarex mentioned this in T327469: Subscribe buttons/links are displayed out of place due to new heading HTML structure.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL