| • TThoabala | |
| Sep 29 2022, 7:40 AM |
| F35791735: T318896_UploadWizard_GB_CompositeBlock_Chrome.png | |
| Nov 17 2022, 7:06 PM |
| F35791732: T318896_UploadWizard_GB_Sitewide_Chrome.png | |
| Nov 17 2022, 7:06 PM |
| F35791730: T318896_UploadWizard_GB_IPXFF_Chrome.png | |
| Nov 17 2022, 7:06 PM |
| F35791728: T318896_UploadWizard_GB_IPRange_Chrome.png | |
| Nov 17 2022, 7:06 PM |
| F35791726: T318896_UploadWizard_GB_IP_Chrome.png | |
| Nov 17 2022, 7:06 PM |
Following T257701: Add global blocks into CompositeBlocks rather than treating them separately
Remove usage of User::isBlockedGlobally and User::getGlobalBlock in UploadWizard
Usage of User::isBlockedGlobally found here
Usage of User::getGlobalBlock found here
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove GlobalBlocking calls | mediawiki/extensions/UploadWizard | master | +1 -6 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Dreamy_Jazz | T231109 Remove Core coupling with GlobalBlocking extension | |||
| Resolved | Dreamy_Jazz | T319069 Remove global-blocks-specific methods and hook from User class | |||
| Resolved | Spike | Dreamy_Jazz | T315644 Global blocks should be treated as a subtype of blocks | ||
| Resolved | Cyndymediawiksim | T317337 Deprecate global-blocks-specific methods and hook | |||
| Resolved | • TThoabala | T317342 Investigate: Remove use of User::isBlockedGlobally and User::getGlobalBlock from Wikimedia deployed extensions | |||
| Resolved | • AGueyte | T318896 Remove use of User::isBlockedGlobally and User::getGlobalBlock in UploadWizard | |||
| Resolved | Tchanders | T257701 Add global blocks into CompositeBlocks rather than treating them separately | |||
| Resolved | Tchanders | T317308 GlobalBlocking should specify block error message key | |||
| Resolved | • AGueyte | T317201 Allow extensions to modify block error message key via a hook | |||
| Resolved | STran | T317190 GlobalBlock should extend AbstractBlock instead of DatabaseBlock |
Change 855653 had a related patch set uploaded (by AGueyte; author: AGueyte):
[mediawiki/extensions/UploadWizard@master] Remove GlobalBlocking calls
Change 855653 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Remove GlobalBlocking calls
I tested by going to Special:UploadWizard as a logged out user with a global block. I saw the global block message. When I removed the global block, I could use Special:UploadWizard.
@AGueyte I validated that I was receiving a block message when testing global block IP, range, XFF, local sitewide, and composite blocks as seen in the screenshots below for Special:UploadWizard. Please let me know if there is any other testing that you want me to do. If not, is it ok for me to move this to Done?
Test Environment: Local
Browser: Chrome
Global Block IP
Global Block IP Range
Global Block IP XFF
Local Block Sitewide
Composite Block
@AGueyte I validated that I was receiving a block message when testing global block IP, range, XFF, local sitewide, and composite blocks as seen in the screenshots below for Special:UploadWizard. Please let me know if there is any other testing that you want me to do. If not, is it ok for me to move this to Done?
Test Environment: Local
Browser: ChromeGlobal Block IP
Global Block IP Range
Global Block IP XFF
Local Block Sitewide
Composite Block
All good for me, thank you @GMikesell-WMF!