Page MenuHomePhabricator

Remove usage of User::isBlockedGlobally in UrlShortener
Closed, ResolvedPublic2 Estimated Story Points

Description

Following T257701: Add global blocks into CompositeBlocks rather than treating them separately
Remove usage of User::isBlockedGlobally in UrlShortener

Usage found here

Testing

-Block an IP address or User.
-Access the Special:UrlShortener page.If IP is blocked, you will get a message why its blocked and by who.Otherwise, you should be able to access the page.

Event Timeline

Change 856990 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/UrlShortener@master] Remove usage of User::isBlockedGlobally

https://gerrit.wikimedia.org/r/856990

Change 856990 merged by jenkins-bot:

[mediawiki/extensions/UrlShortener@master] Remove usage of User::isBlockedGlobally

https://gerrit.wikimedia.org/r/856990

@Tchanders I validated that I was receiving a block message when testing global block IP, range, XFF, local sitewide, and composite blocks as seen in the screenshots below. Please let me know if there is any other testing that you want me to do. If not, is it ok for me to move this to Done?

Test Environment: Local
Browser: Chrome

Global Block IP

T318897_UrlSho_GB_IP_Chrome_Pass.png (545×1 px, 175 KB)

Global Block IP Range

T318897_UrlSho_GB_Range_Chrome_Pass.png (588×2 px, 212 KB)

Global Block IP XFF

T318897_UrlSho_GB_XFFIP_Chrome_Pass.png (619×1 px, 191 KB)

Local Block Sitewide

T318897_UrlSho_GB_LocalBlockSitewide_Chrome_Pass.png (648×2 px, 213 KB)

Composite Block

T318897_UrlSho_GB_CompositeBlocks_Chrome_Pass.png (564×1 px, 145 KB)