Make it so you can't send a note to yourself
Closed, ResolvedPublicFeature
Actions

Assigned To

Authored By

	Novem_Linguae
	Sep 29 2022, 11:15 AM

Description

Steps to reproduce

Visit an article that was marked as reviewed
Click the check mark to open the review/unreview panel

Feature summary (what you would like to be able to do and where):
If you send a note to yourself in PageTriage, it probably means you selected "reviewer" instead of "creator" accidentally. Perhaps it'd be best to delete the choice from the combo box if the choice is your own name.

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):
Prevent this kind of thing: https://en.wikipedia.org/w/index.php?title=User_talk:Onel5969&diff=1113028024&oldid=1113022234

Benefits (why should this be implemented?):

Details

	Subject	Repo	Branch	Lines +/-
	CurationToolbar: Disallow sending note to self on the tags flyout	mediawiki/extensions/PageTriage	master	+3 -1
	CurationToolbar: Don't allow sending note to yourself	mediawiki/extensions/PageTriage	master	+40 -14

Customize query in gerrit

Event Timeline

Novem_Linguae created this task.Sep 29 2022, 11:15 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 29 2022, 11:15 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

kostajh moved this task from Inbox to Triaged on the Growth-Team board.Oct 12 2022, 1:15 PM

MPGuy2824 changed the task status from Open to In Progress.Oct 29 2022, 10:34 AM

MPGuy2824 claimed this task.

Novem_Linguae moved this task from Backlog to Priority small features on the PageTriage board.Nov 10 2022, 2:38 AM

Change 866147 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[mediawiki/extensions/PageTriage@master] CurationToolbar: Don't allow sending note to yourself

https://gerrit.wikimedia.org/r/866147

gerritbot added a project: Patch-For-Review.Dec 8 2022, 7:14 AM

MPGuy2824 moved this task from Priority small features to Code Review on the PageTriage board.Dec 8 2022, 7:14 AM

Change 866147 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] CurationToolbar: Don't allow sending note to yourself

https://gerrit.wikimedia.org/r/866147

Maintenance_bot removed a project: Patch-For-Review.Jan 3 2023, 12:30 PM

MPGuy2824 moved this task from Code Review to Waiting for enwiki deploy on the PageTriage board.Jan 4 2023, 7:22 AM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Jan 4 2023, 2:01 PM

Similar logic needs to be added to the 'tag' flyout since a note can be sent from there too.

Change 879179 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[mediawiki/extensions/PageTriage@master] CurationToolbar: Disallow sending note to self on the tags flyout

https://gerrit.wikimedia.org/r/879179

gerritbot added a project: Patch-For-Review.Jan 12 2023, 6:51 AM

MPGuy2824 moved this task from Waiting for enwiki deploy to Code Review on the PageTriage board.Jan 13 2023, 3:04 AM

Change 879179 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] CurationToolbar: Disallow sending note to self on the tags flyout

https://gerrit.wikimedia.org/r/879179

Maintenance_bot removed a project: Patch-For-Review.Jan 18 2023, 6:30 PM

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.20; 2023-01-23); removed MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Jan 18 2023, 7:00 PM

Novem_Linguae moved this task from Code Review to Waiting for enwiki deploy on the PageTriage board.Jan 26 2023, 7:46 PM

MPGuy2824 closed this task as Resolved.Jan 30 2023, 4:21 AM

MPGuy2824 moved this task from Waiting for enwiki deploy to Done on the PageTriage board.

Make it so you can't send a note to yourselfClosed, ResolvedPublicFeatureActions

Description

Details

Event Timeline

Make it so you can't send a note to yourself
Closed, ResolvedPublicFeature
Actions