Maniphest T318935

Refactor Java MPC's event sending code
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	phuedx
	Sep 29 2022, 2:32 PM

Tags

Referenced Files

None

Subscribers

Description

Quoting T281772#8260465:

MetricsClient has the responsibility of maintaining and periodically flushing the queue of events. This should be a separate class/collection of classes that MetricsClient collaborates with (see https://gerrit.wikimedia.org/r/c/mediawiki/libs/metrics-platform/+/820530)

<snip />

Events should be sent in batches. EventGate is capable of accepting multiple events in one request

@Gehel's patch is a great start! It needs to be rebased and more tests need to be added, and then event batching needs to be implemented.

TODO

…

Details

	Subject	Repo	Branch	Lines +/-
	Refactor Java event sending	mediawiki/libs/metrics-platform	master	+362 -211

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T228175 Event Platform Client Libraries
		Open		DAbad	T282003 Metrics Platform: Streamline the process to create new instrumentations
		Resolved		• Mholloway	T239996 Send batches of events from EPC app libraries (Java, Swift)
		Open		None	T276378 EPIC: Release Metrics Platform v1
		Resolved		phuedx	T281772 [EPIC] Incorporate librarized Metrics Platform Java client into the Android app
		Resolved		cjming	T318935 Refactor Java MPC's event sending code

Event Timeline

phuedx created this task.Sep 29 2022, 2:32 PM

• EChetty moved this task from Backlog to Ready/Groomed on the Metrics Platform Backlog board.Sep 29 2022, 5:04 PM

• EChetty edited projects, added Metrics Platform Backlog (Metrics Platform Kanban); removed Metrics Platform Backlog.Oct 1 2022, 4:31 PM

• EChetty moved this task from Ready to Next Up on the Metrics Platform Backlog (Metrics Platform Kanban) board.Oct 1 2022, 4:31 PM

Change 838230 had a related patch set uploaded (by Phuedx; author: EJoseph):

[mediawiki/libs/metrics-platform@master] [java] Introduce AtomicReference to make streamConfigs thread safe

https://gerrit.wikimedia.org/r/838230

gerritbot added a project: Patch-For-Review.Oct 10 2022, 2:57 PM

• EChetty moved this task from Next Up to In Progress on the Metrics Platform Backlog (Metrics Platform Kanban) board.Nov 1 2022, 2:50 PM

cjming claimed this task.Nov 1 2022, 7:44 PM

cjming moved this task from In Progress to In Review on the Metrics Platform Backlog (Metrics Platform Kanban) board.Nov 15 2022, 1:03 AM

cjming moved this task from In Review to In Progress on the Metrics Platform Backlog (Metrics Platform Kanban) board.Nov 29 2022, 1:57 PM

Change 866659 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/libs/metrics-platform@master] Refactor Java event sending

https://gerrit.wikimedia.org/r/866659

cjming moved this task from In Progress to In Review on the Metrics Platform Backlog (Metrics Platform Kanban) board.Dec 9 2022, 11:46 PM

cjming moved this task from In Review to In Progress on the Metrics Platform Backlog (Metrics Platform Kanban) board.Dec 9 2022, 11:50 PM

cjming moved this task from In Progress to In Review on the Metrics Platform Backlog (Metrics Platform Kanban) board.Dec 12 2022, 8:27 PM

Change 866659 merged by Clare Ming:

[mediawiki/libs/metrics-platform@master] Refactor Java event sending

https://gerrit.wikimedia.org/r/866659

cjming moved this task from In Review to Sign Off on the Metrics Platform Backlog (Metrics Platform Kanban) board.Dec 14 2022, 2:06 PM

Being bold.

phuedx closed this task as Resolved.Mar 22 2023, 2:13 PM