Page MenuHomePhabricator
Create Task
Maniphest T318958

Phonos: Error Box Line
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

  • Enter a phonos template in Edit from your Local
  • ex. <phonos wikibase="L7993" text="tomato" lang="zz-au">Tomato</phonos>
  • Save then click Read
  • "zz" does not exist in language so when you hover over the phonos word, you will get an error.

Lexeme Change.png (722×1 px, 182 KB)

You will receive a red box stating the error. We are not sure if this is an actual issue but wanted to bring this up since the red box line is not completed all the way through as seen in the screenshot. Should the error box line be red all the way through?

OS: Chrome
Environment: Local

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix background-color of error popup anchor (2nd attempt)mediawiki/extensions/Phonosmaster+2 -2
Fix background-color of error popup anchormediawiki/extensions/Phonosmaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

GMikesell-WMF created this task.Sep 29 2022, 5:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 29 2022, 5:36 PM
dmaza set the point value for this task to 2.Oct 5 2022, 2:47 PM
Samwilson claimed this task.Oct 10 2022, 2:48 AM
Samwilson moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-34) board.
gerritbot added a comment.Oct 10 2022, 2:57 AM

Change 840681 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/Phonos@master] Fix background-color of error popup anchor

https://gerrit.wikimedia.org/r/840681

gerritbot added a project: Patch-For-Review.Oct 10 2022, 2:57 AM
Samwilson updated the task description. (Show Details)Oct 10 2022, 2:57 AM
Samwilson moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-34) board.Oct 10 2022, 3:14 AM
gerritbot added a comment.Oct 10 2022, 12:48 PM

Change 840681 merged by jenkins-bot:

[mediawiki/extensions/Phonos@master] Fix background-color of error popup anchor

https://gerrit.wikimedia.org/r/840681

Samwilson mentioned this in rEPHN97a933582362: Fix background-color of error popup anchor.Oct 10 2022, 12:48 PM
TheresNoTime moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-34) board.Oct 10 2022, 12:57 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.5; 2022-10-10).Oct 10 2022, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 10 2022, 1:30 PM
• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-35); removed Community-Tech (CommTech-Sprint-34).Oct 11 2022, 10:26 AM
• JMcLeod_WMF moved this task from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Sprint-35) board.Oct 11 2022, 10:29 AM
GMikesell-WMF added a subscriber: TheresNoTime.Oct 11 2022, 10:10 PM

@TheresNoTime Error on red box runs all the way through now, see screenshot. Moving to production sign-off, thanks!

T318958_ErrorBoxLine_PASS.png (499×1 px, 69 KB)

GMikesell-WMF moved this task from QA 🐛 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-35) board.Oct 11 2022, 10:10 PM
• NRodriguez closed this task as Resolved.Oct 20 2022, 3:22 PM
• JMcLeod_WMF moved this task from Product sign-off 🤘 to Done 🏁 on the Community-Tech (CommTech-Sprint-35) board.Nov 7 2022, 10:00 PM
dom_walden reopened this task as Open.Nov 24 2022, 7:44 AM
dom_walden edited projects, added Community-Tech; removed Community-Tech (CommTech-Sprint-35).
dom_walden subscribed.

I am seeing this again after T322702.

dom_walden mentioned this in T322702: Phonos: Fix error popups in Legacy Vector.Nov 24 2022, 7:44 AM
gerritbot added a comment.Nov 30 2022, 7:50 AM

Change 862179 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/Phonos@master] Fix background-color of error popup anchor (2nd attempt)

https://gerrit.wikimedia.org/r/862179

gerritbot added a project: Patch-For-Review.Nov 30 2022, 7:50 AM
Samwilson edited projects, added Community-Tech (CommTech-Sprint-37); removed Community-Tech.Nov 30 2022, 7:51 AM
Samwilson moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-37) board.Nov 30 2022, 7:57 AM

I've made a patch for this.

gerritbot added a comment.Nov 30 2022, 9:39 AM

Change 862179 merged by jenkins-bot:

[mediawiki/extensions/Phonos@master] Fix background-color of error popup anchor (2nd attempt)

https://gerrit.wikimedia.org/r/862179

Samwilson mentioned this in rEPHN338dd865b089: Fix background-color of error popup anchor (2nd attempt).Nov 30 2022, 9:41 AM
Samwilson moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-37) board.Nov 30 2022, 9:58 AM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.13; 2022-12-05); removed MW-1.40-notes (1.40.0-wmf.5; 2022-10-10).Nov 30 2022, 10:01 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 30 2022, 10:30 AM
GMikesell-WMF added a comment.Nov 30 2022, 9:56 PM

@Samwilson Validated that the red error box line goes all the way through again as seen in the screenshot. Moving to Production sign-off Thanks!

Tested the following below with no issues on the red error box line:

Test Material: <phonos ipa="mexiko" text="foo" lang="es" />
Environment: Local
Skins: Vector, Vector Legacy, Minervaneue, Timeless
IOS: Safari
Windows 11: Chrome, Firefox, Edge

Local: Chrome

T318958_Phonos_ErrorBoxLine_Local.png (429×2 px, 134 KB)

GMikesell-WMF moved this task from QA 🐛 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-37) board.Nov 30 2022, 10:00 PM
• JMcLeod_WMF moved this task from Backlog to 🌟Top Priority on the MediaWiki-extensions-Phonos board.Dec 1 2022, 6:33 PM
• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-38); removed Community-Tech (CommTech-Sprint-37).Dec 6 2022, 1:38 PM
• JMcLeod_WMF moved this task from Ready 🎬 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-38) board.Dec 6 2022, 1:40 PM
• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-39); removed Community-Tech (CommTech-Sprint-38).Jan 3 2023, 6:37 PM
• JMcLeod_WMF moved this task from Ready 🎬 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-39) board.Jan 3 2023, 6:39 PM
• NRodriguez closed this task as Resolved.Jan 4 2023, 9:40 PM
• JMcLeod_WMF moved this task from Product sign-off 🤘 to Done 🏁 on the Community-Tech (CommTech-Sprint-39) board.Jan 16 2023, 2:43 PM
dom_walden mentioned this in T330156: Error popup not red throughout when it appears above the button.Feb 21 2023, 1:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits