Make Skin::getFooterIcons and Skin::makeFooterIcon final methods and deprecate
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

In 1.40 as part of T302116 we made these methods final by deprecating overrides. Nobody seems to override these methods so in 1.41 we should make these final methods

TODO

IMPORTANT: Do not touch SkinComponentFooter. This is specifically about the functions in Skin. SkinComponentRegistryContext methods should be revised per unstable notes.

Make methods final so they cannot be overriden e.g. final public function getFooterIcons
Remove the call to MWDebug::detectDeprecatedOverride in Skin::getFooterIcons
Remove the call to MWDebug::detectDeprecatedOverride in Skin::makeFooterIcon
Note in the RELEASE-NOTES-1.44 that overriding is no longer supported.
Make sure commit message is prefixed with "Skin [Breaking change]: Remove ability of skins to override makeFooterIcon and getFooterIcons"

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Skin [Breaking change]: Remove ability of skins to override makeFooterIcon and getFooterIcons	mediawiki/core	master	+11 -39
	Follow up: Remove unnecessary SkinComponentRegistryContext methods	mediawiki/core	master	+0 -0

Customize query in gerrit

Related Objects

Mentioned Here: T302116: Componentize MenuLink and Footers

Event Timeline

Jdlrobson created this task.Sep 30 2022, 12:28 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2022, 12:28 AM

Jdlrobson renamed this task from [1.41] Make Skin::getFooterIcons and Skin::makeFooterIcon final methods to [1.41] Make Skin::getFooterIcons and Skin::makeFooterIcon final methods and deprecate.Sep 30 2022, 12:29 AM

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Menus 2.0 to Deprecations/removals on the MediaWiki-Core-Skin-Architecture board.Mar 28 2023, 4:03 AM

Jdlrobson edited projects, added MediaWiki-Core-Skin-Architecture; removed MediaWiki-Core-Skin-Architecture (Menus 2.0).

Jdlrobson triaged this task as Medium priority.Jun 14 2023, 9:23 PM

Jdlrobson added a project: MW-1.41-release.

Jdlrobson added a project: patch-welcome.

Reedy moved this task from Blocker to To deprecate or remove on the MW-1.41-release board.Aug 26 2023, 6:32 PM

Jdforrester-WMF added a project: Technical-Debt (Deprecation process).Sep 22 2023, 5:21 PM

Note that these have missed the boat for 1.41, so should be moved/re-evaluated for 1.42.

Jdlrobson edited projects, added MW-1.42-release; removed MW-1.41-release.Dec 21 2023, 7:04 PM

Jdforrester-WMF moved this task from Blocker to Deprecate or remove on the MW-1.42-release board.Jan 3 2024, 5:51 PM

Reedy renamed this task from [1.41] Make Skin::getFooterIcons and Skin::makeFooterIcon final methods and deprecate to Make Skin::getFooterIcons and Skin::makeFooterIcon final methods and deprecate.Mar 11 2024, 2:58 PM

Reedy updated the task description. (Show Details)

Krinkle moved this task from Untriaged to 2023+ | MW 1.40+ on the Technical-Debt (Deprecation process) board.Mar 27 2024, 6:43 PM

Jdlrobson edited projects, added MW-1.44-release, Web-Team-Housekeeping; removed MW-1.42-release.Dec 11 2024, 4:26 PM

Jdlrobson moved this task from Backlog to Remove unsupported code paths on the Web-Team-Housekeeping board.Dec 11 2024, 6:04 PM

LMora-WMF claimed this task.Dec 11 2024, 6:29 PM

pending estimate

Jdlrobson updated the task description. (Show Details)Dec 11 2024, 11:03 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Web-Team.Dec 12 2024, 5:16 PM

Jdlrobson moved this task from Incoming to Sprint Backlog on the Web-Team board.

Jdlrobson moved this task from Sprint Backlog to Incoming on the Web-Team board.Dec 12 2024, 5:20 PM

LMora-WMF edited projects, added Web-Team (FY2024-25 Q2 Sprint 6 (Dec 16 - Jan 13, 2025)); removed Web-Team.Dec 16 2024, 5:49 PM

LMora-WMF set the point value for this task to 1.Dec 16 2024, 5:51 PM

LMora-WMF moved this task from Ready for Development to In Progress on the Web-Team (FY2024-25 Q2 Sprint 6 (Dec 16 - Jan 13, 2025)) board.Jan 3 2025, 4:09 PM

Change #1108105 had a related patch set uploaded (by LorenMora; author: LorenMora):

[mediawiki/core@master] Skin [Breaking change]: Remove ability of skins to override makeFooterIcon and getFooterIcons

https://gerrit.wikimedia.org/r/1108105

gerritbot added a project: Patch-For-Review.Jan 3 2025, 4:57 PM

Jdlrobson added a comment.Jan 3 2025, 5:49 PM

This comment was removed by Jdlrobson.

@LMora-WMF looks like Vector is using that unstable method in the tests so we will have to update Vector to skip that test or fix the usage to make it possible to merge the core change (which looks good!)

Jdlrobson updated the task description. (Show Details)Jan 3 2025, 5:55 PM

Thanks, @Jdlrobson! I was wondering what other step I needed to do and was about to ask you. I appreciate it!

Change #1108466 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Follow up: Remove unnecessary SkinComponentRegistryContext methods

https://gerrit.wikimedia.org/r/1108466

Change #1108466 abandoned by Jdlrobson:

[mediawiki/core@master] Follow up: Remove unnecessary SkinComponentRegistryContext methods

Reason:

Sqaushed into parent commit

https://gerrit.wikimedia.org/r/1108466

Change #1108105 merged by jenkins-bot:

[mediawiki/core@master] Skin [Breaking change]: Remove ability of skins to override makeFooterIcon and getFooterIcons

https://gerrit.wikimedia.org/r/1108105

Maintenance_bot removed a project: Patch-For-Review.Jan 6 2025, 10:30 PM

Can skip QA.

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.12; 2025-01-14).Jan 6 2025, 11:00 PM

Jdlrobson added a project: Verified.Jan 14 2025, 7:36 PM

Make Skin::getFooterIcons and Skin::makeFooterIcon final methods and deprecateClosed, ResolvedPublic1 Estimated Story PointsActions