Page MenuHomePhabricator

Hard deprecate Skin::getCopyright
Open, MediumPublic

Description

The Skin::getCopyright method is meant to be internal, yet there is one usage inside Flow.
I don't know enough about how it is used to advise what it should do instead, but ideally it should maintain it's own message key (which can be updated inside WikimediaMessages to be the same as the skin if necessary).

https://codesearch.wmcloud.org/search/?q=-%3EgetCopyright%5C(&i=nope&files=&excludeFiles=&repos=

Perhaps it also makes sense to pull the Copyright logic into its own class, so it is not limited to usage by the Skin?

TODO

  • Update Flow usage
  • Hard deprecate Skin::getCopyright

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson triaged this task as Medium priority.Jun 14 2023, 9:23 PM
Jdlrobson edited projects, added MW-1.41-release; removed MW-1.40-release.

Note that these have missed the boat for 1.41, so should be moved/re-evaluated for 1.42.