Page MenuHomePhabricator

Upgrade to opis/json-schema 2.x
Open, LowPublic

Event Timeline

Change 852316 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] [WIP] Switch opis/json-schema from v1.x to v2.x

https://gerrit.wikimedia.org/r/852316

@Jdforrester-WMF, thanks for identifying the duplicate. Are you planning to follow with the work on the migration?

Growth is interested on seeing this resolved as well since it would allow us to use it in the CommunityConfiguration project. Maybe I can support the effort with testing and code review, although I'm not familiar with WikiLambda code :/

@Jdforrester-WMF, thanks for identifying the duplicate. Are you planning to follow with the work on the migration?

Nothing is scheduled. As you can see above, we tried this before. However, the breaking changes from 1.x to 2.x are really quite challenging, and mean we may have to Decline (we need to maintain compatibility between the opis and ajv results; we've had this working well for opis 1.x but 2.x seems to break on several of our schemata).

@Jdforrester-WMF, thanks for identifying the duplicate. Are you planning to follow with the work on the migration?

Nothing is scheduled. As you can see above, we tried this before. However, the breaking changes from 1.x to 2.x are really quite challenging, and mean we may have to Decline (we need to maintain compatibility between the opis and ajv results; we've had this working well for opis 1.x but 2.x seems to break on several of our schemata).

Got you, thanks for the context. Fwiw we will workaround this in the Community configuration project MVP by using justinrainbow/json-schema which is already a core dependency. In the future we hope to support the 1.x-2.x migration in WikiLambda and adoption of Opis in CommunityConfiguration..