Page MenuHomePhabricator
Create Task
Maniphest T319058

ParserTests defaults to wgAllowExternalImages=true
Closed, ResolvedPublic
Actions

Description

Since the default configuration is wgAllowExternalImages=false, this should be the default for parser tests as well, and the (few) tests which exercise external images should explicitly set wgAllowExternalImages=1 in their !!options section.

(Also: Parsoid doesn't support AllowExternalImages=true, so this helps reduce divergences between parsoid and core tests.)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.24.0-a2mediawiki/vendorwmf/1.47.0-wmf.1+14 K -14 K
Bump wikimedia/parsoid to 0.24.0-a2mediawiki/vendormaster+14 K -14 K
ParserTestRunner: Default $wgAllowExternalImages to falsemediawiki/coremaster+9 -1
tests: Default $wgAllowExternalImages to falsemediawiki/services/parsoidmaster+11 -3
Customize query in gerrit

Related Objects

Event Timeline

cscott created this task.Sep 30 2022, 5:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2022, 5:45 PM
ssastry added a project: Parsoid.Sep 30 2022, 7:28 PM
ssastry moved this task from Needs Triage to Testing on the Parsoid board.Oct 7 2022, 8:51 PM
SomeRandomDeveloper subscribed.Apr 12 2026, 12:19 AM
Krinkle added a project: MediaWiki-Core-Tests.Sat, May 2, 7:35 PM
gerritbot added a comment.Sat, May 2, 7:37 PM

Change #1270158 had a related patch set uploaded (by Krinkle; author: SomeRandomDeveloper):

[mediawiki/core@master] ParserTestRunner: Default $wgAllowExternalImages to false

https://gerrit.wikimedia.org/r/1270158

gerritbot added a project: Patch-For-Review.Sat, May 2, 7:37 PM
gerritbot added a comment.Sat, May 2, 8:35 PM

Change #1281873 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/services/parsoid@master] tests: Default $wgAllowExternalImages to false

https://gerrit.wikimedia.org/r/1281873

gerritbot added a comment.Sat, May 2, 11:46 PM

Change #1270158 merged by jenkins-bot:

[mediawiki/core@master] ParserTestRunner: Default $wgAllowExternalImages to false

https://gerrit.wikimedia.org/r/1270158

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.1; 2026-05-05).Sun, May 3, 12:00 AM
gerritbot added a comment.Sun, May 3, 12:00 AM

Change #1281873 merged by jenkins-bot:

[mediawiki/services/parsoid@master] tests: Default $wgAllowExternalImages to false

https://gerrit.wikimedia.org/r/1281873

Maintenance_bot removed a project: Patch-For-Review.Sun, May 3, 12:31 AM
Krinkle closed this task as Resolved.Sun, May 3, 12:46 AM
Krinkle assigned this task to SomeRandomDeveloper.
gerritbot added a comment.Thu, May 7, 7:44 PM

Change #1284813 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284813

gerritbot added a project: Patch-For-Review.Thu, May 7, 7:44 PM
gerritbot added a comment.Thu, May 7, 8:02 PM

Change #1284813 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284813

gerritbot added a comment.Thu, May 7, 8:16 PM

Change #1284832 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@wmf/1.47.0-wmf.1] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284832

gerritbot added a comment.Thu, May 7, 9:07 PM

Change #1284832 merged by jenkins-bot:

[mediawiki/vendor@wmf/1.47.0-wmf.1] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284832

Stashbot mentioned this in T368724: Rendering diff on broken link with template (visual diff testing).Thu, May 7, 9:15 PM
Stashbot mentioned this in T424773: __NOCONTENTCONVERT__ is not honored in Parsoid.

Mentioned in SAL (#wikimedia-operations) [2026-05-07T21:15:34Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1284828|Upgrading webonyx/graphql-php (v15.31.5 => v15.32.3)]], [[gerrit:1284834|composer.json: Update webonyx/graphql-php to ^15.32.3]], [[gerrit:1284832|Bump wikimedia/parsoid to 0.24.0-a2 (T319058 T368724 T373384 T420336 T423241 T423701 T424446 T424773 T425008 T425056 T425107 T425731)]], [[gerrit:1284837|Bump wikimedia/parsoid to 0.24.0-a2 (T425731)]

Stashbot mentioned this in T424446: Space added for no reason.Thu, May 7, 9:15 PM
Stashbot mentioned this in T420336: mw-parsoid improvements.
Stashbot mentioned this in T425008: WrapSectionState crash: Wikimedia\Assert\InvariantException: Invariant failed: Expected only language variants to be missing about ids..
Stashbot mentioned this in T425107: __TOC__ not showing up in Parsoid on Norwegian Bokmål village pump pages.
Stashbot mentioned this in T425056: 1.46.0-wmf.26 broke itwiki's Template:Divisa calcio.
Stashbot mentioned this in T425731: CTT tasks week of 2026-05-01.
Stashbot mentioned this in T373384: Parsoid doesn't properly handle double-underscore magic words.
Stashbot mentioned this in T423701: Serialize ContentHolder (or at least its fragments) in ParserOutput.
Stashbot mentioned this in T423241: Thumbtime for TimedMedia no longer working.

Mentioned in SAL (#wikimedia-operations) [2026-05-07T21:17:28Z] <cscott@deploy1003> cscott: Backport for [[gerrit:1284828|Upgrading webonyx/graphql-php (v15.31.5 => v15.32.3)]], [[gerrit:1284834|composer.json: Update webonyx/graphql-php to ^15.32.3]], [[gerrit:1284832|Bump wikimedia/parsoid to 0.24.0-a2 (T319058 T368724 T373384 T420336 T423241 T423701 T424446 T424773 T425008 T425056 T425107 T425731)]], [[gerrit:1284837|Bump wikimedia/parsoid to 0.24.0-a2 (T425731)]] synced to the t

Stashbot added a comment.Thu, May 7, 9:27 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-07T21:27:35Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1284828|Upgrading webonyx/graphql-php (v15.31.5 => v15.32.3)]], [[gerrit:1284834|composer.json: Update webonyx/graphql-php to ^15.32.3]], [[gerrit:1284832|Bump wikimedia/parsoid to 0.24.0-a2 (T319058 T368724 T373384 T420336 T423241 T423701 T424446 T424773 T425008 T425056 T425107 T425731)]], [[gerrit:1284837|Bump wikimedia/parsoid to 0.24.0-a2 (T425731)

Maintenance_bot removed a project: Patch-For-Review.Thu, May 7, 9:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits