Page MenuHomePhabricator
Create Task
Maniphest T319069

Remove global-blocks-specific methods and hook from User class
Closed, ResolvedPublic
Actions

Description

Background

See the subtask T317337: Deprecate global-blocks-specific methods and hook for the background for this work.

Acceptance criteria
  • After this task, core is no longer aware of global blocks

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedDreamy_JazzT231109 Remove Core coupling with GlobalBlocking extension
 ResolvedDreamy_JazzT319069 Remove global-blocks-specific methods and hook from User class
 ResolvedCyndymediawiksimT317337 Deprecate global-blocks-specific methods and hook
 ResolvedCyndymediawiksimT317325 Remove separate checks for global blocks from APIUpload and SpecialUpload
 ResolvedCyndymediawiksimT317324 GlobalBlock::appliesToRight should return true for 'upload'
 Resolved• AGueyteT317334 Remove separate checks for global blocks from PasswordReset
 Resolved• TThoabalaT317342 Investigate: Remove use of User::isBlockedGlobally and User::getGlobalBlock from Wikimedia deployed extensions
 ResolvedDreamy_JazzT318877 Remove use of User::isBlockedGlobally in CheckUser
 Resolved• AGueyteT318891 Remove usage of User::isBlockedGlobally and User::getGlobalBlock in Thanks
 ResolvedWMDE-FischT318893 Remove use of User::isBlockedGlobally and User::getGlobalBlock in FileImporter
 Resolved• AGueyteT318896 Remove use of User::isBlockedGlobally and User::getGlobalBlock in UploadWizard
 ResolvedCyndymediawiksimT318897 Remove usage of User::isBlockedGlobally in UrlShortener
 ResolvedCyndymediawiksimT318898 Remove usage of User::isBlockedGlobally and User::getGlobalBlock in VisualEditor
 ResolvedUniversal_OmegaT318900 Remove usage of User::isBlockedGlobally and User::getGlobalBlock in WikiForum
 ResolvedTchandersT257701 Add global blocks into CompositeBlocks rather than treating them separately
 ResolvedTchandersT317308 GlobalBlocking should specify block error message key
 Resolved• AGueyteT317201 Allow extensions to modify block error message key via a hook
 ResolvedSTranT317190 GlobalBlock should extend AbstractBlock instead of DatabaseBlock
 ResolvedmatmarexT363185 Remove use of User::getGlobalBlock() from WikimediaEvents
 ResolvedDreamy_JazzT387574 Hard deprecate User::getGlobalBlock

Event Timeline

Tchanders created this task.Sep 30 2022, 7:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2022, 7:34 PM
Tchanders added a subtask: T317337: Deprecate global-blocks-specific methods and hook.Sep 30 2022, 7:35 PM
Tchanders added a parent task: T231109: Remove Core coupling with GlobalBlocking extension.
Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment-Team board.Dec 5 2022, 10:16 PM
Niharika closed subtask T317337: Deprecate global-blocks-specific methods and hook as Resolved.Dec 8 2022, 1:09 AM
Tchanders mentioned this in T231109: Remove Core coupling with GlobalBlocking extension.Mar 21 2023, 5:53 PM
• TAdeleye_WMF edited projects, added Trust and Safety Product Team (PM); removed Anti-Harassment-Team.May 14 2024, 4:29 PM
• TAdeleye_WMF moved this task from PM to Needs Triage on the Trust and Safety Product Team board.May 14 2024, 4:30 PM
• TAdeleye_WMF edited projects, added Trust and Safety Product Team; removed Trust and Safety Product Team (PM).
Dreamy_Jazz mentioned this in T387574: Hard deprecate User::getGlobalBlock.Feb 28 2025, 3:39 PM
Dreamy_Jazz moved this task from Needs Triage to Engineering on the Trust and Safety Product Team board.Feb 28 2025, 5:58 PM
Dreamy_Jazz edited projects, added Trust and Safety Product Team (Engineering); removed Trust and Safety Product Team.
Restricted Application edited projects, added Trust and Safety Product Team; removed Trust and Safety Product Team (Engineering). · View Herald TranscriptFeb 28 2025, 5:58 PM
Dreamy_Jazz moved this task from Inbox to Engineering on the Trust and Safety Product Team board.Feb 28 2025, 5:59 PM
Dreamy_Jazz edited projects, added Trust and Safety Product Team (Engineering); removed Trust and Safety Product Team.
Dreamy_Jazz closed subtask T387574: Hard deprecate User::getGlobalBlock as Resolved.Feb 28 2025, 6:16 PM
kostajh moved this task from Engineering to Engineering on the Trust and Safety Product Team board.Mar 10 2025, 12:44 PM
kostajh edited projects, added Trust and Safety Product Team; removed Trust and Safety Product Team (Engineering).
Dreamy_Jazz added a project: Essential-Work.Oct 3 2025, 3:33 PM
Dreamy_Jazz closed this task as Resolved.Oct 3 2025, 3:36 PM
Dreamy_Jazz claimed this task.
Dreamy_Jazz subscribed.

T401587: Drop User::getGlobalBlock and User::isBlockedGlobally dropped the two methods in User. The hook is to be removed in T401594: Remove the UserIsBlockedGlobally hook, but has been hard deprecated and is no longer run.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits