Page MenuHomePhabricator
Create Task
Maniphest T319078

PHP Notice: Undefined property: Wikimedia\Parsoid\NodeData\DataParsoid::$tsr
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Notice: Undefined property: Wikimedia\Parsoid\NodeData\DataParsoid::$tsr
exception.trace
from /srv/mediawiki/php-1.40.0-wmf.3/vendor/wikimedia/parsoid/src/Wt2Html/PP/Processors/AnnotationDOMRangeBuilder.php(213)
#0 /srv/mediawiki/php-1.40.0-wmf.3/vendor/wikimedia/parsoid/src/Wt2Html/PP/Processors/AnnotationDOMRangeBuilder.php(213): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.40.0-wmf.3/vendor/wikimedia/parsoid/src/Wt2Html/PP/Processors/AnnotationDOMRangeBuilder.php(282): Wikimedia\Parsoid\Wt2Html\PP\Processors\AnnotationDOMRangeBuilder->setMetaDataMwForRange(Wikimedia\Parsoid\Wt2Html\PP\Processors\DOMRangeInfo, boolean)
#2 /srv/mediawiki/php-1.40.0-wmf.3/vendor/wikimedia/parsoid/src/Wt2Html/PP/Processors/WrapAnnotations.php(22): Wikimedia\Parsoid\Wt2Html\PP\Processors\AnnotationDOMRangeBuilder->execute(Wikimedia\Parsoid\DOM\Element)
#3 /srv/mediawiki/php-1.40.0-wmf.3/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(157): Wikimedia\Parsoid\Wt2Html\PP\Processors\WrapAnnotations->run(Wikimedia\Parsoid\Config\Env, Wikimedia\Parsoid\DOM\Element, array, boolean)
#4 /srv/mediawiki/php-1.40.0-wmf.3/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(849): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->Wikimedia\Parsoid\Wt2Html\{closure}(Wikimedia\Parsoid\DOM\Element, array, boolean)
#5 /srv/mediawiki/php-1.40.0-wmf.3/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(890): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->doPostProcess(Wikimedia\Parsoid\DOM\Element)
#6 /srv/mediawiki/php-1.40.0-wmf.3/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(908): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->process(Wikimedia\Parsoid\DOM\Element)
#7 /srv/mediawiki/php-1.40.0-wmf.3/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipeline.php(180): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->processChunkily(string, array)
#8 /srv/mediawiki/php-1.40.0-wmf.3/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipelineFactory.php(308): Wikimedia\Parsoid\Wt2Html\ParserPipeline->parseChunkily(string, array)
#9 /srv/mediawiki/php-1.40.0-wmf.3/vendor/wikimedia/parsoid/src/Wikitext/ContentModelHandler.php(123): Wikimedia\Parsoid\Wt2Html\ParserPipelineFactory->parse(string)
#10 /srv/mediawiki/php-1.40.0-wmf.3/vendor/wikimedia/parsoid/src/Parsoid.php(172): Wikimedia\Parsoid\Wikitext\ContentModelHandler->toDOM(Wikimedia\Parsoid\Ext\ParsoidExtensionAPI)
#11 /srv/mediawiki/php-1.40.0-wmf.3/vendor/wikimedia/parsoid/src/Parsoid.php(210): Wikimedia\Parsoid\Parsoid->parseWikitext(MediaWiki\Parser\Parsoid\Config\PageConfig, ParserOutput, array)
#12 /srv/mediawiki/php-1.40.0-wmf.3/includes/Rest/Handler/ParsoidHandler.php(768): Wikimedia\Parsoid\Parsoid->wikitext2html(MediaWiki\Parser\Parsoid\Config\PageConfig, array, NULL, ParserOutput)
#13 /srv/mediawiki/php-1.40.0-wmf.3/vendor/wikimedia/parsoid/extension/src/Rest/Handler/PageHandler.php(92): MediaWiki\Rest\Handler\ParsoidHandler->wt2html(MediaWiki\Parser\Parsoid\Config\PageConfig, array)
#14 /srv/mediawiki/php-1.40.0-wmf.3/includes/Rest/Router.php(487): MWParsoid\Rest\Handler\PageHandler->execute()
#15 /srv/mediawiki/php-1.40.0-wmf.3/includes/Rest/Router.php(406): MediaWiki\Rest\Router->executeHandler(MWParsoid\Rest\Handler\PageHandler)
#16 /srv/mediawiki/php-1.40.0-wmf.3/includes/Rest/EntryPoint.php(170): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#17 /srv/mediawiki/php-1.40.0-wmf.3/includes/Rest/EntryPoint.php(135): MediaWiki\Rest\EntryPoint->execute()
#18 /srv/mediawiki/php-1.40.0-wmf.3/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#19 /srv/mediawiki/w/rest.php(3): require(string)
#20 {main}
Impact
Notes

Details

Request URL
https://species.wikimedia.org/w/rest.php/species.wikimedia.org/v3/page/pagebundle/Wikispecies%3AAdministrators/8861468
SubjectRepoBranchLines +/-
Add a template+tvar testmediawiki/extensions/Translatemaster+13 -1
Do not generate annotation tokens on </> in templatesmediawiki/services/parsoidmaster+12 -2
Bump parsoid to 0.17.0-a3mediawiki/vendormaster+800 -593
Customize query in gerrit

Event Timeline

ssastry triaged this task as Medium priority.Sep 30 2022, 8:14 PM
ssastry created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2022, 8:14 PM
ssastry added a comment.Sep 30 2022, 8:16 PM

There are several errors with other undefined property accesses on this page.

Relatedly on mw:Help%3ATemplateData/5466946, there are other errors with annotation wrapping. I suspect these are all related, so I am not filing a separate phab task for that.

ssastry moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Sep 30 2022, 8:28 PM
ihurbain added a comment.Oct 3 2022, 1:26 PM

Smaller reproducer:

<translate>
You can use <tvar|code1><code>{{tlsp|RFA|</> Username <tvar|code2>|</> Why you want to be a sysop. <tvar|code3><nowiki>~~~~</nowiki>}}</code></> when making a request to automatically create the form.
</translate>

This is actually solved by moving the <tvar> markup away from the unsupported syntax (I need to double check why exactly it's an issue with the old syntax, this may inform the warning squashing.)

I still probably want to squash these warnings, though.

ihurbain added a comment.Oct 4 2022, 11:39 AM

Much smaller reproducer:

<translate><tvar|var>{{1x|</>plop}}</translate>

The issue seems to be that data-parsoid is stripped from the end meta - it's generated during parsing, so that's not the issue, but it disappears before annotation processing. To be continued.

gerritbot added a comment.Oct 4 2022, 1:48 PM

Change 838160 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/services/parsoid@master] Do not generate annotation tokens on </> in templates

https://gerrit.wikimedia.org/r/838160

gerritbot added a project: Patch-For-Review.Oct 4 2022, 1:48 PM
gerritbot added a comment.Oct 4 2022, 5:05 PM

Change 838160 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Do not generate annotation tokens on </> in templates

https://gerrit.wikimedia.org/r/838160

Maintenance_bot removed a project: Patch-For-Review.Oct 4 2022, 5:31 PM
gerritbot added a comment.Oct 10 2022, 2:44 PM

Change 841143 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a3

https://gerrit.wikimedia.org/r/841143

gerritbot added a project: Patch-For-Review.Oct 10 2022, 2:44 PM
gerritbot added a comment.Oct 10 2022, 3:09 PM

Change 841143 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a3

https://gerrit.wikimedia.org/r/841143

Maintenance_bot removed a project: Patch-For-Review.Oct 10 2022, 3:31 PM
gerritbot added a comment.Oct 11 2022, 4:21 PM

Change 841555 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Translate@master] Add a template+tvar test

https://gerrit.wikimedia.org/r/841555

gerritbot added a project: Patch-For-Review.Oct 11 2022, 4:21 PM
ihurbain closed this task as Resolved.Oct 18 2022, 1:02 PM
ihurbain claimed this task.

Checked that the deployed patch solves this issue.

gerritbot added a comment.Nov 3 2022, 3:59 PM

Change 841555 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Add a template+tvar test

https://gerrit.wikimedia.org/r/841555

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 3 2022, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 3 2022, 4:31 PM
Krinkle moved this task from Untriaged to Oct 2022 on the Wikimedia-production-error board.Nov 17 2022, 4:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL