| • alexhollender_WMF | |
| Oct 1 2022, 12:47 AM |
| F37085082: Screenshot 2023-05-30 at 5.05.28 PM.png | |
| May 31 2023, 12:09 AM |
| F37085081: Screenshot 2023-05-30 at 5.06.00 PM.png | |
| May 31 2023, 12:09 AM |
| F35541931: Screen Shot 2022-09-30 at 8.46.03 PM.png | |
| Oct 1 2022, 12:47 AM |
| F35541930: Screen Shot 2022-09-30 at 8.46.12 PM.png | |
| Oct 1 2022, 12:47 AM |
Currently the tabs in the page toolbar have a 1px underline. I've heard two or three comments about people not being able to see the underline (which was made worse by this regression T318952).
Increase tab borders from 1px to 2px
| current | updated |
|---|---|
 |  |
Note: make sure to check the hover states as well
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T319089#8890764 |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Increase menu tab borders to 2px | mediawiki/skins/Vector | master | +2 -2 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | ovasileva | T317884 [EPIC] Vector 2022 post-deployment work | |||
| Resolved | Jdrewniak | T319089 [Visual refinements] Increase tab borders to 2px |
@SuvamManna: Welcome and thanks for your interest! Please read https://www.mediawiki.org/wiki/New_Developers#communication and see https://phabricator.wikimedia.org/project/profile/4281/ - thanks.
Change 923400 had a related patch set uploaded (by Jayden Bailey; author: Jayden Bailey):
[mediawiki/skins/Vector@master] Increase menu tab borders to 2px
Change 923400 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Increase menu tab borders to 2px
Thanks for the patch Jayden!
Hey @Winston_Sung there are a few things to be aware of when merging changes in Vector
I'll make sure we update this in our development guidelines to include the above information.
@bwang I've manually reviewed the 96 regressions that Pixel is flagging and this change looks good to me. Could you ssh into pixel.reading-web-staging.eqiad1.wikimedia.cloud and update /srv/pixel.sh to apply this new patch so that the line with reference= in it is changed to
reference="-b latest-release -c 923400" to clear out the Pixel complaints in preparation for Monday?
- Visual changes lead to email alerts due to our visual regression tool not knowing about them: https://pixel.wmcloud.org/reports/desktop/index.html
- We put VISUAL CHANGE in the commit message for these kind of edits to help each other identify patches that could trigger these alerts.
- Patches of this kind must be run carefully against Pixel manually https://github.com/wikimedia/pixel beforehand as they might miss something important. This should be considered part of our code review process and summarized in a comment in the patch itself.
Oops. My apologies.
- We are currently low on designer support so trying to minimize workload for designers.
Oh...
I'll make sure we update this in our development guidelines to include the above information.
That would be great.
Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
✅ AC1: Increase tab borders from 1px to 2px, verify hover state as well.
