Page MenuHomePhabricator

Page notices on Discussion Tools new section panel not expanding collapsibles
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
[show] links remain the same and are not clickable.

What should have happened instead?:
Collapse links should have been enabled. mediawiki.page.ready handles collapsible expansion when wikipage.content is fired, but DiscussionTools doesn't seem to fire wikipage.content at all for notices (or at least for edit notices that originate from wikitext), only previews.

Software version (skip for WMF-hosted wikis like Wikipedia): English Wikipedia.

Other information (browser name/version, screenshots, etc.):
Initially reported by User:Seloloving on Discord. Reproduced successfully by User:K6ka, User:Aoidh, and myself using varying browsers.

Event Timeline

matmarex subscribed.

Oops, thanks for the report. We definitely should fire that hook (like we do in VE since T179315).

Change 837214 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Fire wikipage.content hook on edit notices

https://gerrit.wikimedia.org/r/837214

Change 837214 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fire wikipage.content hook on edit notices

https://gerrit.wikimedia.org/r/837214