Page MenuHomePhabricator

Suppress Topic Container section divider when section follows <h1>
Closed, ResolvedPublic

Description

This task involves suppressing the Topic Container section divider when it follows an <h1> that does not contain any content.

NOTE: T318198 covers the case when a preceding <h1> does contain content

Behavior

  1. On desktop, visit a talk page where Topic Containers are enabled and said talk page contains a minimum of one = H1 = section heading that:
    • A) does not contain any content within it and
    • B) is followed by an == H2 ==. E.g. https://w.wiki/5mky .

Actual

  1. ❗️Notice two horizontal lines appear beneath the = H1 =:

image.png (321×975 px, 65 KB)

Expected

  1. ✅ One horizontal line appears beneath the = H1 =

image.png (284×874 px, 66 KB)

Done

  • Expected behavior is implemented

Event Timeline

ppelberg updated the task description. (Show Details)

Change 833852 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Suppress top border when section follows <h1>

https://gerrit.wikimedia.org/r/833852

Meta

Change 833852 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Suppress top border when section follows <h1>

https://gerrit.wikimedia.org/r/833852

Considering:

  1. This task is about the case where a Topic Container follows an <H1> that contains content
  2. 833852 addresses the case where a Topic Container follows an <H1> that does NOT contain content

...I've filed T319147 and we'll leave this ticket open.

EAkinloose added a subscriber: EAkinloose.

✅ Suppress Topic Container section divider when section follows <h1>

Before fix:

Screenshot 2022-10-04 at 14.37.48.png (848×3 px, 221 KB)

After fix:

Screenshot 2022-10-04 at 14.38.21.png (518×3 px, 161 KB)