Maniphest T319147

Suppress Topic Container section divider when section follows <h1>
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ppelberg
	Oct 2 2022, 1:49 PM

Description

This task involves suppressing the Topic Container section divider when it follows an <h1> that does not contain any content.

NOTE: T318198 covers the case when a preceding <h1> does contain content

Behavior

On desktop, visit a talk page where Topic Containers are enabled and said talk page contains a minimum of one = H1 = section heading that:
- A) does not contain any content within it and
- B) is followed by an == H2 ==. E.g. https://w.wiki/5mky .

Actual

❗️Notice two horizontal lines appear beneath the = H1 =:

Expected

✅ One horizontal line appears beneath the = H1 =

Done

Expected behavior is implemented

Related Objects
Search...

Status	Assigned	Task
Open	None	T276497 Scale DiscussionTools to all projects
Open	None	T310959 Scale Usability Improvements to all projects
Open	None	T319146 [Release Ticket] Offer Usability Improvements as default-on feature at all projects (desktop)
Resolved	Esanders	T319147 Suppress Topic Container section divider when section follows <h1>

Event Timeline

ppelberg created this task.Oct 2 2022, 1:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2022, 1:49 PM

ppelberg added a parent task: T319146: [Release Ticket] Offer Usability Improvements as default-on feature at all projects (desktop).Oct 2 2022, 1:51 PM

In T318198#8251752, @gerritbot wrote:

Change 833852 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Suppress top border when section follows <h1>

https://gerrit.wikimedia.org/r/833852

In T318198#8278289, @ppelberg wrote:

Meta

In T318198#8251752, @gerritbot wrote:

Change 833852 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Suppress top border when section follows <h1>

https://gerrit.wikimedia.org/r/833852

Considering:

This task is about the case where a Topic Container follows an <H1> that contains content

833852 addresses the case where a Topic Container follows an <H1> that does NOT contain content

...I've filed T319147 and we'll leave this ticket open.

ppelberg moved this task from Incoming to QA on the Editing-team (Kanban Board) board.Oct 2 2022, 2:03 PM

ppelberg added a project: Editing QA.

Esanders updated the task description. (Show Details)Oct 3 2022, 2:56 PM

✅ Suppress Topic Container section divider when section follows <h1>

Before fix:

After fix:

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Oct 4 2022, 1:39 PM

ppelberg closed this task as Resolved.Oct 11 2022, 4:00 PM

	F35546407: Screenshot 2022-10-04 at 14.38.21.png
	Oct 4 2022, 1:39 PM

	F35546403: Screenshot 2022-10-04 at 14.37.48.png
	Oct 4 2022, 1:39 PM

	F35526472: Screen Shot 2022-09-20 at 6.36.21 PM.png
	Oct 2 2022, 1:55 PM

Suppress Topic Container section divider when section follows <h1>Closed, ResolvedPublicActions