Page MenuHomePhabricator

Adjust placeholder for list items missing an image
Closed, ResolvedPublic

Description

Currently when a suggested article to translate is missing a picture, an "image" icon is shown in black. This requires adjustments to align with the spec and the desktop experience:

  • The icon to use is "article" instead. Color for icon should use the "placeholder" colour token (#72777D). Size should be 40x40px.
  • The background should use the "inactive subtle" token (#F8F9FA)
CurrentProposed
bn.m.wikipedia.org_wiki_%E0%A6%AC%E0%A6%BF%E0%A6%B6%E0%A7%87%E0%A6%B7_%E0%A6%AC%E0%A6%BF%E0%A6%B7%E0%A6%AF%E0%A6%BC%E0%A6%AC%E0%A6%B8%E0%A7%8D%E0%A6%A4%E0%A7%81_%E0%A6%85%E0%A6%A8%E0%A7%81%E0%A6%AC%E0%A6%BE%E0%A6%A6(iPhone XR).png (896×414 px, 158 KB)
Mobile.png (568×320 px, 44 KB)

Event Timeline

Please also compare https://doc.wikimedia.org/codex/main/components/demos/thumbnail.html and size and spacing tokens underway.
With that I'd advise to use 40x40px (equivalent em, as icons should be user font size scalable). That would also result in better icon scaling.

Please also compare https://doc.wikimedia.org/codex/main/components/demos/thumbnail.html and size and spacing tokens underway.
With that I'd advise to use 40x40px (equivalent em, as icons should be user font size scalable). That would also result in better icon scaling.

Makes sense to use 40x40px for the article icon in the placeholder. I updated the description. Thanks!

Regarding the overall space for the thumbnail in the current list it is 84x84px, but it may be better aligned with the sizing scale to use 80x80px instead. There were no specific tokens for those sizes, but 80 is a multiple of 16. Please, let me know if I'm reading this correctly.

@Pginer-WMF this ticket has somehow gotten stuck in the "Needs QA" column of a previous quarter board. Should we move this to the current quarter board?

Pginer-WMF claimed this task.

@Pginer-WMF this ticket has somehow gotten stuck in the "Needs QA" column of a previous quarter board. Should we move this to the current quarter board?

Thanks for flagging this.
I think it can be marked as resolved too. If further adjustments are needed we can create separate ticets.