Page MenuHomePhabricator

Prepare and check storage layer for bnwikiquote
Closed, ResolvedPublic1 Estimated Story Points

Description

The new wiki's visibility will be: Public.

Event Timeline

Marostegui triaged this task as Medium priority.Oct 3 2022, 12:28 PM
Marostegui moved this task from Triage to Blocked on the DBA board.
Marostegui added a subscriber: Marostegui.

Let us know when this wiki is created so we can sanitize it

Zabe changed the edit policy from "Custom Policy" to "All Users".Oct 3 2022, 4:06 PM
Urbanecm added a subscriber: Urbanecm.

Let us know when this wiki is created so we can sanitize it

The database was created.

Ladsgroup added a subscriber: Ladsgroup.

DBA side is done

EChetty set the point value for this task to 1.

approximately when it will appear in xtools, any idea?

@Marostegui and @Ladsgroup - Would you mind helping with this please, or pointing me to some more information?
I'm not sure whether I have missed a step somewhere, or whether a database or specific grant hasn't been created.

Our team has been asked to set up the views for this database, which was previously carried out by the WMCS team, but is now the responsibility of the Data Engineering team.
I'm following the procedure outlined here: https://wikitech.wikimedia.org/wiki/Portal:Data_Services/Admin/Wiki_Replicas#Step_6:_setting_views

When I run the following command...

btullis@cumin1001:~$ sudo cookbook sre.wikireplicas.add-wiki --task-id T319190 bnwikiquote

The maintain-views script exits with an error:

1044, "Access denied for user 'maintainviews'@'localhost' to database 'bnwikiquote\\_p'"

I'm also checking this page: https://wikitech.wikimedia.org/wiki/Add_a_wiki#Cloud_Services
I've checked the same command with another pending wiki replica database: T317111: Prepare and check storage layer for tlwikiquote and the result is broadly the same, so it seems that we're missing a step somewhere.

I've got another two sets of views (T316456 and T314639) to add after the two that I've mentioned, so I'd really like to make sure that I understand where any gaps are in the process.

@Ladsgroup comments above that:

DBA side is done

...but what does that actually mean in this case? What steps were carried out? Do you use a cookbook, or is there a puppet change? Is it a manual command that is run for each new database?
I'm happy to try to update the documentation, but I don't want to confuse things if this is work that should be done by your team.

Thank and sincere apologies if I'm missing something obvious.

Mentioned in SAL (#wikimedia-operations) [2022-11-22T14:06:24Z] <marostegui@cumin1001> Added views for new wiki: bnwikiquote T319190

There's indeed a step being missed there which is usually ran by DBAs:

set session sql_log_bin=0;create database bnwikiquote_p;GRANT SELECT, SHOW VIEW ON `bnwikiquote_p`.* TO `labsdbuser`;

That needs to be executed on all clouddb* hosts.
I just ran:

sudo cookbook sre.wikireplicas.add-wiki --task-id T319190 bnwikiquote

And it looks like it worked fine.

Added views for new wiki: bnwikiquote T319190
END (PASS) - Cookbook sre.wikireplicas.add-wiki (exit_code=0)

Is there anything else that needs to be run from your side @BTullis or that command was all?

Thanks @Marostegui - No, as far as I am aware, running that cookbook is the only thing that I need to do for these simple wiki additions.
There is one other step for the Data Engineering team as part of each new wiki's post-creation work, which is to add it to the pageviews allowlist, but that was done for this wiki in T319191

Would you mind checking to see if that step was also missed for T317111, T316456, and T314639 please?

Thanks @Marostegui - No, as far as I am aware, running that cookbook is the only thing that I need to do for these simple wiki additions.
There is one other step for the Data Engineering team as part of each new wiki's post-creation work, which is to add it to the pageviews allowlist, but that was done for this wiki in T319191

Cool so I guess I can close this (reopen if needed)

Would you mind checking to see if that step was also missed for T317111, T316456, and T314639 please?

Fixed those too.