Page MenuHomePhabricator
Create Task
Maniphest T319348

Use grid to specify sidebar width
Closed, ResolvedPublic
Actions

Description

Background

Currently the elements that sit inside the sidebar (main menu and ToC) are have styles that apply widths, which also depend on the viewport (located in Sidebar.less). Rather than apply these styles independently, we should apply the width to the grid area that contains the sidebar. This simplifies the CSS and allows the TOC to take up the full space regardless if it has a negative margin

Screen Shot 2022-10-04 at 1.58.56 PM.png (1×1 px, 397 KB)

AC

  • main menu and TOC no longer have width styles
  • The 'sidebar' grid template area has the correct width styles

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix alignment/spacing of grid column itemsmediawiki/skins/Vectormaster+28 -22
Split MenuPortal.less into legacy and modern Vectormediawiki/skins/Vectormaster+86 -49
Customize query in gerrit

Event Timeline

bwang created this task.Oct 4 2022, 8:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 4 2022, 8:29 PM
Jdlrobson moved this task from Backlog to Vector code cleanup on the Web-Team-Backlog-Archived (Needs Prioritization (Tech)) board.Oct 4 2022, 8:54 PM
gerritbot added a comment.Oct 7 2022, 4:49 PM

Change 840194 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Split MenuPortal.less into legacy and modern Vector

https://gerrit.wikimedia.org/r/840194

gerritbot added a project: Patch-For-Review.Oct 7 2022, 4:49 PM
Aklapper added a project: Vector (legacy skin).Oct 10 2022, 10:54 AM
gerritbot added a comment.Oct 13 2022, 5:53 PM

Change 840194 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Split MenuPortal.less into legacy and modern Vector

https://gerrit.wikimedia.org/r/840194

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.6; 2022-10-17).Oct 13 2022, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 13 2022, 6:30 PM
gerritbot added a comment.Jan 9 2023, 6:25 PM

Change 877239 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Fix alignment/spacing of grid column items

https://gerrit.wikimedia.org/r/877239

gerritbot added a project: Patch-For-Review.Jan 9 2023, 6:25 PM
gerritbot added a comment.Jan 10 2023, 10:26 PM

Change 877239 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix alignment/spacing of grid column items

https://gerrit.wikimedia.org/r/877239

Maintenance_bot removed a project: Patch-For-Review.Jan 10 2023, 10:30 PM
Jdlrobson edited projects, added Vector 2022; removed Vector (legacy skin).Mar 3 2023, 6:30 PM
Jdlrobson subscribed.

@bwang will this be fixed by the page tools roll out?

Jdlrobson added a comment.Mar 15 2023, 10:33 PM

Ping @bwang ^

Jdlrobson moved this task from Vector code cleanup to Post-page tools cleanup on the Web-Team-Backlog-Archived (Needs Prioritization (Tech)) board.Mar 21 2023, 6:03 PM
Jdlrobson moved this task from Incoming to Technical architecture on the Vector 2022 board.Jun 12 2023, 6:01 PM
Jdlrobson triaged this task as Medium priority.Jun 12 2023, 6:04 PM
Jdlrobson moved this task from Post-page tools cleanup to Vector code cleanup on the Web-Team-Backlog-Archived (Needs Prioritization (Tech)) board.Sep 19 2023, 4:12 PM
Jdlrobson edited projects, added Web-Team-Backlog-Archived; removed Vector 2022, MW-1.40-notes (1.40.0-wmf.6; 2022-10-17), Web-Team-Backlog-Archived (Needs Prioritization (Tech)).Sep 20 2023, 5:20 PM
bwang added a comment.EditedSep 25 2023, 5:51 PM

@Jdlrobson This is fixed in Zebra! Should I just close this then with the assumption we are going to roll out zebra?

Edit: nevermind i just resolved it

bwang closed this task as Resolved.Sep 25 2023, 5:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits