Page MenuHomePhabricator

Replace or remove deprecated mediawiki.ui Less variables
Closed, ResolvedPublic

Description

Background

A while ago (in MW v1.35.0) a number of mediwiki.ui variables were deprecated to follow Wikimedia's stylesheet variable naming convention

5 minor versions later a lot of the extensions are still using the outdated variables, making things harder.

border-radius is just one example.

Acceptance criteria for done

  • Replace deprecated vars with current ones.

List of currently deprecated vars since 1.35

// Deprecated in MW v1.35.0
@colorProgressive: @color-primary;
@colorProgressiveHighlight: @color-primary--hover;
@colorProgressiveActive: @color-primary--active;
@colorDestructive: @color-destructive;
@colorDestructiveHighlight: @color-destructive--hover;
@colorDestructiveActive: @color-destructive--active;
// Orange; for contextual use of returning to a past action
@colorRegressive: #ff5d00;
@colorText: @color-base;
@colorTextEmphasized: @color-base--emphasized;
@colorTextLight: @color-base--subtle;
@colorBaseInverted: @color-base--inverted;
@colorNeutral: @color-base--subtle;
@colorButtonText: @color-base;
@colorButtonTextHighlight: @color-base--hover;
@colorButtonTextActive: @color-base--active;
@colorDisabledText: @color-base--disabled;
@colorFieldBorder: @border-color-base;
@colorPlaceholder: @color-placeholder;
@colorShadow: @colorGray14;
// Used in mixins to darken contextual colors by the same amount (eg. focus)
@colorDarkenPercentage: 13.5%;
// Used in mixins to lighten contextual colors by the same amount (eg. hover)
@colorLightenPercentage: 13.5%;
@iconSize: @size-icon;
@iconGutterWidth: @width-icon-gutter;
@backgroundColorError: @background-color-error;
@colorError: @color-error;
@borderColorError: @color-error;
@backgroundColorWarning: @background-color-warning;
@colorWarning: @color-base--emphasized;
@borderColorWarning: @border-color-warning;
@backgroundColorSuccess: @background-color-success;
@colorSuccess: @color-success;
@borderColorSuccess: @color-success;
// Orange; for contextual use of a potentially negative action of medium severity
@colorMediumSevere: #ff5d00;
// Yellow; for contextual use of a potentially negative action of low severity
@colorLowSevere: #fc3;
@backgroundColorInputBinaryChecked: @background-color-input-binary--checked;
@backgroundColorInputBinaryActive: @background-color-input-binary--active;
@sizeInputBinary: @size-input-binary;
@borderColorInputBinaryChecked: @border-color-input-binary--checked;
@borderColorInputBinaryActive: @border-color-input-binary--active;
@borderWidthRadioChecked: @border-width-radio--checked;
@borderRadius: @border-radius-base;
@boxShadowWidget: @box-shadow-base;
@boxShadowWidgetFocus: @box-shadow-base--focus;
@boxShadowProgressiveFocus: @box-shadow-primary--focus;
@boxShadowInputBinaryActive: @box-shadow-input-binary--active;

Details

SubjectRepoBranchLines +/-
mediawiki/extensions/GrowthExperimentsmaster+537 -1 K
mediawiki/coremaster+3 -61
mediawiki/skins/MinervaNeuemaster+155 -197
mediawiki/coremaster+0 -60
mediawiki/extensions/ContentTranslationmaster+256 -241
mediawiki/extensions/Translatemaster+344 -20
mediawiki/extensions/WikibaseLexememaster+33 -35
mediawiki/extensions/WikibaseQualityConstraintsmaster+27 -22
mediawiki/skins/Vectormaster+36 -41
mediawiki/coremaster+238 -235
mediawiki/coremaster+96 -98
mediawiki/extensions/AdvancedSearchmaster+25 -21
mediawiki/extensions/Wikisourcemaster+14 -12
mediawiki/extensions/CampaignEventsmaster+29 -24
mediawiki/extensions/ExternalGuidancemaster+16 -16
mediawiki/extensions/Flowmaster+174 -141
mediawiki/extensions/MultimediaViewermaster+50 -55
mediawiki/extensions/TemplateWizardmaster+11 -11
mediawiki/extensions/RelatedArticlesmaster+9 -9
mediawiki/extensions/CheckUsermaster+28 -25
mediawiki/extensions/MobileFrontendmaster+121 -121
mediawiki/extensions/UploadWizardmaster+8 -10
mediawiki/extensions/CirrusSearchmaster+14 -14
mediawiki/extensions/WikiEditormaster+49 -36
mediawiki/extensions/Wikistoriesmaster+121 -114
mediawiki/extensions/MsUploadmaster+25 -26
mediawiki/extensions/EntitySchemamaster+12 -12
mediawiki/extensions/MsUploadmaster+22 -27
mediawiki/extensions/FileImportermaster+2 -2
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 838774 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/FileImporter@master] Remove deprecated less var

https://gerrit.wikimedia.org/r/838774

Change 838774 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Remove deprecated less var

https://gerrit.wikimedia.org/r/838774

@Volker_E - can you please put an initial/proposed priority level on this task and move it to the Backlog column?
DST prioritization guidance

Volker_E triaged this task as Lowest priority.Jan 23 2023, 6:00 AM
Volker_E moved this task from Inbox to Backlog on the Design-System-Team board.

Change 856034 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] mediawiki.ui: Remove deprecated variables

https://gerrit.wikimedia.org/r/856034

@Volker_E How to find the variables name with whom i should replace the deprecated variables?

@HarsitAgarwalla1 Thanks for your interest. It's already in the task description. I'd suggest to start with these:

@colorText: @color-base;
@colorTextEmphasized: @color-base--emphasized;
@colorTextLight: @color-base--subtle;
@colorBaseInverted: @color-base--inverted;
@colorNeutral: @color-base--subtle;
@colorButtonText: @color-base;

So @colorText becomes @color-base. It will be simpler to review patches with only groups of variables.

@Volker_E I am unable to clone the repository.
It's showing Permission denied(Public Key)

@HarsitAgarwalla1 Have you already had a look at New Developers and how to become a MediaWiki hacker documentation?
For general code development and setup questions, please refer to Communication.

Change 896387 had a related patch set uploaded (by Sushrith Bogi; author: Sushrith Bogi):

[mediawiki/core@master] mediawiki.ui: Remove deprecated variables

https://gerrit.wikimedia.org/r/896387

Change 897224 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/MsUpload@master] styles: Replace deprecated mediawiki.ui variables & use standard colors

https://gerrit.wikimedia.org/r/897224

Change 897224 merged by jenkins-bot:

[mediawiki/extensions/MsUpload@master] styles: Replace deprecated mediawiki.ui variables & use standard colors

https://gerrit.wikimedia.org/r/897224

Change 900807 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/UploadWizard@master] Replace deprecated mediawiki.ui vars

https://gerrit.wikimedia.org/r/900807

Change 900810 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/WikibaseQualityConstraints@master] styles: Replace outdated variables

https://gerrit.wikimedia.org/r/900810

Change 900811 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/MobileFrontend@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/900811

Change 901124 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/MsUpload@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/901124

Change 901131 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/WikiEditor@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/901131

Change 901132 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/CirrusSearch@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/901132

Change 901217 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/GrowthExperiments@master] [WIP] styles: Replace old variables calls with skin variables

https://gerrit.wikimedia.org/r/901217

Change 901237 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/EntitySchema@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/901237

Change 901124 merged by jenkins-bot:

[mediawiki/extensions/MsUpload@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/901124

Change 901132 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/901132

Change 901237 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/901237

Change 901131 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/901131

Change 904251 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/CheckUser@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/904251

Change 904886 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/CampaignEvents@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/904886

Change 904887 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Wikistories@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/904887

Change 904257 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/MultimediaViewer@master] styles: Replace old variables calls with skin variables

https://gerrit.wikimedia.org/r/904257

Change 906773 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/ExternalGuidance@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/906773

Change 906785 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/WikibaseLexeme@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/906785

Change 906791 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/MinervaNeue@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/906791

Change 904887 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/904887

Change 908519 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] mediawiki.widgets, mediawiki.ui: Use skin variables

https://gerrit.wikimedia.org/r/908519

Change 909245 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] RCFilters: Use skin variables

https://gerrit.wikimedia.org/r/909245

Change 900807 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Replace deprecated mediawiki.ui vars

https://gerrit.wikimedia.org/r/900807

Change 900811 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/900811

Change 909666 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Wikisource@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/909666

Change 904251 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/904251

Change 909722 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Translate@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/909722

Change 909723 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/TemplateWizard@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/909723

Change 909724 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/RelatedArticles@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/909724

Change 909724 merged by jenkins-bot:

[mediawiki/extensions/RelatedArticles@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/909724

Change 909744 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Flow@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/909744

Change 909744 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/909744

Change 909723 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/909723

Change 904257 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] styles: Replace old variables calls with skin variables

https://gerrit.wikimedia.org/r/904257

Change 906773 merged by jenkins-bot:

[mediawiki/extensions/ExternalGuidance@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/906773

Change 910420 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/AdvancedSearch@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/910420

Change 904886 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/904886

Change 909666 merged by jenkins-bot:

[mediawiki/extensions/Wikisource@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/909666

Change 910420 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/910420

Change 910865 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/Vector@master] styles: Remove 'mediawiki.ui/variables' call

https://gerrit.wikimedia.org/r/910865

Change 908519 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.widgets, mediawiki.ui: Use skin variables

https://gerrit.wikimedia.org/r/908519

Change 909245 merged by jenkins-bot:

[mediawiki/core@master] RCFilters: Use skin variables

https://gerrit.wikimedia.org/r/909245

Change 910865 merged by jenkins-bot:

[mediawiki/skins/Vector@master] styles: Remove 'mediawiki.ui/variables' call

https://gerrit.wikimedia.org/r/910865

Change 906791 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/906791

Change 900810 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] styles: Replace 'mediawiki.ui/variables'

https://gerrit.wikimedia.org/r/900810

Change 906785 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/906785

Change 913634 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/ContentTranslation@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/913634

Test wiki created on Patch demo by KHarlan (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/cfdfa13682/w

Change 909722 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] styles: Replace 'mediawiki.ui/variables' call with Codex design tokens

https://gerrit.wikimedia.org/r/909722

Change 913634 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/913634

Change 896387 abandoned by VolkerE:

[mediawiki/core@master] mediawiki.ui: Remove deprecated variables

Reason:

for I6c98886996597709887b6e919d589b5ec8a9d914, which is taking dependencies into account.

https://gerrit.wikimedia.org/r/896387

Change 901217 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] styles: Replace old variables calls with skin variables

https://gerrit.wikimedia.org/r/901217

Change 856034 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.ui: Remove deprecated variables

https://gerrit.wikimedia.org/r/856034

Volker_E claimed this task.
Volker_E updated the task description. (Show Details)
Volker_E removed a project: Patch-For-Review.

Test wiki on Patch demo by KHarlan (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/cfdfa13682/w/