Maniphest T319382

🥦️ Submit upstream patch for ConditionalHeaderUtil If-None-Match wildcard handling
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jakob_WMDE
	Oct 5 2022, 9:19 AM

Tags

Referenced Files

None

Subscribers

Description

We identified this one case in which ConditionalHeaderUtil is inconsistent with the official HTTP spec. See https://github.com/wikimedia/Wikibase/blob/5d82c54968cea52ad67934083686bf7359d22960/repo/rest-api/src/RouteHandlers/Middleware/RequestPreconditionCheck.php#L71

Details

	Subject	Repo	Branch	Lines +/-
	REST: Remove `If-None-Match: *` override	mediawiki/extensions/Wikibase	master	+0 -5
	ConditionalHeaderUtil: Handle `If-None-Match: *`	mediawiki/core	master	+21 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		WMDE-leszek	T318221 🥦️ Handle conditional http headers in Wikibase REST API
		Resolved		Jakob_WMDE	T319382 🥦️ Submit upstream patch for ConditionalHeaderUtil If-None-Match wildcard handling

Event Timeline

Jakob_WMDE created this task.Oct 5 2022, 9:19 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2022, 9:19 AM

Jakob_WMDE claimed this task.Oct 5 2022, 1:44 PM

Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 14) board.

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 14) board.Oct 6 2022, 3:54 PM

Change 839604 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/core@master] ConditionalHeaderUtil: Handle `If-None-Match: *`

https://gerrit.wikimedia.org/r/839604

gerritbot added a project: Patch-For-Review.Oct 7 2022, 9:06 AM

WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 15); removed Wikibase Product Platform (v1) (Sprint 14).Oct 11 2022, 9:32 AM

WMDE-leszek moved this task from To Do to Peer Review on the Wikibase Product Platform (v1) (Sprint 15) board.

Change 839604 merged by jenkins-bot:

[mediawiki/core@master] ConditionalHeaderUtil: Handle `If-None-Match: *`

https://gerrit.wikimedia.org/r/839604

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.6; 2022-10-17).Oct 12 2022, 4:00 AM

Maintenance_bot removed a project: Patch-For-Review.Oct 12 2022, 4:30 AM

Change 841851 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Remove `If-None-Match: *` override

https://gerrit.wikimedia.org/r/841851

gerritbot added a project: Patch-For-Review.Oct 12 2022, 7:51 AM

Change 841851 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove `If-None-Match: *` override

https://gerrit.wikimedia.org/r/841851

Maintenance_bot removed a project: Patch-For-Review.Oct 12 2022, 9:30 AM

Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 15) board.Oct 12 2022, 10:31 AM

WMDE-leszek closed this task as Resolved.Dec 1 2022, 8:53 PM