Page MenuHomePhabricator

Implement support for private registration UI in registration modal
Closed, ResolvedPublic3 Estimated Story Points

Description

NOTE: This ticket does NOT include any interactions for the participant to switch between public and private registration. It is read-only. We will handle switching between registration status separately.

As a campaign participant, if I register privately, I want my username to only be displayed to me and the campaign organizers in the 'more details' moda;, so that I can register with confidentiality.

Acceptance Criteria:

  • Given a participant registers publicly
    • When viewing the participant list as any user
      • Then their username should be displayed to everyone
      • And they should be included in the registered users count
      • And they should not be included in the privately registered users count
  • Given that there are privately registered participants
    • When viewing the participant list as any user
      • Then the private registrations should be included in the registered users count
      • And they should be included in the privately registered users count
    • When there is at least 1 registered participant (whether the list is truncated or not truncated)
      • Then the count of private registrations is shown
    • When viewing the participant list as an organiser
      • Then the private registrations username should be visible with a padlock icon
    • When viewing the participant list as non-organiser
      • Then the private registrations should not be visible
    • When viewing the participant list as a privately registered participant
      • Then their username is visible with the padlock icon
      • And no other private participants are displayed.

Visual examples:

Organizer view

Organizer view.png (902×760 px, 99 KB)

Event Timeline

@gonyeahialam Hello! Can we have the images for this for sprint planning tomorrow? Thanks in advance!

ifried updated the task description. (Show Details)
ifried updated the task description. (Show Details)
ifried updated the task description. (Show Details)
MHorsey-WMF set the point value for this task to 3.

@gonyeahialam The image you provided seems to be the organizer and participant in one. Do you have a visual example that is just for the organizer side? Thanks.

@MHorsey-WMF, could you help me to clarify this, I am still confused with this part:

When the participant list is expanded

  • Then the count of private registrations is shown

You mean if the user clicks on "view all"?
I am asking because if the user clicks on "view all" he is redirected to the Special:EventDetails page, and if this is the case show the count of private registrations is not needed.

Good point, @cmelo. I have clarified the AC to say "when the participant list is not truncated."

Good point, @cmelo. I have clarified the AC to say "when the participant list is not truncated."

Thank you, @ifried

@gonyeahialam The image you provided seems to be the organizer and participant in one. Do you have a visual example that is just for the organizer side? Thanks.

Added corrected image to the description

cmelo changed the task status from Open to In Progress.Oct 26 2022, 12:20 PM
cmelo claimed this task.

Change 858357 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] Implement support for private registration UI in registration modal

https://gerrit.wikimedia.org/r/858357

@ifried @gonyeahialam I have a question about the "X participants registered privately" at the bottom. I remember that when we discussed this a while ago, we decided that the text should not be shown when the list is truncated, because it would be redundant information that you can find in the full list. This is reflected in the following AC:

  • When the participant list is truncated
    • Then the count of private registrations is not shown
  • When the participant list is not truncated
    • Then the count of private registrations is shown

However, I don't think the text is useful when the full list can be shown in the dialog, because you can see how many users registered privately. The correct AC would be much more complex than that, taking into consideration whether you are an organizer or not, whether you can see at least 10 participants, and whether private participants are hidden. I think this might be difficult to formalize and unnecessarily complex. Can we just get rid of those AC and always show the text if there's at least 1 private participant for now?

@ifried @gonyeahialam I have a question about the "X participants registered privately" at the bottom. I remember that when we discussed this a while ago, we decided that the text should not be shown when the list is truncated, because it would be redundant information that you can find in the full list. This is reflected in the following AC:

  • When the participant list is truncated
    • Then the count of private registrations is not shown
  • When the participant list is not truncated
    • Then the count of private registrations is shown

However, I don't think the text is useful when the full list can be shown in the dialog, because you can see how many users registered privately. The correct AC would be much more complex than that, taking into consideration whether you are an organizer or not, whether you can see at least 10 participants, and whether private participants are hidden. I think this might be difficult to formalize and unnecessarily complex. Can we just get rid of those AC and always show the text if there's at least 1 private participant for now?

I 100% agree with @Daimona, I think we should always show this information, it would be easier to implement and less prune to bugs.

Works for me, @Daimona & @cmelo. I have updated the AC. Thanks!

Change 858357 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Implement support for private registration UI in registration modal

https://gerrit.wikimedia.org/r/858357

vaughnwalters subscribed.

Given a participant registers publicly
When viewing the participant list as any user
✅ Then their username should be displayed to everyone
✅ And they should be included in the registered users count
✅ And they should not be included in the privately registered users count

Viewing as logged out user:

Screen Shot 2022-11-29 at 2.19.53 PM.png (1×1 px, 149 KB)

Viewing as publicly registered participant Vdubs81:

Screen Shot 2022-11-29 at 1.02.31 PM.png (1×1 px, 127 KB)


Given that there are privately registered participants
When viewing the participant list as any user
✅ Then the private registrations should be included in the registered users count
✅ And they should be included in the privately registered users count

Viewing as logged out user:

Screen Shot 2022-11-29 at 11.38.36 AM.png (732×796 px, 43 KB)

Viewing as participant:

Screen Shot 2022-11-29 at 2.21.30 PM.png (1×1 px, 175 KB)


When there is at least 1 registered participant (whether the list is truncated or not truncated)
✅ Then the count of private registrations is shown

Screen Shot 2022-11-29 at 4.27.03 PM.png (1×1 px, 179 KB)


When viewing the participant list as an organiser
✅ Then the private registrations username should be visible with a padlock icon

Screen Shot 2022-11-29 at 4.46.04 PM.png (1×1 px, 137 KB)


When viewing the participant list as non-organiser
✅ Then the private registrations should not be visible

Screen Shot 2022-11-29 at 4.48.39 PM.png (1×1 px, 125 KB)


When viewing the participant list as a privately registered participant
✅ Then their username is visible with the padlock icon
✅ And no other private participants are displayed.

Screen Shot 2022-11-29 at 4.49.54 PM.png (1×1 px, 129 KB)

AC met, moving to design sign off

Private registration is now supported in the event registration modal, so I'm marking this as Done.