@gonyeahialam Hello! Can we have the images for this for sprint planning tomorrow? Thanks in advance!

Organizer view
Organizers see a padlock icon beside the usernames of participants who registered privately and the total number of such participants at the bottom of the participant list

Participant view
Participants see only the total number of such participants at the bottom of the participant list

Hi @gonyeahialam , can you confirm that these designs are final? Confirming before we move this into async estimation. Thanks!

One question: is there a reason why the bottom text is different in the participant and organizer view? We have "13 participants registered privately" and "13 private registrations". Can we just use the former everywhere?

@Daimona: I don't think there is a reason. It seems to be an accidental inconsistency in the designs. @gonyeahialam and @Daan.L: is there a reason why, or no? And, if no, is there a language preference?

Personally, I prefer "13 participants registered privately." It's more lengthy, but it's more clear than "13 private registrations." Since this is a new feature in a new tool, I think clarity is perhaps more important than brevity.

In T319453#8343241, @ifried wrote:

@Daimona: I don't think there is a reason. It seems to be an accidental inconsistency in the designs. @gonyeahialam and @Daan.L: is there a reason why, or no? And, if no, is there a language preference?

Personally, I prefer "13 participants registered privately." It's more lengthy, but it's more clear than "13 private registrations." Since this is a new feature in a new tool, I think clarity is perhaps more important than brevity.

The inconsistency was accidental. "13 private registrations" was the initial copy but we updated it to "13 participants registered privately." because it was clearer.

Thanks, @gonyeahialam. The AC has been updated to reflect this.

I think the patch I have for this covers everything, except for one thing: the number of privately registered participants is not updated in real-time when (private) participants are removed. I don't think it makes much sense to fix it until T320649 is resolved.

Also, @ifried @gonyeahialam one question: if there are no privately registered participants, should the footer be shown (in which case it would read "0 participants registered privately") or not?

I think it is unnecessary to show the footer if there are 0 privately registered participants. What do you think, @gonyeahialam?

In T319453#8352668, @ifried wrote:

I think it is unnecessary to show the footer if there are 0 privately registered participants. What do you think, @gonyeahialam?

Yes, no need to show the footer.

Change 849189 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Show private participants on EventDetails

https://gerrit.wikimedia.org/r/849189

Change 849189 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Show private participants on EventDetails

https://gerrit.wikimedia.org/r/849189

https://en.wikipedia.beta.wmflabs.org/wiki/Special:EventDetails/118

✅ The total number of privately registered participants should be displayed for non-organizers when viewing EventDetails
privately registered user logged in:

✅ Organizers see a padlock icon beside the usernames of participants who registered privately

✅ Text should read: "XX participants registered privately"

confirming this from the AC:
Note: this text is currently not updated when participants are removed. This is tracked in T322275.

but on page refresh the count of privately registered is updated after participant removed:

and is correctly updated when viewing from another wiki

✅ If a participant registers privately, their username should only be displayed to themselves and the campaign organizers

@Daimona The username is correctly displayed only to the privately registered user and the campaign organizers, but a note that when logged in as a privately registered participant, after searching for a participant and then deleting the search term, the privately registered participant's name no longer displays first (or anywhere) in the list. Should this be fixed by another ticket or here? This does not occur when an organizer is viewing the list, just a privately registered participant (logged in as privately registered participant Vdubs77).

And also, a privately registered user cannot search for themself (logged in as privately registered participant Vdubs76):
{F35709360}

In T319453#8372310, @vaughnwalters wrote:

@Daimona The username is correctly displayed only to the privately registered user and the campaign organizers, but a note that when logged in as a privately registered participant, after searching for a participant and then deleting the search term, the privately registered participant's name no longer displays first (or anywhere) in the list. Should this be fixed by another ticket or here? This does not occur when an organizer is viewing the list, just a privately registered participant (logged in as privately registered participant Vdubs77).

Right, I think this can be fixed here.

And also, a privately registered user cannot search for themself (logged in as privately registered participant Vdubs76):

Yup, same.

Change 855028 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Special-case the current user's row on EventDetails when searching

https://gerrit.wikimedia.org/r/855028

Change 855028 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Special-case the current user's row on EventDetails when searching

https://gerrit.wikimedia.org/r/855028

In T319453#8374550, @Daimona wrote:

In T319453#8372310, @vaughnwalters wrote:

@Daimona The username is correctly displayed only to the privately registered user and the campaign organizers, but a note that when logged in as a privately registered participant, after searching for a participant and then deleting the search term, the privately registered participant's name no longer displays first (or anywhere) in the list. Should this be fixed by another ticket or here? This does not occur when an organizer is viewing the list, just a privately registered participant (logged in as privately registered participant Vdubs77).

Right, I think this can be fixed here.

And also, a privately registered user cannot search for themself (logged in as privately registered participant Vdubs76):

Yup, same.

Both of these issues are fixed now as shown in gif below. See T319453#8372310 for the rest of the testing notes. Moving this to design sign off.