Maniphest T319498

Uncaught TypeError: mw.centralNotice.isBannerShown is not a function
Open, Needs TriagePublicBUG REPORT
Actions

Assigned To

None

Authored By

	SunAfterRain
	Oct 6 2022, 2:33 AM

Description

Steps to replicate the issue (include links if applicable):

go to https://meta.wikimedia.org/w/index.php?title=Main_Page&debug=2&safemode=1
enter some JavaScript code console which can make a error, like:

throw new Error();

What happens?:

Uncaught TypeError: mw.centralNotice.isBannerShown is not a function
    at log (https://meta.wikimedia.org/w/load.php?debug=2&modules=ext.wikimediaEvents&version=ztntf:514:62)
    at Object.<anonymous> (https://meta.wikimedia.org/w/load.php?debug=2&modules=ext.wikimediaEvents&version=ztntf:593:4)
    at Object.handler (https://meta.wikimedia.org/w/load.php?debug=2&modules=mediawiki.base&version=ztntf:400:14)
    at fire (https://meta.wikimedia.org/w/load.php?debug=2&modules=jquery&version=ztntf:3501:31)
    at Object.fireWith (https://meta.wikimedia.org/w/load.php?debug=2&modules=jquery&version=ztntf:3631:7)
    at Object.fire (https://meta.wikimedia.org/w/load.php?debug=2&modules=jquery&version=ztntf:3639:10)
    at mw.track (https://meta.wikimedia.org/w/load.php?debug=2&modules=mediawiki.base&version=ztntf:370:17)
    at window.onerror (https://meta.wikimedia.org/w/load.php?debug=2&modules=mediawiki.base&version=ztntf:1067:6)

What should have happened instead?:

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

	Subject	Repo	Branch	Lines +/-
	clientError: Fix error in mw.centralNotice.isBannerShown check	mediawiki/extensions/WikimediaEvents	master	+6 -1

Customize query in gerrit

Related Objects

Mentioned In: T265096: Tag errors where a banner is being displayed
T319463: Rewrite AddMe gadget on meta
Mentioned Here: T265096: Tag errors where a banner is being displayed

Event Timeline

SunAfterRain created this task.Oct 6 2022, 2:33 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 6 2022, 2:33 AM

Reedy added a project: MediaWiki-extensions-CentralNotice.Oct 6 2022, 2:36 AM

This looks more like an error in the WikimediaEvents extension. That extension appears to assume that the CentralNotice function isBannerShown() is available, however, it's only there in some circumstances, depending on which CentralNotice campaigns, if any, are currently targeting the wiki on which the pageview occurred.

@AndyRussG: Please add project tags in that case, so tasks could be found or seen. Thanks.

Looks like this is related to the change in T265096: Tag errors where a banner is being displayed

Pcoombe added a project: DoNotUse---Instrument-ClientError.Oct 10 2022, 6:20 PM

MusikAnimal mentioned this in T319463: Rewrite AddMe gadget on meta.Nov 22 2022, 9:51 PM

Aklapper edited projects, added Instrument-ClientError; removed DoNotUse---Instrument-ClientError.Nov 24 2022, 1:55 PM

Tgr mentioned this in T265096: Tag errors where a banner is being displayed.Jan 30 2023, 5:19 AM

Change 884522 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/WikimediaEvents@master] Fix error in client error logging banner check

https://gerrit.wikimedia.org/r/884522

gerritbot added a project: Patch-For-Review.Jan 30 2023, 5:31 AM

Change 884522 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] clientError: Fix error in mw.centralNotice.isBannerShown check

https://gerrit.wikimedia.org/r/884522

Maintenance_bot removed a project: Patch-For-Review.Jan 30 2023, 10:30 AM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Jan 30 2023, 11:00 AM

This is also likely showing up as "Script error" due to the code coming from an alternate domain
https://logstash.wikimedia.org/app/dashboards#/doc/logstash-*/logstash-default-1-7.0.0-1-2023.02.06?id=s2mKJ4YBP9x85JnS99m9
file_url is https://meta.wikimedia.org/w/index.php?title=Special:BannerLoader&campaign=Wiki+Loves+Folklore+2023+International&banner=wikilovesfolklore2023&uselang=en&debug=false

but error_context.banner_shown is false.

Thanks @Jdlrobson! I'll make a CN patch just to always expose a mw.centralNotice.isBannerShown() function no matter what, since that seems like the most logical way for the CN JS API to work, and would prevent errors like the one mentioned in the task description.

(Not sure I follow what the error you linked in Logstash is, though. No one should be visiting Special:BannerLoader directly--it's just for background calls to load the banner to be injected. I see https://en.wikipedia.org/wiki/Data_aggregation in the url field on that link, though.)

@AndyRussG I think the issue here is inside the banner itself.

According to the error report it occurs on the file URL:
https://meta.wikimedia.org/w/index.php?title=Special:BannerLoader&campaign=Wiki+Loves+Folklore+2023+International&banner=wikilovesfolklore2023&uselang=en&debug=false

So something is loading that code and executing it and it's throwing an error. I'm assuming this code should only be executed if a banner is shown? e.g. if the code is being loaded mw.centralNotice.isBannerShown() should be true, but it seems like it's not? is something else happening? Perhaps this is being hit during preview? if so perhaps the URL could be updated to include a query string to allow filtering e.g. https://meta.wikimedia.org/w/index.php?title=Special:BannerLoader&campaign=Wiki+Loves+Folklore+2023+International&banner=wikilovesfolklore2023&uselang=en&debug=false&mode=preview

Uncaught TypeError: mw.centralNotice.isBannerShown is not a functionOpen, Needs TriagePublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

Uncaught TypeError: mw.centralNotice.isBannerShown is not a function
Open, Needs TriagePublicBUG REPORT
Actions