Maniphest T319544

Participant side: Implement support for private registration UI in registration modal
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	ifried
	Oct 6 2022, 2:02 PM

Description

NOTE: This ticket does NOT include any interactions for the participant to switch between public and private registration. It is read-only. We will handle switching between registration status separately.

Acceptance Criteria:

*Given a participant registers publicly

When viewing the participant list as any user
Then their username should be displayed to everyone
And they should be included in the registered users count
And they should not be included in the privately registered users count

Given that there are privately registered participants
- When viewing the participant list as any user
- Then the private registrations should be included in the registered users count
- And they should be included in the privately registered users count

When there is at least 1 registered participant (whether the list is truncated or not truncated)
- Then the count of private registrations is shown

When viewing the participant list as non-organizer
- Then the general private registrations should not be visible

When viewing the participant list as a privately registered participant
- Then their username is visible with the padlock icon
- And no other private participants are displayed.

Visual examples:

Participant view

Note: The final appearance of the dialog footer is being decided on T319454

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/CampaignEvents	master	+175 -68	Implement support for private registration UI in registration modal

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	MHorsey-WMF	T316405 [EPIC] Allow participant option of joining event privately
Resolved	MHorsey-WMF	T319452 Implement support for private registration UI in registration modal
Resolved	MHorsey-WMF	T319544 Participant side: Implement support for private registration UI in registration modal

Event Timeline

ifried created this task.Oct 6 2022, 2:02 PM

ifried updated the task description. (Show Details)Oct 6 2022, 2:18 PM

ldelench_wmf set the point value for this task to 3.Oct 6 2022, 2:19 PM

ldelench_wmf edited projects, added Campaign-Tools (Campaign-Tools-Current-Sprint); removed Campaign-Tools.

@gonyeahialam Do you have an example of how this will look from the participant side that we can use as a visual example?

ifried moved this task from Needs Input / Design in progress to Ready for development on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Oct 6 2022, 7:30 PM

ifried updated the task description. (Show Details)Oct 6 2022, 8:11 PM

gonyeahialam updated the task description. (Show Details)Oct 7 2022, 9:20 PM

ifried mentioned this in T320641: Security/Privacy Review For P&E Dashboard Integration with Campaign Registration System.Oct 12 2022, 2:55 PM

• vyuen removed a project: Campaign-Tools (Campaign-Tools-Current-Sprint).Oct 18 2022, 2:22 PM

• vyuen moved this task from Backlog to V1 (MVP) on the Campaign-Registration board.Oct 31 2022, 4:45 PM

• vyuen added a project: Campaign-Tools (Campaign-Tools-Current-Sprint).Oct 31 2022, 4:51 PM

Given T319452, can this task be rescoped, clarified, or closed as duplicate? I think it might be easier to implement both options at the same time, and even if not, I'm not sure if this would be a 3-pointer assuming that T319452 will be completed first.

MHorsey-WMF changed the task status from Open to In Progress.Nov 8 2022, 12:40 PM

MHorsey-WMF claimed this task.

MHorsey-WMF moved this task from Ready for development to In Progress 💻 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.

MHorsey-WMF moved this task from In Progress 💻 to Code Review/Tech Input 💬 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Nov 17 2022, 5:12 PM

Change 858357 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] Implement support for private registration UI in registration modal

https://gerrit.wikimedia.org/r/858357

gerritbot added a project: Patch-For-Review.Nov 22 2022, 4:54 PM

ldelench_wmf triaged this task as High priority.Nov 27 2022, 7:56 PM

Daimona moved this task from Code Review/Tech Input 💬 to QA 🐛 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Nov 28 2022, 7:11 PM

Daimona removed a project: Patch-For-Review.

Change 858357 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Implement support for private registration UI in registration modal

https://gerrit.wikimedia.org/r/858357

ifried updated the task description. (Show Details)Nov 28 2022, 11:26 PM

ifried updated the task description. (Show Details)

*Given a participant registers publicly

When viewing the participant list as any user
✅ Then their username should be displayed to everyone
✅ And they should be included in the registered users count
✅ And they should not be included in the privately registered users count
Viewing as logged out user:

Screen Shot 2022-11-29 at 2.19.53 PM.png (1×1 px, 149 KB)

Viewing as publicly registered participant Vdubs81:

Screen Shot 2022-11-29 at 1.02.31 PM.png (1×1 px, 127 KB)

Given that there are privately registered participants
When viewing the participant list as any user
✅ Then the private registrations should be included in the registered users count
✅ And they should be included in the privately registered users count

Viewing as logged out user:

Screen Shot 2022-11-29 at 11.38.36 AM.png (732×796 px, 43 KB)

Viewing as participant:

Screen Shot 2022-11-29 at 2.21.30 PM.png (1×1 px, 175 KB)

When there is at least 1 registered participant (whether the list is truncated or not truncated)
✅ Then the count of private registrations is shown
@MHorsey-WMF I Created T324039 because count of private registrations is not showing when list is truncated and user is logged out. Count of private registrations shows in all other cases, so I am marking this AC as complete, since there is now a ticket to deal with that issue.

When viewing the participant list as non-organizer
✅ Then the general private registrations should not be visible

Screen Shot 2022-11-29 at 2.03.45 PM.png (1×1 px, 145 KB)

When viewing the participant list as a privately registered participant
✅ Then their username is visible with the padlock icon
✅ And no other private participants are displayed.

Screen Shot 2022-11-29 at 1.07.00 PM.png (1×1 px, 170 KB)

Screen Shot 2022-11-29 at 1.05.21 PM.png (1×1 px, 127 KB)

gonyeahialam moved this task from Design Sign-Off 🖌️ to Product sign-off 🤘 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Nov 30 2022, 1:19 PM

The participant side of the event registration modal now has support for private registration, so I'm marking this work as Done.

	F35824444: Screen Shot 2022-11-29 at 1.05.21 PM.png
	Nov 29 2022, 8:42 PM

	F35824447: Screen Shot 2022-11-29 at 1.07.00 PM.png
	Nov 29 2022, 8:42 PM

	F35824524: Screen Shot 2022-11-29 at 2.03.45 PM.png
	Nov 29 2022, 8:42 PM

	F35824547: Screen Shot 2022-11-29 at 2.21.30 PM.png
	Nov 29 2022, 8:42 PM

	F35824355: Screen Shot 2022-11-29 at 11.38.36 AM.png
	Nov 29 2022, 8:42 PM

	F35824441: Screen Shot 2022-11-29 at 1.02.31 PM.png
	Nov 29 2022, 8:42 PM

	F35824545: Screen Shot 2022-11-29 at 2.19.53 PM.png
	Nov 29 2022, 8:42 PM

Participant side: Implement support for private registration UI in registration modalClosed, ResolvedPublic3 Estimated Story PointsActions

Description

Details

Related ObjectsSearch...

Event Timeline

Participant side: Implement support for private registration UI in registration modal
Closed, ResolvedPublic3 Estimated Story Points
Actions

Related Objects
Search...