Page MenuHomePhabricator

Use Junos BGP graceful-shutdown and shutdown features
Closed, ResolvedPublic


In T190323: Implement BGP graceful shutdown and T211728: Outbound BGP graceful shutdown
I implemented the BGP graceful-shutdown using policies.

Since then Juniper introduced it as a standalone config knob in Junos 19.1:

Using this feature will have two main benefits:

  • Simplify our configuration and policies
  • Allow easier usage of graceful-shutdown by configuring it directly at the edit protocols bgp level
    • This will make sure graceful-shutdown is enabled everywhere
    • This will ease draining full nodes by only having to do set protocols bgp graceful-shutdown sender

Secondly, until now the only way to disable BGP sessions were to deactivate them.
In Junos 19.1 Juniper added the shutdown feature:
We should update our docs to use this instead.

A clean process would be to first apply graceful-shutdown sender, wait a minute or less, then apply shutdown.
This will ensure minimal disruption during maintenance.

Event Timeline

ayounsi created this task.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 904192 had a related patch set uploaded (by Ayounsi; author: Ayounsi):

[operations/homer/public@master] Remove custom BGP graceful-shutdown

Change 904192 merged by jenkins-bot:

[operations/homer/public@master] Remove custom BGP graceful-shutdown

Mentioned in SAL (#wikimedia-operations) [2023-03-29T14:49:00Z] <XioNoX> Remove custom BGP graceful-shutdown on all core routers - T320230

Change 904193 had a related patch set uploaded (by Ayounsi; author: Ayounsi):

[operations/homer/public@master] Rename bgp disable flag to shutdown

Change 904193 merged by jenkins-bot:

[operations/homer/public@master] Rename bgp disable flag to shutdown

ayounsi claimed this task.