Page MenuHomePhabricator

Make links to Special:EventDetails point to the relevant tab
Closed, ResolvedPublic

Description

Once T318334 is resolved, Special:EventDetails will have one tab for details and one for participants, and the active tab can be selected with a URL parameter. Thus, we should change the link to view all participants found in the "more details" dialog to point to the participants tab.

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptOct 7 2022, 12:27 PM

Change 858357 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] Implement support for private registration UI in registration modal

https://gerrit.wikimedia.org/r/858357

(As discussed in sprint planning, the registration modal is not the only place where we could update the links, so moving this back to ready)

@Daimona I can only see the link in EventPageDecorator (the details dialog), are there more that I'm missing?

@Daimona I can only see the link in EventPageDecorator (the details dialog), are there more that I'm missing?

The ones I could find are EventPageDecorator, RegistrationNotificationPresentationModel, and EventsPager. I think all of them should point to the details tab (which is the default), except for the one in the "more details" dialog that you already fixed. So maybe there's nothing else to do for this task.

@Daimona + @cmelo Shall we close this one off then?

It can stay in the review column, since the only patch needed for it is already in review.

Change 858357 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Implement support for private registration UI in registration modal

https://gerrit.wikimedia.org/r/858357

vaughnwalters added a subscriber: vaughnwalters.

โœ… change the link to view all participants found in the "more details" dialog to point to the participants tab.

Screen Recording 2022-11-29 at 3.28.46 PM.gif (1ร—2 px, 203 KB)

Screen Recording 2022-11-29 at 3.33.30 PM.gif (1ร—700 px, 1 MB)

AC met, moving to product sign off

ifried added a subscriber: ifried.

The user is correctly redirected to the participant list when they click on 'view full list,' so I'm marking this as Done.