Page MenuHomePhabricator

Remove BaseTemplateAfterPortletHook and associated methods
Closed, ResolvedPublic

Description

@deprecated since 1.35 (emits deprecation warnings since 1.37) with note to use SkinAfterPortlet instead.

No known consumers.

TODO

  • Remove Hook/BaseTemplateAfterPortletHook.php
  • Remove line $this->getHookRunner()->onBaseTemplateAfterPortlet( $this, $name, $content ); in BaseTemplate.php
  • Remove BaseTemplate::renderAfterPortlet
  • Remove BaseTemplate::getAfterPortlet (unused in any maintained skin)

Event Timeline

Jdlrobson renamed this task from Remove BaseTemplateAfterPortletHook to Remove BaseTemplateAfterPortletHook and associated methods.Oct 9 2022, 4:53 PM
Jdlrobson updated the task description. (Show Details)
Bleakprestiger subscribed.
This comment was removed by Bleakprestiger.

@Bleakprestiger please unassign this from yourself if you no longer plan to work on this! Thanks!

for Remove line $this->getHookRunner()->onBaseTemplateAfterPortlet( $this, $name, $content ); in BaseTemplate.php, I can't find the code in BaseTemplate.php: https://codesearch.wmcloud.org/search/?q=getHookRunner&i=nope&files=&excludeFiles=&repos=

Obviously this misleads me, because this checkbox is not ticked in the mission profile.

Change 899535 had a related patch set uploaded (by Richika Rana; author: Richika Rana):

[mediawiki/core@master] BaseTemplate: Remove ::renderAfterPortlet & getAfterPortlet

https://gerrit.wikimedia.org/r/899535

Change 900131 had a related patch set uploaded (by D3r1ck01; author: Richika Rana):

[mediawiki/core@REL1_39] BaseTemplate: Remove ::renderAfterPortlet & getAfterPortlet

https://gerrit.wikimedia.org/r/900131

Change 900131 abandoned by D3r1ck01:

[mediawiki/core@REL1_39] BaseTemplate: Remove ::renderAfterPortlet & getAfterPortlet

Reason:

https://gerrit.wikimedia.org/r/900131

Change 900145 had a related patch set uploaded (by Jdlrobson; author: Richika Rana):

[mediawiki/core@REL1_40] BaseTemplate: Remove ::renderAfterPortlet & getAfterPortlet

https://gerrit.wikimedia.org/r/900145

Change 900145 merged by jenkins-bot:

[mediawiki/core@REL1_40] BaseTemplate: Remove ::renderAfterPortlet & getAfterPortlet

https://gerrit.wikimedia.org/r/900145

Change 899535 merged by jenkins-bot:

[mediawiki/core@master] BaseTemplate: Remove ::renderAfterPortlet & getAfterPortlet

https://gerrit.wikimedia.org/r/899535

Jdlrobson claimed this task.
Jdlrobson added a subscriber: R_Rana.

Thank you for the patches @R_Rana !