Page MenuHomePhabricator
Create Task
Maniphest T320360

[Format/Rewrite] Indicate the support patch "format" in Unsupported Content Type responses to PATCH routes
Closed, InvalidPublic3 Estimated Story Points
Actions

Description

As a Wikidata PM I want clients of REST API know the allowed content types so that they can make valid PATCH requests.

Currently the allowed content type is application/json-patch+json.
When returning 415 Unsupported Content-Type response it should include Accept-Patch: application/json-patch+json header.

While application/json is an accepted content-type (API assuming input is application/json-patch+json and treats it as such), the API should be clearly promoting usage of application/json-patch+json. Therefore PATCH requests of content-type application/json should also result in responses containing Accept-Patch: application/json-patch+json header even if the request is processed successfully.

Related Objects
Search...

Event Timeline

WMDE-leszek created this task.Oct 9 2022, 9:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2022, 9:41 PM
Silvan_WMDE set the point value for this task to 3.Oct 17 2022, 10:19 AM
WMDE-leszek moved this task from Backlog to Next on the Wikibase Product Platform (v1) board.Oct 23 2022, 7:39 PM
Ifrahkhanyaree_WMDE added a project: Wikibase Reuse Team.Jul 28 2023, 1:01 PM
Ifrahkhanyaree_WMDE removed a project: Wikibase Product Platform (v1).Jul 28 2023, 1:03 PM
Ifrahkhanyaree_WMDE moved this task from Incoming tickets outside WPP to Ready for planning on the Wikibase Reuse Team board.Jul 28 2023, 1:03 PM
Ifrahkhanyaree_WMDE added a project: Wikibase REST API (WPP).Jul 28 2023, 1:38 PM
Ifrahkhanyaree_WMDE moved this task from Ready for planning to Incoming tickets outside WPP on the Wikibase Reuse Team board.Sep 25 2023, 10:03 AM
Ifrahkhanyaree_WMDE added a parent task: T344228: Functionality for REST API v1.Sep 26 2023, 8:21 AM
Ifrahkhanyaree_WMDE moved this task from Incoming tickets outside WPP to Backlog on the Wikibase Reuse Team board.Oct 19 2023, 1:45 PM
Ifrahkhanyaree_WMDE moved this task from Backlog to Backlog on the Wikibase Reuse Team board.Oct 19 2023, 1:51 PM
Ifrahkhanyaree_WMDE renamed this task from Indicate the support patch "format" in Unsupported Content Type responses to PATCH routes to [Format/Rewrite] Indicate the support patch "format" in Unsupported Content Type responses to PATCH routes.Jun 25 2024, 11:59 AM
Ifrahkhanyaree_WMDE edited parent tasks, added: T316718: Errors in Wikibase REST API; removed: T344228: Functionality for REST API v1.
Ifrahkhanyaree_WMDE subscribed.

@WMDE-leszek just going through tickets to make the overview we talked about and after reading this ticket, it seems to belong with the error epic and under the sub theme of reformat/rewrite - wdyt?

Ollie.Shotton_WMDE mentioned this in T368398: [MAIN] REST API v1 CHECKLIST.Jun 26 2024, 5:13 PM
Ifrahkhanyaree_WMDE moved this task from Backlog to To polish on the Wikibase Reuse Team board.Sep 9 2024, 12:16 PM
Ifrahkhanyaree_WMDE added a comment.Sep 16 2024, 9:45 AM

Error doesn't come from us anymore but is checked by Mediawiki. We cover this in our documentation already and can wait to see if users give feedback wanting this in the future and we can then revisit it.

Ifrahkhanyaree_WMDE moved this task from To polish to Backlog on the Wikibase Reuse Team board.Sep 16 2024, 9:45 AM
Ifrahkhanyaree_WMDE closed this task as Invalid.Sep 20 2024, 12:59 PM

Going to close this, we can open a new ticket if the need arises

Ifrahkhanyaree_WMDE moved this task from Backlog to Done on the Wikibase REST API (WPP) board.Nov 21 2024, 3:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits