Page MenuHomePhabricator

Who Wrote That annotations load, but without yellow highlighting
Open, Needs TriagePublic3 Estimated Story PointsBUG REPORT

Description

Yellow highlighting fails in Who Wrote That, even when a given run is otherwise working. I.e., after WWT load completes and clicking page text successfully shows the pop-up dialog box with who/when and the underlying diff link, which when clicked goes to the correct diff page, but all without any yellow highlighting.

This happens intermittently. The last few days have been clear, but today I had two unhighlighted pages in a row, right after having viewed the same page (Transgender) with highlighting a few minutes earlier. I'm sorry I don't have any reproduction steps for you, but it's occurring too intermittently to reproduce, or to remember exactly how I got there, other than clicking the WWT link I have in the sidebar at en-wiki after having installed the extension.

Spawned from comment T318746#8285520 as suggested by @TheresNoTime.

Possibly of interest to @MusikAnimal, @Sennecaster, @Tamzin.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
KSiebert changed the subtype of this task from "Task" to "Bug Report".Oct 10 2022, 2:13 PM

Looks like this is a problem in Vector 2022

First time I've seen this symptom: yellow highlighting disappeared while viewing an annotated page.

While using a page on en-wiki (Marc Bloch) with functioning pop-up boxes and proper yellow highlighting, I scrolled down a bit from one part of a section to another, and although highlighting was normal a few seconds prior now it no longer appeared.

Before this, a page was either unhighlighted or highlighted when WWT finished loading, and if the latter, it remained highlighted until I was finished using it. This is the first time I've seen highlighting disappear while viewing a functioning, highlighted page.

Happening on Rajputisation for me. Happens intermittently; considering what I use WWT for (copyright investigations) this is extremely annoying as purges don't seem to fix it. Once I close WWT after seeing this happen, I can no longer click on the page normally and it functions basically as if WWT did not even close. Furthermore; the text itself decreases in font size massively when I encounter this error, and no time else.
From my console; none of this makes sense to me so you get it all.

This page is using the deprecated ResourceLoader module "jquery.ui". Please use OOUI instead. load.php:294:1055
Some cookies are misusing the recommended “SameSite“ attribute 3
Use of Mutation Events is deprecated. Use MutationObserver instead. load.php:67:661
This page uses the non standard property “zoom”. Consider using calc() in the relevant property values, or using “transform” along with “transform-origin: 0 0”. Rajputisation
Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user’s experience. For more help http://xhr.spec.whatwg.org/ load. php:133:733
ext.popups was loaded but everything is disabled

Cookie “enwikiwmE-sessionTickLastTickTime” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite

The Tale of Jemima Puddle-Duck this time around. Same problems as last time, but this time I got a more concrete error.

Who Wrote That? (): WhoWroteThat encountered a "refresh" error:
Object { info: "Requested data is not currently available in WikiWho database. It will be available soon.", success: false, rev_id: 1094913793, page_title: "The_Tale_of_Jemima_Puddle-Duck" }
​info: "Requested data is not currently available in WikiWho database. It will be available soon."
page_title: "The_Tale_of_Jemima_Puddle-Duck"
rev_id: 1094913793
success: false
​<prototype>: Object { … }
generated.pageScript.js:2227:28

log moz-extension://63e9ac13-5ec0-4738-9377-76c460bc5969/js/generated.pageScript.js:2227
getJsonData moz-extension://63e9ac13-5ec0-4738-9377-76c460bc5969/js/generated.pageScript.js:774

@Mathglot @Sennecaster Are you using Vector 2022? That's the only skin I'm able to repro in.


From my console; none of this makes sense to me so you get it all.

This page is using the deprecated ResourceLoader module "jquery.ui". Please use OOUI instead. load.php:294:1055

I think all of that is unrelated, but thanks for sharing anyway as often there are useful things in the output :)

Who Wrote That? (): WhoWroteThat encountered a "refresh" error:

You should have seen a user-facing error in this case telling you to try again. I just checked and the WikiWho server is running normally, but it may have been backed up processing new edits when you encountered this error.

@MusikAnimal I am using Vector 2022; it was mentioned in the ticket Mathglot linked in the OP so I assumed someone already knew, whoops!

MusikAnimal renamed this task from WWT annotated load succeeds, but w/o yellow highlighting (Who Wrote That?) to Who Wrote That annotations load, but without yellow highlighting in Vector 2022.Nov 8 2022, 4:50 AM
MusikAnimal added a subscriber: Danbloch.

I am exclusively using Vector 2010. Sorry I didn't see the ping.

Mathglot renamed this task from Who Wrote That annotations load, but without yellow highlighting in Vector 2022 to Who Wrote That annotations load, but without yellow highlighting.Nov 8 2022, 5:45 PM
Mathglot added a subscriber: Danbloch.

I don't know why the ticket says I added a subscriber, and I don't know how to undo it; sorry.

TheresNoTime renamed this task from Who Wrote That annotations load, but without yellow highlighting to Who Wrote That annotations load, but without yellow highlighting in Vector 2022.Mar 17 2023, 10:53 AM
TheresNoTime removed a subscriber: Danbloch.
TheresNoTime added a subscriber: Danbloch.

Just tried to replicate this — appears to be working as expected?

Ignore me, should have read the task more carefully — intermittent/only affecting some pages...

(also don't know why that subscriber keeps readding, sorry..)

(with thanks to @Femkemilene for the pointer)

Today replicated with https://en.wikipedia.org/wiki/Effects_of_climate_change:

  • Using legacy Vector, the highlighting works as expected
  • Using Vector 2022, the highlighting does not work (and some <noinclude> tags appear at the start of the article)

Today replicated with https://en.wikipedia.org/wiki/Effects_of_climate_change:

  • Using legacy Vector, the highlighting works as expected
  • Using Vector 2022, the highlighting does not work (and some <noinclude> tags appear at the start of the article)

The <noinclude> tags appear on both skins for me, so I believe that's unrelated issue.

It looks like for any long-ish article, such as the above example, the overlayed content isn't on top of the original as it should be in Vector 2022. Rather, it's duplicated beneath it. So if you scroll down to the duplicated article WWT works as expected.

@TheresNoTime, I originally opened this ticket, and although it appears that others have seen this on Vector 2022, I never have—I've seen it exclusively on Vector 2010. Can you please explain why this was renamed on Mar 17 2023, 3:53 AM from "annotations load, but without yellow highlighting" (which seems accurate to me in its generality) to "annotations load, but without yellow highlighting in Vector 2022", which does not cover the bug I originally encountered? If the original bug concerning Vector 2010 has not already been fixed, any objection if I rename it back again?

@TheresNoTime, I originally opened this ticket, and although it appears that others have seen this on Vector 2022, I never have—I've seen it exclusively on Vector 2010. Can you please explain why this was renamed on Mar 17 2023, 3:53 AM from "annotations load, but without yellow highlighting" (which seems accurate to me in its generality) to "annotations load, but without yellow highlighting in Vector 2022", which does not cover the bug I originally encountered? If the original bug concerning Vector 2010 has not already been fixed, any objection if I rename it back again?

I possibly set it back to a previous task title change when I could also only reproduce the issue in Vector 2022 — you're of course welcome to set the title back :-)

Are you able to test if https://en.wikipedia.org/wiki/Effects_of_climate_change works for you?

Mathglot renamed this task from Who Wrote That annotations load, but without yellow highlighting in Vector 2022 to Who Wrote That annotations load, but without yellow highlighting.Apr 19 2023, 7:31 AM

you're of course welcome to set the title back :-)

✅ Done.

Are you able to test if https://en.wikipedia.org/wiki/Effects_of_climate_change works for you?

I'll try to get to this in a few days; I invite you to bug me if I forget. :-)