Page MenuHomePhabricator
Create Task
Maniphest T320402

Function editor: In mobile, create/edit fields are aligned to the right of their labels instead of below
Closed, ResolvedPublicBUG REPORT
Actions

Description

Description

Steps to reproduce:

  1. Go to the mobile create function page: https://m.wikifunctions.beta.wmflabs.org/wiki/Special:CreateZObject?view=function-editor

Observed behavior:

  • Language, name and alias fields are aligned to the right of their labels

Screenshot from 2022-10-07 15-36-58.png (744×407 px, 50 KB)

Expected behavior (Acceptance criteria):

  • Alignment of fields should be under the labels

Screenshot from 2022-10-07 15-35-47.png (691×320 px, 46 KB)

Devices and Design (URLs or screenshots, if applicable):

https://www.figma.com/file/z4PDWdNVvwEtRMMozW8Fvi/Function-editor?node-id=2832%3A11786

Completion checklist

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Aligned to the right of labels instead of below in function creationmediawiki/extensions/WikiLambdamaster+20 -0
Customize query in gerrit

Event Timeline

gengh created this task.Oct 10 2022, 11:39 AM
gengh updated the task description. (Show Details)
Teleosteen claimed this task.Oct 11 2022, 1:56 PM

Devices and Design (URLs or screenshots, if applicable):

https://www.figma.com/file/z4PDWdNVvwEtRMMozW8Fvi/Function-editor?node-id=2832%3A11786

I don't have access to this. My work is based on the screenshots attached to the ticket.

gerritbot added a comment.Oct 11 2022, 2:00 PM

Change 841528 had a related patch set uploaded (by Teleosteen; author: Teleosteen):

[mediawiki/extensions/WikiLambda@master] Aligned to the right of labels instead of below in function creation

https://gerrit.wikimedia.org/r/841528

gerritbot added a project: Patch-For-Review.Oct 11 2022, 2:00 PM
gerritbot added a comment.Oct 11 2022, 6:02 PM

Change 841528 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Aligned to the right of labels instead of below in function creation

https://gerrit.wikimedia.org/r/841528

Maintenance_bot removed a project: Patch-For-Review.Oct 11 2022, 6:30 PM
DVrandecic moved this task from To Triage to Phase θ – Throttling on the Abstract Wikipedia team board.Oct 11 2022, 6:41 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.6; 2022-10-17).Oct 11 2022, 7:00 PM
gengh closed this task as Resolved.Oct 24 2022, 5:38 PM
gengh moved this task from Incoming to Ready: G4. Function view on the Abstract Wikipedia team (Phase θ – Throttling) board.
gengh moved this task from Ready: G4. Function view to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits