Page MenuHomePhabricator

Function editor: In mobile, function confirmation dialog should be vertically centered with respect to the page content
Closed, ResolvedPublicBUG REPORT

Description

Description

Steps to reproduce:

  1. Go to the mobile site for create function: https://m.wikifunctions.beta.wmflabs.org/wiki/Special:CreateZObject?view=function-editor
  2. Fill up the necessary data, add a couple of labels so that the page is long enough
  3. Click save

Observed behavior:

Confirmation dialog is vertically centered with respect to the content, so if the page is long, the user needs to scroll to see it

Screenshot from 2022-10-07 15-47-28.png (742×404 px, 30 KB)

Expected behavior (Acceptance criteria):

  • Dialog should be vertically centered with respect to the view port

Devices and Design (URLs or screenshots, if applicable):


Completion checklist

Event Timeline

gengh changed the task status from Open to Stalled.Oct 11 2022, 1:00 PM

Stalling this, because it might be affected by the new Publish component designs.

Jdforrester-WMF renamed this task from Function editor: In mobile, function confirmation dialog is vertically centered with respect to the page content to Function editor: In mobile, function confirmation dialog should be vertically centered with respect to the page content.Oct 11 2022, 6:39 PM

Change 841898 had a related patch set uploaded (by Teleosteen; author: Teleosteen):

[mediawiki/extensions/WikiLambda@master] Mobile: align confirmation box vertically despite vertical scroll

https://gerrit.wikimedia.org/r/841898

Teleosteen added a subscriber: Teleosteen.

Stalling this, because it might be affected by the new Publish component designs.

@gengh Sorry, I saw your comment too lately. I found a really simple fix.

Feel free to discard and remove my patch in favor of the rework if you believe it is not worth a review (I would understand :) ).

Change 841898 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Mobile: align confirmation box vertically despite vertical scroll

https://gerrit.wikimedia.org/r/841898