Page MenuHomePhabricator

Record which implementation gets selected
Closed, ResolvedPublic

Description

When a function is run, we'd like to report back to the front end which implementation was selected. Now that the metadata map is part of Z22, we have the mechanism for doing this. With orchestrator patch 838864, we have a designated metadata key for this purpose, implementationId, and we report on the persistent ID of the selected implementation if it's a BuiltIn. More work is needed to capture the persistent IDs of Evaluated and Composite implementations. It appears the information can be captured in executeInternal(), before resolving the list of available implementations.

Once the ID is captured, it can be passed directly to addImplementationMetadata(), or perhaps it could be inserted into a new public field of class Implementation, and addImplementationMetadata() could get it from there.

Note: there is no guarantee a persistent ID will be available in all cases, but we want to capture it if it is there.

See the TODO for this ticket in execute.js.

Event Timeline

Change 850681 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-orchestrator@master] Record which implementation gets selected

https://gerrit.wikimedia.org/r/850681

Change 850683 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-orchestrator@master] Correct testing checks for metadata elements

https://gerrit.wikimedia.org/r/850683

Change 851180 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-orchestrator@master] Correct testing checks for metadata elements

https://gerrit.wikimedia.org/r/851180

Change 850683 abandoned by David Martin:

[mediawiki/services/function-orchestrator@master] Correct testing checks for metadata elements

Reason:

Resubmitted as 851180

https://gerrit.wikimedia.org/r/850683

Change 850681 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Record which implementation gets selected

https://gerrit.wikimedia.org/r/850681

Change 851180 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] test: Correct checks for metadata elements

https://gerrit.wikimedia.org/r/851180