PR: https://github.com/wmde/fundraising-banners/pull/1078

This banner now includes the new Visitors vs Donors sentence

@AbbanWMDE If you click on "Yes" in the soft close banner, the big banner will reappear until the timeout has finished - don't know why.

@AbbanWMDE I found some more issues:

• The banners don't pass the language parameter to the Fundraising Application.
• The automatic sliding should stop at the last slide.
• The highlighting color should be yellow, the same as in the other banners.
• The first cost category's description should be aligned left. There also is an & in the copy.

{F35599083}

{F35599084}

The first cost category's description should be aligned left. There also is an & in the copy.

Dammit this is probably affecting all banners, including the live ones. Looks like it was like that since we made the new UoF modal.

Okay, the fixes are applied now.

@AbbanWMDE The mini banner buttons only stop the countdown timer on the right, but don't close the banner. Instead, an error message is sent to the logging server:

TypeError: Cannot read properties of undefined (reading 'preventDefault')
  at Object.onMaybeLater  <anonymous>:1:203076\nat Object.onClick [as clickfalse]  <anonymous>:1:200003
  at HTMLButtonElement.T  <anonymous>:1:133817

If I let the timer run out, the mini banner is hidden.

Should be fixed now.

@AbbanWMDE Yes, works now. But interacting with the mini banner doesn't trigger any events.

@kai.nissen I think this is due to the close tracking ratio? When I force it to 100% locally I see events firing.

@AbbanWMDE Oh right, sorry! Everything looks fine to me now.

Some more change requests:

• The font size and the line height should be increased. The font size should not be smaller in <1090px width.
• The elements in the mini banner don't need to break into two lines.

And probably just because it's not rebased to include the recent fixes:

• The label "Only n days left" shouldn't be displayed.
• The visitors-vs-donors sentence is displaying "displayed over 0 millions times".
• The decimal separator in the custom amount field is rejected.

@kai.nissen

displayed over 0 millions times

I think this is because millionImpressionsPerday is 0 in the campaign config?