Page MenuHomePhabricator
Create Task
Maniphest T320507

convertZObjectToBinary Must Check an Object Is in Valid Normal Form
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • call convertZObjectToBinary on an object like { Z6K1: "DEGENERATE" }
  • watch maximum size be exceeded

What happens?:
Infinite recursion!

What should have happened instead?:
Function should recognize that the Z6 was degenerate and throw an error.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
Update function-schemata sub-module to HEAD (5db8cea)mediawiki/extensions/WikiLambdamaster+4 -8
wikifunctions: Upgrade evaluators from 2024-02-26-150300 to 2024-04-03-210033operations/deployment-chartsmaster+2 -2
wikifunctions: Upgrade orchestrator from 2024-03-05-140533 to 2024-04-04-132719operations/deployment-chartsmaster+1 -1
Customize query in gerrit
TitleReferenceAuthorSource BranchDest Branch
Update function-schemata sub-module to HEAD (5db8cea)repos/abstract-wiki/wikifunctions/function-orchestrator!158apinesync-function-schematamain
Update function-schemata sub-module to HEAD (a4a7edf)repos/abstract-wiki/wikifunctions/wikilambda-cli!35jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (a4a7edf)repos/abstract-wiki/wikifunctions/function-evaluator!202jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (a4a7edf)repos/abstract-wiki/wikifunctions/function-orchestrator!152jforrestersync-function-schematamain
Prevent infinite recursion when a ZObject is degenerate.repos/abstract-wiki/wikifunctions/function-schemata!105apineapine-no-degeneracy-evermain
Customize query in GitLab

Event Timeline

cmassaro created this task.Oct 11 2022, 1:55 PM
cmassaro added a project: good first task.Oct 11 2022, 6:35 PM
Jdforrester-WMF moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.Oct 11 2022, 6:42 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Phase θ – Throttling to Phase κ – Clean-up on the Abstract Wikipedia team board.Nov 21 2022, 8:26 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team (Phase θ – Throttling).
Jdforrester-WMF moved this task from Incoming to Blocking launch on the Abstract Wikipedia team (Phase κ – Clean-up) board.
Jdforrester-WMF triaged this task as Medium priority.Mar 24 2023, 1:18 AM
Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Jun 16 2023, 8:30 AM
Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).
Jdforrester-WMF added a project: Abstract Wikipedia Fix-It tasks.Feb 22 2024, 5:56 PM
Jdforrester-WMF moved this task from To triage: Nice-to-haves to Backlog on the Abstract Wikipedia team board.
cmassaro changed the task status from Open to In Progress.Wed, Mar 20, 7:35 PM
cmassaro claimed this task.
cmassaro moved this task from Backlog to In Progress on the Abstract Wikipedia team board.
CodeReviewBot added a project: Patch-For-Review.Wed, Mar 20, 8:10 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/105

Prevent infinite recursion when a ZObject is degenerate.

CodeReviewBot added a comment.Thu, Mar 21, 11:42 AM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/105

Prevent infinite recursion when a ZObject is degenerate.

Maintenance_bot removed a project: Patch-For-Review.Thu, Mar 21, 12:30 PM
cmassaro moved this task from In Progress to To deploy on the Abstract Wikipedia team board.Fri, Mar 22, 4:14 PM
gerritbot added a comment.Wed, Apr 3, 5:23 PM

Change #1016818 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (a4a7edf)

https://gerrit.wikimedia.org/r/1016818

gerritbot added a project: Patch-For-Review.Wed, Apr 3, 5:23 PM
gerritbot added a comment.Thu, Apr 4, 1:44 PM

Change #1017060 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-03-05-140533 to 2024-04-04-132719

https://gerrit.wikimedia.org/r/1017060

gerritbot added a comment.Thu, Apr 4, 1:44 PM

Change #1017061 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-02-26-150300 to 2024-04-03-210033

https://gerrit.wikimedia.org/r/1017061

gerritbot added a comment.Thu, Apr 4, 4:00 PM

Change #1017060 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-03-05-140533 to 2024-04-04-132719

https://gerrit.wikimedia.org/r/1017060

gerritbot added a comment.Thu, Apr 4, 4:06 PM

Change #1017061 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-02-26-150300 to 2024-04-03-210033

https://gerrit.wikimedia.org/r/1017061

Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.Thu, Apr 4, 4:08 PM
Jdforrester-WMF closed this task as Resolved.Thu, Apr 4, 7:56 PM
gerritbot added a comment.Fri, Apr 12, 6:34 PM

Change #1016818 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (5db8cea)

https://gerrit.wikimedia.org/r/1016818

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL