Maniphest T320567

Normalise $langCodes format in IPInfo ReaderFactory::getReader()
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• AGueyte
	Oct 11 2022, 7:26 PM

Project Tags

Referenced Files

None

Subscribers

Description

Background

In T316665: Use MaxMind translations in country and location data and T318726: Pass context language through to IPInfo API, we are dealing with the user language code that could be returned in different formats.

We want to make sure that $langCodes passed is in the format read by Maxmind:
xx-XX (pr-BR or ch-ZN).
Right now, pt-br will default to English.

Acceptance Criteria

Any lang codes will be normalized to return the proper lang code format.

Testing notes

This can be tested on Beta.

I tested using test data from https://github.com/maxmind/MaxMind-DB, and the IP address 128.101.101.101.

I visited Special:Contributions for that IP address, having set my preferred language via Special:Preferences. I saw:

"United States" when using en
"Estados Unidos" when using es
Without this patch, "United States" when using pt-BR, but with this patch, "Estados Unidos" when using pt-BR

Note that the results are cached locally, so I tested with developer tools open on my browser (Chrome), and "Disable cache" checked under the "Network" tab, to ensure the results refreshed each time I changed my preferences.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Normalise $langCodes format in IPInfo ReaderFactory::getReader	TsepoThoabala	mediawiki/extensions/IPInfo	master	+50 -0

Customize query in gerrit

Related Objects

Mentioned Here: rEIPId6dc8576456c: build: Updating dependencies
T316665: Use MaxMind translations in country and location data
T318726: Pass context language through to IPInfo API

Event Timeline

• AGueyte created this task.Oct 11 2022, 7:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 11 2022, 7:26 PM

• AGueyte renamed this task from Normalise LangCode in ReaderFactory::getReader() to Normalise $langCodes format in IPInfo ReaderFactory::getReader().Oct 11 2022, 7:27 PM

• AGueyte moved this task from Untriaged to IP Info on the Anti-Harassment-Team board.Oct 12 2022, 1:47 PM

Tchanders moved this task from IP Info to Triage/To be Estimated on the Anti-Harassment-Team board.Oct 12 2022, 1:51 PM

Tchanders moved this task from Triage/To be Estimated to AHaT Sprint 18: The Imperial State Crown on the Anti-Harassment-Team board.Oct 12 2022, 2:11 PM

Tchanders edited projects, added: Anti-Harassment-Team (AHaT Sprint 18: The Imperial State Crown); removed: Anti-Harassment-Team.

• TThoabala claimed this task.Oct 13 2022, 8:52 AM

• Prtksxna moved this task from Backlog to In Progress on the IP Info board.Oct 17 2022, 4:37 AM

Change 844441 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/IPInfo@master] Normalise $langCodes format in IPInfo ReaderFactory::getReader

https://gerrit.wikimedia.org/r/844441

gerritbot added a project: Patch-For-Review.Oct 19 2022, 8:44 AM

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment-Team (AHaT Sprint 18: The Imperial State Crown) board.Oct 19 2022, 3:20 PM

• TThoabala moved this task from Code Review 🔍 to In Progress 💪 on the Anti-Harassment-Team (AHaT Sprint 18: The Imperial State Crown) board.Oct 19 2022, 3:50 PM

• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (AHaT Sprint 18: The Imperial State Crown) board.Oct 20 2022, 6:05 AM

ARamirez_WMF edited projects, added: Anti-Harassment-Team (AHaT Sprint 19: The Deerstalker); removed: Anti-Harassment-Team (AHaT Sprint 18: The Imperial State Crown).Oct 25 2022, 4:52 PM

ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment-Team (AHaT Sprint 19: The Deerstalker) board.

Change 844441 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Normalise $langCodes format in IPInfo ReaderFactory::getReader

https://gerrit.wikimedia.org/r/844441

Tchanders updated the task description. (Show Details)Nov 1 2022, 12:58 PM

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment-Team (AHaT Sprint 19: The Deerstalker) board.

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 1 2022, 1:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 1 2022, 1:30 PM

ARamirez_WMF edited projects, added: Anti-Harassment-Team (AHaT Sprint 19: The Sanbenito); removed: Anti-Harassment-Team (AHaT Sprint 19: The Deerstalker).Nov 8 2022, 5:23 AM

ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to QA/Testing 🐞 on the Anti-Harassment-Team (AHaT Sprint 19: The Sanbenito) board.

I tested zh-cn and pt-br on a few different IP addresses. The correct translation showed for City, Subdivision and Country (I don't think the other data have translations).

IPs used (with MaxMind Enterprise data):

2001:240:2000:0:0:0:0:0
1.0.81.0
1.0.64.0

Test environment: local docker IP Info 0.0.0 (d6dc857) 07:12, 16 November 2022.

• Niharika closed this task as Resolved.Dec 8 2022, 1:17 AM

• Niharika moved this task from In Progress to Closed on the IP Info board.Dec 20 2022, 6:14 PM

Normalise $langCodes format in IPInfo ReaderFactory::getReader()Closed, ResolvedPublicActions