Maniphest T320612

(Globally) blocked IP address has no permission to access "Translations" namespace (NS1198)
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Stang
	Oct 12 2022, 10:16 AM

Project Tags

Referenced Files

	F35696143: image.png
	Nov 2 2022, 11:23 AM

	F35696139: image.png
	Nov 2 2022, 11:23 AM

	F35696136: image.png
	Nov 2 2022, 11:23 AM

	F35646817: image.png
	Oct 28 2022, 8:23 AM

	F35620343: image.png
	Oct 24 2022, 1:08 PM

	F35564309: image.png
	Oct 12 2022, 10:16 AM

Subscribers

Description

Steps to replicate the issue (include links if applicable):

(This site should have translate extension installed)
Have an IP address blocked locally and globally
Access a random page in translations namespace from incognito mode

What happens?:
User get a permission error notice:

(permissionserrorstext-withaction: 1, (action-read))

(
(blockedtext: <a href="/wiki/User:Sotiale" title="User:Sotiale">‪Sotiale‬</a>, <a href="https://meta.wikimedia.org/wiki/NOP" class="extiw" title="m:NOP">Open proxy/Webhost</a>: See the <a href="https://meta.wikimedia.org/wiki/WM:OP/H" class="extiw" title="m:WM:OP/H">help page</a> if you are affected: , [redacted], ‪Sotiale‬, [redacted], [redacted], [redacted], [redacted])

)

What should have happened instead?:
There should be nothing happened.

Other information (browser name/version, screenshots, etc.):
Tested on metawiki
Above result happens on a situation where an IP range is globally AND locally blocked.
Only happened if trying to access NS1198, "Translations" namespace

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Translation permission: Return message key and params	Abijeet Patro	mediawiki/extensions/Translate	master	+2 -1
	Message handle permission: Avoid performing checks if action is read	Abijeet Patro	mediawiki/extensions/Translate	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		abi_	T317594 Block translations by users who have been blocked from editing a translatable bundle
		Resolved	BUG REPORT	abi_	T320612 (Globally) blocked IP address has no permission to access "Translations" namespace (NS1198)

Event Timeline

Stang created this task.Oct 12 2022, 10:16 AM

Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptOct 12 2022, 10:16 AM

Stang renamed this task from (Globally) blocked user has no permission to access "Translations" namespace (NS1198) to (Globally) blocked IP address has no permission to access "Translations" namespace (NS1198).Oct 12 2022, 10:24 AM

Stang updated the task description. (Show Details)

Base subscribed.Oct 12 2022, 12:18 PM

This appears to have broken due to changes made for: T317594

Change 841933 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Message handle permission: Avoid performing checks if action is read

https://gerrit.wikimedia.org/r/841933

gerritbot added a project: Patch-For-Review.Oct 12 2022, 2:22 PM

abi_ moved this task from Quarter Backlog to In Review on the Language-Team (Language-2022-October-December) board.Oct 12 2022, 2:22 PM

Change 841933 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Message handle permission: Avoid performing checks if action is read

https://gerrit.wikimedia.org/r/841933

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.6; 2022-10-17).Oct 17 2022, 8:00 AM

Maintenance_bot removed a project: Patch-For-Review.Oct 17 2022, 8:30 AM

Nikerabbit moved this task from In Review to Check after deployment on the Language-Team (Language-2022-October-December) board.Oct 17 2022, 10:33 AM

Nikerabbit moved this task from Backlog to page translation on the MediaWiki-extensions-Translate board.Oct 18 2022, 10:11 AM

@Stang Does it work for you now?

Yeah, I could view pages under Translations namespace now, but when I clicked "Edit" tab, the error message throwed are still plain text (like the screenshot in the description of this task). Could this also be fixed? Thanks.

Nikerabbit moved this task from Check after deployment to Priority: Localization infrastructure on the Language-Team (Language-2022-October-December) board.Oct 24 2022, 5:21 PM

Nikerabbit added a parent task: T317594: Block translations by users who have been blocked from editing a translatable bundle.Oct 27 2022, 8:23 AM

Nikerabbit added projects: Regression, Unplanned-Sprint-Work.Oct 27 2022, 8:48 AM

Change 850410 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Translation permission: Return message key and params

https://gerrit.wikimedia.org/r/850410

gerritbot added a project: Patch-For-Review.Oct 28 2022, 8:14 AM

Thanks for pointing this out again. I missed it and concentrated on fixing the read permission issue. Here's a screenshot from my local machine with this issue addressed:

abi_ moved this task from Priority: Localization infrastructure to In Review on the Language-Team (Language-2022-October-December) board.Oct 28 2022, 8:29 AM

Change 850410 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Translation permission: Return message key and params

https://gerrit.wikimedia.org/r/850410

Maintenance_bot removed a project: Patch-For-Review.Oct 31 2022, 3:30 PM

abi_ moved this task from In Review to Check after deployment on the Language-Team (Language-2022-October-December) board.Oct 31 2022, 3:51 PM

This fix for this went out with MW-1.40-notes (1.40.0-wmf.8; 2022-10-31) and I tested this on Test Wikipedia

Translations are visible:

Editing translations:

Stang unsubscribed.Nov 5 2022, 10:33 PM

(Globally) blocked IP address has no permission to access "Translations" namespace (NS1198)Closed, ResolvedPublicBUG REPORTActions

Description

Details

Related ObjectsSearch...

Event Timeline

(Globally) blocked IP address has no permission to access "Translations" namespace (NS1198)
Closed, ResolvedPublicBUG REPORT
Actions

Related Objects
Search...