| Daimona | |
| Oct 12 2022, 1:15 PM |
| F35810962: Screen Shot 2022-11-21 at 2.37.44 PM.png | |
| Nov 21 2022, 7:38 PM |
| F35788350: Screen Recording 2022-11-16 at 8.43.33 PM.gif | |
| Nov 17 2022, 2:46 AM |
| F35604270: Screen Shot 2022-10-20 at 10.47.42 AM.png | |
| Oct 20 2022, 2:49 PM |
| F35604268: Screen Shot 2022-10-20 at 10.48.14 AM.png | |
| Oct 20 2022, 2:49 PM |
| F35565081: Screen Shot 2022-10-12 at 3.42.30 PM.png | |
| Oct 12 2022, 7:49 PM |
| F35565032: Screen Shot 2022-10-12 at 3.04.24 PM.png | |
| Oct 12 2022, 7:49 PM |
| F35565025: Screen Shot 2022-10-12 at 2.59.45 PM.png | |
| Oct 12 2022, 7:49 PM |
As a campaign organizer, I want to know that 'select all' means to select 100% of participants rather than just the participants that I see on a given page or user interface, so that I understand the total number of participants that I am selecting.
Acceptance Criteria:
Visual examples of current behavior:
Before selecting all
After selecting all
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Change text of select label to read "X of Y participants" | mediawiki/extensions/CampaignEvents | master | +21 -27 |
@ifried I'm trying to think what a clear label would be in this case. In particular, translating this may be hard. We may also want different forms depending on the number of participants. Maybe an option could be "All participants selected ($num)". Still doesn't sound too convincing, but I really don't know :-/
@Daimona: Good point about translation support. In some languages, I believe it would be more common to say "The 10 participants" rather than "All 10 participants." So this means it's probably good for us to reconsider the language.
I actually think "All participants selected ($num)" isn't bad. It conveys the point clearly and it has less quirks that are particular to the English language (I think, but correct me if I am wrong!). If we do this, it's slightly inconsistent with how we display the other numerical selections (such as "2 selected"), see example below:
However, I don't think that's a real problem. The goal is to be as clear as possible, and I think "All participants selected ($num)" is more clear than simply, for example, "7 participants selected" (if 7 is the total number, for example) with no explicit call-out that it is "all" (other than basic logic applied by the user, since it shows the total number of participants at the top). We could also shorten it to "All selected ($num)," if we want.
However, there are two things I noticed when I played around with the checkboxes and selection options, which may impact our language choices:
Here we have "7 selected" for the English version, if I click on each participant checkbox individually (rather than the "Select all" checkbox):
Here we have "All selected" for the English version, if I click on "Select all"
Is there a way to have consistency in language between the two scenarios?
The UX of the "Select all" checkbox is confusing (to me, at least) when a few items are selected by the user. For example, when it says "2 selected" and there is an empty checkbox at the top, it's not clear what the checkbox represents or if the user should click on it. Then, if the user does click on it, their selection will be erased and all usernames will be selected. This could be frustrating for the user who misunderstood its purpose. It seems to make more sense to have the "2 selected" text to be separate from the checkbox and for it to always have the label to "Select all," so its purpose is clear. What do other people think?
Change 850523 had a related patch set uploaded (by Mhorsey; author: Mhorsey):
[mediawiki/extensions/CampaignEvents@master] Change test of select label to read "X of Y participants"
@vaughnwalters One thing to note: the number shown when you use "select all" is currently wrong. For instance, if there are 50 participants but only the first 20 are visible and you click "select all", the label will read "20 out of 50 selected". This will be fixed with T320649.
Change 850523 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] Change text of select label to read "X of Y participants"
On the Special:EventDetails, change:
✅ Change the language from "All selected" or "$num selected" to "$num out of $total selected" in the label
The text is correctly changed, moving this to product sign off.
